fix extract and inject

src/plugins/dashboard/common/dashboard_saved_object/persistable_state/dashboard_saved_object_references.ts

@@ -16,6 +16,10 @@ import {
 } from '../../lib/dashboard_panel_converters';
 import { DashboardAttributesAndReferences, ParsedDashboardAttributesWithType } from '../../types';
 import { DashboardAttributes, SavedDashboardPanel } from '../../content_management';
+import {
+  createExtract,
+  createInject,
+} from '../../dashboard_container/persistable_state/dashboard_container_references';
 
 export interface InjectExtractDeps {
   embeddablePersistableStateService: EmbeddablePersistableStateService;
@@ -45,10 +49,8 @@ export function injectReferences(
   const parsedAttributes = parseDashboardAttributesWithType(attributes);
 
   // inject references back into panels via the Embeddable persistable state service.
-  const injectedState = deps.embeddablePersistableStateService.inject(
-    parsedAttributes,
-    references
-  ) as ParsedDashboardAttributesWithType;
+  const inject = createInject(deps.embeddablePersistableStateService);
+  const injectedState = inject(parsedAttributes, references) as ParsedDashboardAttributesWithType;
   const injectedPanels = convertPanelMapToSavedPanels(injectedState.panels);
 
   const newAttributes = {
@@ -74,11 +76,11 @@ export function extractReferences(
     );
   }
 
-  const { references: extractedReferences, state: extractedState } =
-    deps.embeddablePersistableStateService.extract(parsedAttributes) as {
-      references: Reference[];
-      state: ParsedDashboardAttributesWithType;
-    };
+  const extract = createExtract(deps.embeddablePersistableStateService);
+  const { references: extractedReferences, state: extractedState } = extract(parsedAttributes) as {
+    references: Reference[];
+    state: ParsedDashboardAttributesWithType;
+  };
   const extractedPanels = convertPanelMapToSavedPanels(extractedState.panels);
 
   const newAttributes = {

src/plugins/dashboard/public/dashboard_container/external_api/dashboard_renderer.tsx

@@ -59,7 +59,7 @@ export function DashboardRenderer({
 
   const dashboardFactory = useMemo(() => {
     return new DashboardContainerFactoryDefinition(embeddableService);
-  }, [embeddableService])
+  }, []);
 
   useEffect(() => {
     /* In case the locator prop changes, we need to reassign the value in the container */
@@ -193,4 +193,4 @@ const ParentClassController = ({
     }
   }, [maximizedPanelId, viewportRef.parentElement]);
   return null;
-};
+};

src/plugins/dashboard/public/plugin.tsx

@@ -349,4 +349,4 @@ export class DashboardPlugin
       this.stopUrlTracking();
     }
   }
-}
+}