refactor: 💡 revert addTriggerAction() change

elastic · Apr 15, 2020 · 1bad7d2 · 1bad7d2
1 parent 7772ba6
commit 1bad7d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/plugins/ui_actions/public/service/ui_actions_service.ts b/src/plugins/ui_actions/public/service/ui_actions_service.ts
@@ -139,9 +139,7 @@ export class UiActionsService {
     triggerId: TType,
     // The action can accept partial or no context, but if it needs context not provided
     // by this type of trigger, typescript will complain. yay!
-    action:
-      | (ActionByType<AType> & Action<TriggerContextMapping[TType]>)
-      | ActionDefinition<ActionContextMapping[AType]>
+    action: ActionByType<AType> & Action<TriggerContextMapping[TType]>
   ): void => {
     if (!this.actions.has(action.id)) this.registerAction(action);
     this.attachAction(triggerId, action.id);

diff --git a/x-pack/plugins/embeddable_enhanced/public/plugin.ts b/x-pack/plugins/embeddable_enhanced/public/plugin.ts
@@ -58,10 +58,9 @@ export class EmbeddableEnhancedPlugin
   public setup(core: CoreSetup<StartDependencies>, plugins: SetupDependencies): SetupContract {
     this.setCustomEmbeddableFactoryProvider(plugins);
 
-    plugins.advancedUiActions.addTriggerAction(
-      PANEL_NOTIFICATION_TRIGGER,
-      new PanelNotificationsAction()
-    );
+    const panelNotificationAction = new PanelNotificationsAction();
+    plugins.advancedUiActions.registerAction(panelNotificationAction);
+    plugins.advancedUiActions.attachAction(PANEL_NOTIFICATION_TRIGGER, panelNotificationAction.id);
 
     return {};
   }