Skip to content

Commit

Permalink
Prefer sequential awaits to .then()
Browse files Browse the repository at this point in the history
  • Loading branch information
rylnd committed Apr 17, 2020
1 parent 5dca952 commit 1ce95d9
Showing 1 changed file with 11 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,17 +50,18 @@ export default ({ getService }: FtrProviderContext): void => {
.send(getSimpleRule())
.expect(200);

await new Promise(resolve => setTimeout(resolve, 5000)).then(async () => {
// query the single rule from _find
const { body } = await supertest
.post(`${DETECTION_ENGINE_RULES_URL}/_find_statuses`)
.set('kbn-xsrf', 'true')
.send({ ids: [resBody.id] })
.expect(200);
// wait for Task Manager to execute the rule and update status
await new Promise(resolve => setTimeout(resolve, 5000));

// expected result for status should be 'going to run' or 'succeeded
expect(['succeeded', 'going to run']).to.contain(body[resBody.id].current_status.status);
});
// query the single rule from _find
const { body } = await supertest
.post(`${DETECTION_ENGINE_RULES_URL}/_find_statuses`)
.set('kbn-xsrf', 'true')
.send({ ids: [resBody.id] })
.expect(200);

// expected result for status should be 'going to run' or 'succeeded
expect(['succeeded', 'going to run']).to.contain(body[resBody.id].current_status.status);
});
});
};

0 comments on commit 1ce95d9

Please sign in to comment.