Remove the last fontawesome usages

elastic · Oct 16, 2020 · 2091533 · 2091533
1 parent ee614e8
commit 2091533
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/plugins/timelion/public/directives/saved_object_finder.html b/src/plugins/timelion/public/directives/saved_object_finder.html
@@ -67,10 +67,8 @@
  i18n-id="timelion.savedObjectFinder.sortByButtonLabel"
  i18n-default-message="Name"
  ></span>
- <span
- class="fa"
- ng-class="finder.isAscending ? 'fa-caret-up' : 'fa-caret-down'"
- >
+ <icon type="'sortUp'" ng-if="finder.isAscending"></icon>
+ <icon type="'sortDown'" ng-if="!finder.isAscending"></icon>
  <span class="euiScreenReaderOnly"
  ng-if="finder.isAscending"
  i18n-id="timelion.savedObjectFinder.sortByButtonLabeAscendingScreenReaderOnly"
@@ -94,7 +92,7 @@
  <a ng-href="{{finder.makeUrl(hit)}}"
  ng-blur="finder.hitBlur($event)"
  ng-click="finder.preventClick($event)">
- <span aria-hidden="true" class="finder-type fa" ng-if="hit.icon" ng-class="hit.icon"></span>
+ <icon aria-hidden="true" class="finder-type" ng-if="hit.icon" ng-class="hit.icon"></icon>
  <icon type="'beaker'" ng-if="hit.type.shouldMarkAsExperimentalInUI()"></icon>
  <span>{{hit.title}}</span>
  <p ng-if="hit.description" ng-bind="hit.description"></p>

diff --git a/src/plugins/timelion/public/directives/saved_object_finder.js b/src/plugins/timelion/public/directives/saved_object_finder.js
@@ -168,7 +168,6 @@ export function initSavedObjectFinderDirective(app, savedSheetLoader, uiSettings
  switch (keyMap[$event.keyCode]) {
  case 'enter':
  if (self.hitCount !== 1) return;
-
  const hit = self.hits[0];
  if (!hit) return;