ts lint cleanup

elastic · Mar 6, 2020 · 2467231 · 2467231
1 parent 468994d
commit 2467231
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 16 deletions.
diff --git a/x-pack/legacy/plugins/maps/public/layers/sources/es_term_source.d.ts b/x-pack/legacy/plugins/maps/public/layers/sources/es_term_source.d.ts
@@ -5,8 +5,8 @@
  */
 
 import { IField } from '../fields/field';
+import { IESAggSource } from './es_agg_source';
 
-// TODO extend AbstractESAggSource once its merged
-export interface IESTermSource {
+export interface IESTermSource extends IESAggSource {
   getTermField(): IField;
 }
diff --git a/x-pack/legacy/plugins/maps/public/layers/tooltips/es_tooltip_property.ts b/x-pack/legacy/plugins/maps/public/layers/tooltips/es_tooltip_property.ts
@@ -53,23 +53,22 @@ export class ESTooltipProperty implements ITooltipProperty {
   }
 
   isFilterable(): boolean {
-    const field = this._getIndexPatternField();
+    const indexPatternField = this._getIndexPatternField();
     return (
-      field &&
-      (field.type === 'string' ||
-        field.type === 'date' ||
-        field.type === 'ip' ||
-        field.type === 'number')
+      !!indexPatternField &&
+      (indexPatternField.type === 'string' ||
+        indexPatternField.type === 'date' ||
+        indexPatternField.type === 'ip' ||
+        indexPatternField.type === 'number')
     );
   }
 
-  async getESFilters(): Promise<unknown> {
-    return [
-      esFilters.buildPhraseFilter(
-        this._getIndexPatternField(),
-        this.getRawValue(),
-        this._indexPattern
-      ),
-    ];
+  async getESFilters(): Promise<unknown[]> {
+    const indexPatternField = this._getIndexPatternField();
+    if (!indexPatternField) {
+      return [];
+    }
+
+    return [esFilters.buildPhraseFilter(indexPatternField, this.getRawValue(), this._indexPattern)];
   }
 }