Rename buildAncestorsSignal to buildAncestors

elastic · Sep 3, 2020 · 2c9d038 · 2c9d038
1 parent d818f21
commit 2c9d038
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_signal.test.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_signal.test.ts
@@ -5,12 +5,7 @@
  */
 
 import { sampleDocNoSortId } from './__mocks__/es_results';
-import {
- buildSignal,
- buildParent,
- buildAncestorsSignal,
- additionalSignalFields,
-} from './build_signal';
+import { buildSignal, buildParent, buildAncestors, additionalSignalFields } from './build_signal';
 import { Signal, Ancestor } from './types';
 import { getPartialRulesSchemaMock } from '../../../../common/detection_engine/schemas/response/rules_schema.mocks';
 
@@ -215,7 +210,7 @@ describe('buildSignal', () => {
  kind: 'event',
  module: 'system',
  };
- const signal = buildAncestorsSignal(doc);
+ const signal = buildAncestors(doc);
  const expected: Ancestor[] = [
  {
  id: 'd5e8eb51-a6a0-456d-8a15-4b79bfec3d71',
@@ -255,7 +250,7 @@ describe('buildSignal', () => {
  },
  depth: 1,
  };
- const signal = buildAncestorsSignal(doc);
+ const signal = buildAncestors(doc);
  const expected: Ancestor[] = [
  {
  id: '730ddf9e-5a00-4f85-9ddf-5878ca511a87',

diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_signal.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/build_signal.ts
@@ -38,7 +38,7 @@ export const buildParent = (doc: SignalSourceHit): Ancestor => {
  * creating an array of N+1 ancestors.
  * @param doc The parent signal/event for which to extend the ancestry.
  */
-export const buildAncestorsSignal = (doc: SignalSourceHit): Signal['ancestors'] => {
+export const buildAncestors = (doc: SignalSourceHit): Signal['ancestors'] => {
  const newAncestor = buildParent(doc);
  const existingAncestors = doc._source.signal?.ancestors;
  if (existingAncestors != null) {
@@ -56,10 +56,7 @@ export const buildAncestorsSignal = (doc: SignalSourceHit): Signal['ancestors']
 export const buildSignal = (docs: SignalSourceHit[], rule: Partial<RulesSchema>): Signal => {
  const parents = docs.map(buildParent);
  const depth = parents.reduce((acc, parent) => Math.max(parent.depth, acc), 0) + 1;
- const ancestors = docs.reduce(
- (acc: Ancestor[], doc) => acc.concat(buildAncestorsSignal(doc)),
- []
- );
+ const ancestors = docs.reduce((acc: Ancestor[], doc) => acc.concat(buildAncestors(doc)), []);
  return {
  parents,
  ancestors,