Merge branch 'master' into fix/event-viewer-dnd-cypress

docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.embeddable.fatalerror.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-embeddable-public](./kibana-plugin-plugins-embeddable-public.md) &gt; [Embeddable](./kibana-plugin-plugins-embeddable-public.embeddable.md) &gt; [fatalError](./kibana-plugin-plugins-embeddable-public.embeddable.fatalerror.md)
+
+## Embeddable.fatalError property
+
+<b>Signature:</b>
+
+```typescript
+fatalError?: Error;
+```

docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.embeddable.md

@@ -20,6 +20,7 @@ export declare abstract class Embeddable<TEmbeddableInput extends EmbeddableInpu
 
 | Property | Modifiers | Type | Description |
 | --- | --- | --- | --- |
+| [fatalError](./kibana-plugin-plugins-embeddable-public.embeddable.fatalerror.md) | | <code>Error</code> | |
 | [id](./kibana-plugin-plugins-embeddable-public.embeddable.id.md) | | <code>string</code> | |
 | [input](./kibana-plugin-plugins-embeddable-public.embeddable.input.md) | | <code>TEmbeddableInput</code> | |
 | [isContainer](./kibana-plugin-plugins-embeddable-public.embeddable.iscontainer.md) | | <code>boolean</code> | |
@@ -43,6 +44,7 @@ export declare abstract class Embeddable<TEmbeddableInput extends EmbeddableInpu
 | [getOutput$()](./kibana-plugin-plugins-embeddable-public.embeddable.getoutput_.md) | | |
 | [getRoot()](./kibana-plugin-plugins-embeddable-public.embeddable.getroot.md) | | Returns the top most parent embeddable, or itself if this embeddable is not within a parent. |
 | [getTitle()](./kibana-plugin-plugins-embeddable-public.embeddable.gettitle.md) | | |
+| [onFatalError(e)](./kibana-plugin-plugins-embeddable-public.embeddable.onfatalerror.md) | | |
 | [reload()](./kibana-plugin-plugins-embeddable-public.embeddable.reload.md) | | Reload will be called when there is a request to refresh the data or view, even if the input data did not change. |
 | [render(el)](./kibana-plugin-plugins-embeddable-public.embeddable.render.md) | | |
 | [supportedTriggers()](./kibana-plugin-plugins-embeddable-public.embeddable.supportedtriggers.md) | | |

docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.embeddable.onfatalerror.md

@@ -0,0 +1,22 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-embeddable-public](./kibana-plugin-plugins-embeddable-public.md) &gt; [Embeddable](./kibana-plugin-plugins-embeddable-public.embeddable.md) &gt; [onFatalError](./kibana-plugin-plugins-embeddable-public.embeddable.onfatalerror.md)
+
+## Embeddable.onFatalError() method
+
+<b>Signature:</b>
+
+```typescript
+protected onFatalError(e: Error): void;
+```
+
+## Parameters
+
+| Parameter | Type | Description |
+| --- | --- | --- |
+| e | <code>Error</code> | |
+
+<b>Returns:</b>
+
+`void`
+

docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.iembeddable.fatalerror.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-embeddable-public](./kibana-plugin-plugins-embeddable-public.md) &gt; [IEmbeddable](./kibana-plugin-plugins-embeddable-public.iembeddable.md) &gt; [fatalError](./kibana-plugin-plugins-embeddable-public.iembeddable.fatalerror.md)
+
+## IEmbeddable.fatalError property
+
+If this embeddable has encountered a fatal error, that error will be stored here
+
+<b>Signature:</b>
+
+```typescript
+fatalError?: Error;
+```

docs/development/plugins/embeddable/public/kibana-plugin-plugins-embeddable-public.iembeddable.md

@@ -15,6 +15,7 @@ export interface IEmbeddable<I extends EmbeddableInput = EmbeddableInput, O exte
 | Property | Type | Description |
 | --- | --- | --- |
 | [enhancements](./kibana-plugin-plugins-embeddable-public.iembeddable.enhancements.md) | <code>object</code> | Extra abilities added to Embeddable by <code>*_enhanced</code> plugins. |
+| [fatalError](./kibana-plugin-plugins-embeddable-public.iembeddable.fatalerror.md) | <code>Error</code> | If this embeddable has encountered a fatal error, that error will be stored here |
 | [id](./kibana-plugin-plugins-embeddable-public.iembeddable.id.md) | <code>string</code> | A unique identifier for this embeddable. Mainly only used by containers to map their Panel States to a child embeddable instance. |
 | [isContainer](./kibana-plugin-plugins-embeddable-public.iembeddable.iscontainer.md) | <code>boolean</code> | Is this embeddable an instance of a Container class, can it contain nested embeddables? |
 | [parent](./kibana-plugin-plugins-embeddable-public.iembeddable.parent.md) | <code>IContainer</code> | If this embeddable is nested inside a container, this will contain a reference to its parent. |

docs/user/alerting/alerting-getting-started.asciidoc

@@ -169,12 +169,15 @@ If you are using an *on-premises* Elastic Stack deployment with <<using-kibana-w
 
 To access alerting in a space, a user must have access to one of the following features:
 
+* Alerting
 * <<xpack-apm,*APM*>>
+* <<logs-app,*Logs*>>
 * <<metrics-app,*Metrics*>>
 * <<xpack-siem,*Security*>>
 * <<uptime-app,*Uptime*>>
 
-See <<kibana-feature-privileges, feature privileges>> for more information on configuring roles that provide access to these features. 
+See <<kibana-feature-privileges, feature privileges>> for more information on configuring roles that provide access to these features.
+Also note that a user will need +read+ privileges for the *Actions and Connectors* feature to attach actions to an alert or to edit an alert that has an action attached to it.
 
 [float]
 [[alerting-spaces]]

src/dev/build/tasks/os_packages/docker_generator/run.ts

@@ -40,7 +40,7 @@ export async function runDockerGenerator(
  ubi: boolean = false
 ) {
  // UBI var config
- const baseOSImage = ubi ? 'docker.elastic.co/ubi8/ubi-minimal:latest' : 'centos:8';
+ const baseOSImage = ubi ? 'docker.elastic.co/ubi8/ubi-minimal:8.2' : 'centos:8';
  const ubiVersionTag = 'ubi8';
  const ubiImageFlavor = ubi ? `-${ubiVersionTag}` : '';
 

src/plugins/dashboard/public/application/actions/add_to_library_action.test.tsx

@@ -35,7 +35,7 @@ import { coreMock } from '../../../../../core/public/mocks';
 import { CoreStart } from 'kibana/public';
 import { AddToLibraryAction } from '.';
 import { embeddablePluginMock } from 'src/plugins/embeddable/public/mocks';
-import { ViewMode } from '../../../../embeddable/public';
+import { ErrorEmbeddable, ViewMode } from '../../../../embeddable/public';
 
 const { setup, doStart } = embeddablePluginMock.createInstance();
 setup.registerEmbeddableFactory(
@@ -86,6 +86,16 @@ beforeEach(async () => {
  }
 });
 
+test('Add to library is incompatible with Error Embeddables', async () => {
+ const action = new AddToLibraryAction({ toasts: coreStart.notifications.toasts });
+ const errorEmbeddable = new ErrorEmbeddable(
+ 'Wow what an awful error',
+ { id: ' 404' },
+ embeddable.getRoot() as IContainer
+ );
+ expect(await action.isCompatible({ embeddable: errorEmbeddable })).toBe(false);
+});
+
 test('Add to library is compatible when embeddable on dashboard has value type input', async () => {
  const action = new AddToLibraryAction({ toasts: coreStart.notifications.toasts });
  embeddable.updateInput(await embeddable.getInputAsValueType());

src/plugins/dashboard/public/application/actions/add_to_library_action.tsx

@@ -26,6 +26,7 @@ import {
  PanelNotFoundError,
  EmbeddableInput,
  isReferenceOrValueEmbeddable,
+ isErrorEmbeddable,
 } from '../../../../embeddable/public';
 import { NotificationsStart } from '../../../../../core/public';
 import { DashboardPanelState, DASHBOARD_CONTAINER_TYPE, DashboardContainer } from '..';
@@ -61,7 +62,8 @@ export class AddToLibraryAction implements ActionByType<typeof ACTION_ADD_TO_LIB
 
  public async isCompatible({ embeddable }: AddToLibraryActionContext) {
  return Boolean(
- embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
+ !isErrorEmbeddable(embeddable) &&
+ embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
  embeddable.getRoot() &&
  embeddable.getRoot().isContainer &&
  embeddable.getRoot().type === DASHBOARD_CONTAINER_TYPE &&

src/plugins/dashboard/public/application/actions/clone_panel_action.test.tsx

@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { isErrorEmbeddable, IContainer } from '../../embeddable_plugin';
+import { isErrorEmbeddable, IContainer, ErrorEmbeddable } from '../../embeddable_plugin';
 import { DashboardContainer, DashboardPanelState } from '../embeddable';
 import { getSampleDashboardInput, getSampleDashboardPanel } from '../test_helpers';
 import {
@@ -86,6 +86,16 @@ beforeEach(async () => {
  }
 });
 
+test('Clone is incompatible with Error Embeddables', async () => {
+ const action = new ClonePanelAction(coreStart);
+ const errorEmbeddable = new ErrorEmbeddable(
+ 'Wow what an awful error',
+ { id: ' 404' },
+ embeddable.getRoot() as IContainer
+ );
+ expect(await action.isCompatible({ embeddable: errorEmbeddable })).toBe(false);
+});
+
 test('Clone adds a new embeddable', async () => {
  const dashboard = embeddable.getRoot() as IContainer;
  const originalPanelCount = Object.keys(dashboard.getInput().panels).length;

src/plugins/dashboard/public/application/actions/clone_panel_action.tsx

@@ -28,6 +28,7 @@ import {
  PanelNotFoundError,
  EmbeddableInput,
  SavedObjectEmbeddableInput,
+ isErrorEmbeddable,
 } from '../../../../embeddable/public';
 import {
  placePanelBeside,
@@ -66,7 +67,8 @@ export class ClonePanelAction implements ActionByType<typeof ACTION_CLONE_PANEL>
 
  public async isCompatible({ embeddable }: ClonePanelActionContext) {
  return Boolean(
- embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
+ !isErrorEmbeddable(embeddable) &&
+ embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
  embeddable.getRoot() &&
  embeddable.getRoot().isContainer &&
  embeddable.getRoot().type === DASHBOARD_CONTAINER_TYPE

src/plugins/dashboard/public/application/actions/library_notification_action.test.tsx

@@ -30,7 +30,7 @@ import { coreMock } from '../../../../../core/public/mocks';
 import { CoreStart } from 'kibana/public';
 import { LibraryNotificationAction, UnlinkFromLibraryAction } from '.';
 import { embeddablePluginMock } from 'src/plugins/embeddable/public/mocks';
-import { ViewMode } from '../../../../embeddable/public';
+import { ErrorEmbeddable, IContainer, ViewMode } from '../../../../embeddable/public';
 
 const { setup, doStart } = embeddablePluginMock.createInstance();
 setup.registerEmbeddableFactory(
@@ -87,6 +87,16 @@ beforeEach(async () => {
  embeddable.updateInput({ viewMode: ViewMode.EDIT });
 });
 
+test('Notification is incompatible with Error Embeddables', async () => {
+ const action = new LibraryNotificationAction(unlinkAction);
+ const errorEmbeddable = new ErrorEmbeddable(
+ 'Wow what an awful error',
+ { id: ' 404' },
+ embeddable.getRoot() as IContainer
+ );
+ expect(await action.isCompatible({ embeddable: errorEmbeddable })).toBe(false);
+});
+
 test('Notification is shown when embeddable on dashboard has reference type input', async () => {
  const action = new LibraryNotificationAction(unlinkAction);
  embeddable.updateInput(await embeddable.getInputAsRefType());

src/plugins/dashboard/public/application/actions/library_notification_action.tsx

@@ -19,7 +19,12 @@
 
 import { i18n } from '@kbn/i18n';
 import React from 'react';
-import { IEmbeddable, ViewMode, isReferenceOrValueEmbeddable } from '../../embeddable_plugin';
+import {
+ IEmbeddable,
+ ViewMode,
+ isReferenceOrValueEmbeddable,
+ isErrorEmbeddable,
+} from '../../embeddable_plugin';
 import { ActionByType, IncompatibleActionError } from '../../ui_actions_plugin';
 import { reactToUiComponent } from '../../../../kibana_react/public';
 import { UnlinkFromLibraryAction } from '.';
@@ -79,6 +84,7 @@ export class LibraryNotificationAction implements ActionByType<typeof ACTION_LIB
 
  public isCompatible = async ({ embeddable }: LibraryNotificationActionContext) => {
  return (
+ !isErrorEmbeddable(embeddable) &&
  embeddable.getRoot().isContainer &&
  embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
  isReferenceOrValueEmbeddable(embeddable) &&

src/plugins/dashboard/public/application/actions/unlink_from_library_action.test.tsx

@@ -30,7 +30,11 @@ import { coreMock } from '../../../../../core/public/mocks';
 import { CoreStart } from 'kibana/public';
 import { UnlinkFromLibraryAction } from '.';
 import { embeddablePluginMock } from 'src/plugins/embeddable/public/mocks';
-import { ViewMode, SavedObjectEmbeddableInput } from '../../../../embeddable/public';
+import {
+ ViewMode,
+ SavedObjectEmbeddableInput,
+ ErrorEmbeddable,
+} from '../../../../embeddable/public';
 
 const { setup, doStart } = embeddablePluginMock.createInstance();
 setup.registerEmbeddableFactory(
@@ -80,6 +84,16 @@ beforeEach(async () => {
  embeddable.updateInput({ viewMode: ViewMode.EDIT });
 });
 
+test('Unlink is incompatible with Error Embeddables', async () => {
+ const action = new UnlinkFromLibraryAction({ toasts: coreStart.notifications.toasts });
+ const errorEmbeddable = new ErrorEmbeddable(
+ 'Wow what an awful error',
+ { id: ' 404' },
+ embeddable.getRoot() as IContainer
+ );
+ expect(await action.isCompatible({ embeddable: errorEmbeddable })).toBe(false);
+});
+
 test('Unlink is compatible when embeddable on dashboard has reference type input', async () => {
  const action = new UnlinkFromLibraryAction({ toasts: coreStart.notifications.toasts });
  embeddable.updateInput(await embeddable.getInputAsRefType());

src/plugins/dashboard/public/application/actions/unlink_from_library_action.tsx

@@ -26,6 +26,7 @@ import {
  PanelNotFoundError,
  EmbeddableInput,
  isReferenceOrValueEmbeddable,
+ isErrorEmbeddable,
 } from '../../../../embeddable/public';
 import { NotificationsStart } from '../../../../../core/public';
 import { DashboardPanelState, DASHBOARD_CONTAINER_TYPE, DashboardContainer } from '..';
@@ -61,7 +62,8 @@ export class UnlinkFromLibraryAction implements ActionByType<typeof ACTION_UNLIN
 
  public async isCompatible({ embeddable }: UnlinkFromLibraryActionContext) {
  return Boolean(
- embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
+ !isErrorEmbeddable(embeddable) &&
+ embeddable.getInput()?.viewMode !== ViewMode.VIEW &&
  embeddable.getRoot() &&
  embeddable.getRoot().isContainer &&
  embeddable.getRoot().type === DASHBOARD_CONTAINER_TYPE &&

src/plugins/dashboard/public/application/dashboard_app_controller.tsx

@@ -26,7 +26,7 @@ import ReactDOM from 'react-dom';
 import angular from 'angular';
 import deepEqual from 'fast-deep-equal';
 
-import { Observable, pipe, Subscription, merge } from 'rxjs';
+import { Observable, pipe, Subscription, merge, EMPTY } from 'rxjs';
 import {
  filter,
  map,
@@ -35,6 +35,7 @@ import {
  startWith,
  switchMap,
  distinctUntilChanged,
+ catchError,
 } from 'rxjs/operators';
 import { History } from 'history';
 import { SavedObjectSaveOpts, SavedObject } from 'src/plugins/saved_objects/public';
@@ -464,7 +465,10 @@ export class DashboardAppController {
  switchMap((newChildIds: string[]) =>
  merge(
  ...newChildIds.map((childId) =>
- dashboardContainer!.getChild(childId).getOutput$()
+ dashboardContainer!
+ .getChild(childId)
+ .getOutput$()
+ .pipe(catchError(() => EMPTY))
  )
  )
  )

src/plugins/embeddable/public/lib/embeddables/embeddable.tsx

@@ -43,6 +43,7 @@ export abstract class Embeddable<
  public readonly isContainer: boolean = false;
  public abstract readonly type: string;
  public readonly id: string;
+ public fatalError?: Error;
 
  protected output: TEmbeddableOutput;
  protected input: TEmbeddableInput;
@@ -88,9 +89,12 @@ export abstract class Embeddable<
  map(({ title }) => title || ''),
  distinctUntilChanged()
  )
- .subscribe((title) => {
- this.renderComplete.setTitle(title);
- });
+ .subscribe(
+ (title) => {
+ this.renderComplete.setTitle(title);
+ },
+ () => {}
+ );
  }
 
  public getIsContainer(): this is IContainer {
@@ -193,6 +197,11 @@ export abstract class Embeddable<
  }
  }
 
+ protected onFatalError(e: Error) {
+ this.fatalError = e;
+ this.output$.error(e);
+ }
+
  private onResetInput(newInput: TEmbeddableInput) {
  if (!isEqual(this.input, newInput)) {
  const oldLastReloadRequestTime = this.input.lastReloadRequestTime;

src/plugins/embeddable/public/lib/embeddables/error_embeddable.tsx

@@ -30,7 +30,7 @@ export const ERROR_EMBEDDABLE_TYPE = 'error';
 export function isErrorEmbeddable<TEmbeddable extends IEmbeddable>(
  embeddable: TEmbeddable | ErrorEmbeddable
 ): embeddable is ErrorEmbeddable {
- return (embeddable as ErrorEmbeddable).error !== undefined;
+ return Boolean(embeddable.fatalError || (embeddable as ErrorEmbeddable).error !== undefined);
 }
 
 export class ErrorEmbeddable extends Embeddable<EmbeddableInput, EmbeddableOutput> {

src/plugins/embeddable/public/lib/embeddables/i_embeddable.ts

@@ -85,6 +85,11 @@ export interface IEmbeddable<
  */
  enhancements?: object;
 
+ /**
+ * If this embeddable has encountered a fatal error, that error will be stored here
+ **/
+ fatalError?: Error;
+
  /**
  * A functional representation of the isContainer variable, but helpful for typescript to
  * know the shape if this returns true