Skip to content

Commit

Permalink
Drop using try / catch directly and instead,
Browse files Browse the repository at this point in the history
update handleFail fn to not slack notifiy
if the build is unstable, per Brian S.
  • Loading branch information
wayneseymour committed Jun 30, 2020
1 parent 8d70c7d commit 3c9c99f
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .ci/Jenkinsfile_coverage
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,11 @@ kibanaPipeline(timeoutMinutes: 240) {
'CODE_COVERAGE=1', // Enables coverage. Needed for multiple ci scripts, such as remote.ts, test/scripts/*.sh, schema.js, etc.
]) {
workers.base(name: 'coverage-worker', size: 'l', ramDisk: false, bootstrapped: false) {
try {
catchError {
kibanaCoverage.runTests()
handleIngestion(TIME_STAMP)
} catch (err) {
currentBuild.result = 'FAILURE'
handleFail()
}
handleFail()
}
}
kibanaPipeline.sendMail()
Expand All @@ -36,7 +34,7 @@ def handleIngestion(timestamp) {

def handleFail() {
def buildStatus = buildUtils.getBuildStatus()
if(params.NOTIFY_ON_FAILURE && buildStatus != 'SUCCESS' && buildStatus != 'ABORTED') {
if(params.NOTIFY_ON_FAILURE && buildStatus != 'SUCCESS' && buildStatus != 'ABORTED' && buildStatus != 'UNSTABLE') {
slackNotifications.sendFailedBuild(
channel: '#kibana-qa',
username: 'Kibana QA'
Expand Down

0 comments on commit 3c9c99f

Please sign in to comment.