Skip to content

Commit

Permalink
Unskip heatmap suite and fixes flakiness (#96941) (#97077)
Browse files Browse the repository at this point in the history
  • Loading branch information
stratoula authored Apr 14, 2021
1 parent c046960 commit 3f2a01e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
3 changes: 1 addition & 2 deletions test/functional/apps/visualize/_heatmap_chart.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const inspector = getService('inspector');
const PageObjects = getPageObjects(['visualize', 'visEditor', 'visChart', 'timePicker']);

// FLAKY: https://github.com/elastic/kibana/issues/95642
describe.skip('heatmap chart', function indexPatternCreation() {
describe('heatmap chart', function indexPatternCreation() {
const vizName1 = 'Visualization HeatmapChart';

before(async function () {
Expand Down
5 changes: 0 additions & 5 deletions test/functional/apps/visualize/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,6 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
loadTestFile(require.resolve('./_point_series_options'));
loadTestFile(require.resolve('./_vertical_bar_chart'));
loadTestFile(require.resolve('./_vertical_bar_chart_nontimeindex'));

// Test non-replaced vislib chart types
loadTestFile(require.resolve('./_gauge_chart'));
loadTestFile(require.resolve('./_heatmap_chart'));
loadTestFile(require.resolve('./_pie_chart'));
});

describe('', function () {
Expand Down
4 changes: 1 addition & 3 deletions test/functional/page_objects/visualize_editor_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,7 @@ export function VisualizeEditorPageProvider({ getService, getPageObjects }: FtrP
}

public async changeHeatmapColorNumbers(value = 6) {
const input = await testSubjects.find(`heatmapColorsNumber`);
await input.clearValueWithKeyboard();
await input.type(`${value}`);
await testSubjects.setValue('heatmapColorsNumber', `${value}`);
}

public async getBucketErrorMessage() {
Expand Down

0 comments on commit 3f2a01e

Please sign in to comment.