Fix flaky dashboard color legend (#22341) (#22545)

* Rebuild modulePath correctly if on Windows

* Adding 1 second sleep to fix flaky test

* Wait to find a gear in the visualization after clicking Edit

* Revert "Wait to find a gear in the visualization after clicking Edit"

This reverts commit 8dac3fb.

* use waitForRenderComplete and change that to 1s timeout

* Use sleep until TagCloud data-render-complete is fixed

* Different getIsInEditMode courtesy of @chrisdavies

* combine switchToEditMode into one method

test/functional/page_objects/dashboard_page.js

@@ -176,9 +176,14 @@ export function DashboardPageProvider({ getService, getPageObjects }) {
     async switchToEditMode() {
       log.debug('Switching to edit mode');
       await testSubjects.click('dashboardEditMode');
-      await retry.waitFor('not in view mode', async () => (
-        !await this.getIsInViewMode()
-      ));
+      // wait until the count of dashboard panels equals the count of toggle menu icons
+      await retry.waitFor('in edit mode', async () => {
+        const [panels, menuIcons] = await Promise.all([
+          testSubjects.findAll('dashboardPanel'),
+          testSubjects.findAll('dashboardPanelToggleMenuIcon'),
+        ]);
+        return panels.length === menuIcons.length;
+      });
     }
 
     async getIsInViewMode() {

test/functional/services/renderable.js

@@ -42,7 +42,7 @@ export function RenderableProvider({ getService }) {
           throw new Error(`${completedElements.length} elements completed rendering, waiting on a total of ${count}`);
         }
 
-        const stillLoadingElements = await find.allByCssSelector(DATA_LOADING_SELECTOR);
+        const stillLoadingElements = await find.allByCssSelector(DATA_LOADING_SELECTOR, 1000);
         if (stillLoadingElements.length > 0) {
           throw new Error(`${stillLoadingElements.length} elements still loading contents`);
         }