Sets min_doc_count=0 for parent histogram of derivative aggregation (#…

…61390) (#61896) From the docs: The specified metric must be numeric and the enclosing histogram must have min_doc_count set to 0 (default for histogram aggregations). https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-derivative-aggregation.html#search-aggregations-pipeline-derivative-aggregation This is now enforced, and currently failing the promotion of the current Elasticsearch build Related to #61387 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elastic · Mar 31, 2020 · 4af5b7c · 4af5b7c
1 parent 2ee99e3
commit 4af5b7c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/x-pack/plugins/monitoring/server/lib/elasticsearch/nodes/get_nodes/get_nodes.js b/x-pack/plugins/monitoring/server/lib/elasticsearch/nodes/get_nodes/get_nodes.js
@@ -84,7 +84,7 @@ export async function getNodes(req, esIndexPattern, pageOfNodes, clusterStats, n
             by_date: {
               date_histogram: {
                 field: 'timestamp',
-                min_doc_count: 1,
+                min_doc_count: 0,
                 fixed_interval: bucketSize + 's',
               },
               aggs: getMetricAggs(LISTING_METRICS_NAMES, bucketSize),

diff --git a/x-pack/test/api_integration/apis/monitoring/elasticsearch/nodes.js b/x-pack/test/api_integration/apis/monitoring/elasticsearch/nodes.js
@@ -34,8 +34,7 @@ export default function({ getService }) {
         return esArchiver.unload(archive);
       });
 
-      // https://github.com/elastic/kibana/issues/61366
-      it.skip('should return data for 2 active nodes', async () => {
+      it('should return data for 2 active nodes', async () => {
         const { body } = await supertest
           .post('/api/monitoring/v1/clusters/fHJwISmKTFO8bj57oFBLUQ/elasticsearch/nodes')
           .set('kbn-xsrf', 'xxx')

diff --git a/x-pack/test/functional/apps/monitoring/elasticsearch/nodes.js b/x-pack/test/functional/apps/monitoring/elasticsearch/nodes.js
@@ -34,8 +34,7 @@ export default function({ getService, getPageObjects }) {
         await tearDown();
       });
 
-      // https://github.com/elastic/kibana/issues/61366
-      it.skip('should have an Elasticsearch Cluster Summary Status with correct info', async () => {
+      it('should have an Elasticsearch Cluster Summary Status with correct info', async () => {
         expect(await esClusterSummaryStatus.getContent()).to.eql({
           nodesCount: 'Nodes\n2',
           indicesCount: 'Indices\n20',