Fixing tests and adding username to message

elastic · Apr 5, 2021 · 4b4691b · 4b4691b
1 parent 32242b2
commit 4b4691b
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 43 deletions.
diff --git a/x-pack/plugins/cases/server/authorization/audit_logger.ts b/x-pack/plugins/cases/server/authorization/audit_logger.ts
@@ -35,7 +35,7 @@ export class AuthorizationAuditLogger {
      * `Unauthorized to create case with "securitySolution" as the owner`
      * `Unauthorized to find cases of any owner`.
      */
-    return `${result} to ${operation.verbs.present} ${owner} ${operation.docType} ${ownerMsg}`;
+    return `${result} to ${operation.verbs.present} ${operation.docType} ${ownerMsg}`;
   }
 
   private logSuccessEvent({
@@ -48,7 +48,7 @@ export class AuthorizationAuditLogger {
     username?: string;
   }) {
     this.auditLogger?.log({
-      message,
+      message: `${username ?? 'unknown user'} ${message}`,
       event: {
         action: operation.action,
         category: EventCategory.DATABASE,
@@ -78,7 +78,7 @@ export class AuthorizationAuditLogger {
       operation,
     });
     this.auditLogger?.log({
-      message,
+      message: `${username ?? 'unknown user'} ${message}`,
       event: {
         action: operation.action,
         category: EventCategory.DATABASE,

diff --git a/x-pack/plugins/security/server/authorization/actions/__snapshots__/cases.test.ts.snap b/x-pack/plugins/security/server/authorization/actions/__snapshots__/cases.test.ts.snap
diff --git a/.../plugins/security/server/authorization/privileges/feature_privilege_builder/cases.test.ts b/.../plugins/security/server/authorization/privileges/feature_privilege_builder/cases.test.ts
@@ -70,8 +70,8 @@ describe(`cases`, () => {
 
         expect(casesFeaturePrivilege.getActions(privilege, feature)).toMatchInlineSnapshot(`
           Array [
-            "cases:1.0.0-zeta1:observability/get",
-            "cases:1.0.0-zeta1:observability/find",
+            "cases:1.0.0-zeta1:observability/getCase",
+            "cases:1.0.0-zeta1:observability/findCases",
           ]
         `);
       });
@@ -105,11 +105,11 @@ describe(`cases`, () => {
 
         expect(casesFeaturePrivilege.getActions(privilege, feature)).toMatchInlineSnapshot(`
           Array [
-            "cases:1.0.0-zeta1:security/get",
-            "cases:1.0.0-zeta1:security/find",
-            "cases:1.0.0-zeta1:security/create",
-            "cases:1.0.0-zeta1:security/delete",
-            "cases:1.0.0-zeta1:security/update",
+            "cases:1.0.0-zeta1:security/getCase",
+            "cases:1.0.0-zeta1:security/findCases",
+            "cases:1.0.0-zeta1:security/createCase",
+            "cases:1.0.0-zeta1:security/deleteCase",
+            "cases:1.0.0-zeta1:security/updateCase",
           ]
         `);
       });
@@ -144,13 +144,13 @@ describe(`cases`, () => {
 
         expect(casesFeaturePrivilege.getActions(privilege, feature)).toMatchInlineSnapshot(`
           Array [
-            "cases:1.0.0-zeta1:security/get",
-            "cases:1.0.0-zeta1:security/find",
-            "cases:1.0.0-zeta1:security/create",
-            "cases:1.0.0-zeta1:security/delete",
-            "cases:1.0.0-zeta1:security/update",
-            "cases:1.0.0-zeta1:obs/get",
-            "cases:1.0.0-zeta1:obs/find",
+            "cases:1.0.0-zeta1:security/getCase",
+            "cases:1.0.0-zeta1:security/findCases",
+            "cases:1.0.0-zeta1:security/createCase",
+            "cases:1.0.0-zeta1:security/deleteCase",
+            "cases:1.0.0-zeta1:security/updateCase",
+            "cases:1.0.0-zeta1:obs/getCase",
+            "cases:1.0.0-zeta1:obs/findCases",
           ]
         `);
       });
@@ -185,20 +185,20 @@ describe(`cases`, () => {
 
         expect(casesFeaturePrivilege.getActions(privilege, feature)).toMatchInlineSnapshot(`
           Array [
-            "cases:1.0.0-zeta1:security/get",
-            "cases:1.0.0-zeta1:security/find",
-            "cases:1.0.0-zeta1:security/create",
-            "cases:1.0.0-zeta1:security/delete",
-            "cases:1.0.0-zeta1:security/update",
-            "cases:1.0.0-zeta1:other-security/get",
-            "cases:1.0.0-zeta1:other-security/find",
-            "cases:1.0.0-zeta1:other-security/create",
-            "cases:1.0.0-zeta1:other-security/delete",
-            "cases:1.0.0-zeta1:other-security/update",
-            "cases:1.0.0-zeta1:obs/get",
-            "cases:1.0.0-zeta1:obs/find",
-            "cases:1.0.0-zeta1:other-obs/get",
-            "cases:1.0.0-zeta1:other-obs/find",
+            "cases:1.0.0-zeta1:security/getCase",
+            "cases:1.0.0-zeta1:security/findCases",
+            "cases:1.0.0-zeta1:security/createCase",
+            "cases:1.0.0-zeta1:security/deleteCase",
+            "cases:1.0.0-zeta1:security/updateCase",
+            "cases:1.0.0-zeta1:other-security/getCase",
+            "cases:1.0.0-zeta1:other-security/findCases",
+            "cases:1.0.0-zeta1:other-security/createCase",
+            "cases:1.0.0-zeta1:other-security/deleteCase",
+            "cases:1.0.0-zeta1:other-security/updateCase",
+            "cases:1.0.0-zeta1:obs/getCase",
+            "cases:1.0.0-zeta1:obs/findCases",
+            "cases:1.0.0-zeta1:other-obs/getCase",
+            "cases:1.0.0-zeta1:other-obs/findCases",
           ]
         `);
       });