Merge remote-tracking branch 'upstream/master' into ml-move-index-dat…

…a-visualizer

.github/CODEOWNERS

@@ -24,6 +24,7 @@
 /src/plugins/vis_type_vega/ @elastic/kibana-app
 /src/plugins/vis_type_vislib/ @elastic/kibana-app
 /src/plugins/vis_type_xy/ @elastic/kibana-app
+/src/plugins/vis_type_pie/ @elastic/kibana-app
 /src/plugins/visualize/ @elastic/kibana-app
 /src/plugins/visualizations/ @elastic/kibana-app
 /packages/kbn-tinymath/ @elastic/kibana-app
@@ -54,6 +55,7 @@
 /src/plugins/share/ @elastic/kibana-app-services
 /src/plugins/ui_actions/ @elastic/kibana-app-services
 /src/plugins/index_pattern_field_editor @elastic/kibana-app-services
+/src/plugins/screenshot_mode @elastic/kibana-app-services
 /x-pack/examples/ui_actions_enhanced_examples/ @elastic/kibana-app-services
 /x-pack/plugins/data_enhanced/ @elastic/kibana-app-services
 /x-pack/plugins/embeddable_enhanced/ @elastic/kibana-app-services

.github/PULL_REQUEST_TEMPLATE.md

@@ -21,18 +21,16 @@ Delete any items that are not applicable to this PR.
 
 Delete this section if it is not applicable to this PR.
 
-Before closing this PR, invite QA, stakeholders, and other developers to
-identify risks that should be tested prior to the change/feature release.
+Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
 
-When forming the risk matrix, consider some of the following examples and how
-they may potentially impact the change:
+When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
 
 | Risk                      | Probability | Severity | Mitigation/Notes        |
 |---------------------------|-------------|----------|-------------------------|
 | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. |
 | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. |
 | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. |
-| [See more potential risk examples](../RISK_MATRIX.mdx) |
+| [See more potential risk examples](https://github.com/elastic/kibana/blob/master/RISK_MATRIX.mdx) |
 
 
 ### For maintainers

.i18nrc.json

@@ -56,6 +56,7 @@
     "visTypeVega": "src/plugins/vis_type_vega",
     "visTypeVislib": "src/plugins/vis_type_vislib",
     "visTypeXy": "src/plugins/vis_type_xy",
+    "visTypePie": "src/plugins/vis_type_pie",
     "visualizations": "src/plugins/visualizations",
     "visualize": "src/plugins/visualize",
     "apmOss": "src/plugins/apm_oss",

docs/developer/getting-started/index.asciidoc

@@ -14,9 +14,14 @@ In order to support Windows development we currently require you to use one of t
 
 As well as installing https://www.microsoft.com/en-us/download/details.aspx?id=48145[Visual C++ Redistributable for Visual Studio 2015].
 
+In addition we also require you to do the following:
+
+- Install https://www.microsoft.com/en-us/download/details.aspx?id=48145[Visual C++ Redistributable for Visual Studio 2015]
+- Enable the https://docs.microsoft.com/en-us/windows/apps/get-started/enable-your-device-for-development[Windows Developer Mode]
+- Enable https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/fsutil-8dot3name[8.3 filename support] by running the following command in a windows command prompt with admin rights `fsutil 8dot3name set 0`
+
 Before running the steps listed below, please make sure you have installed everything 
-that we require and listed above and that you are running the mentioned commands 
-through Git bash or WSL.
+that we require and listed above and that you are running all the commands from now on through Git bash or WSL.
 
 [discrete]
 [[get-kibana-code]]

docs/developer/plugin-list.asciidoc

@@ -265,6 +265,10 @@ The plugin exposes the static DefaultEditorController class to consume.
 |Contains the metric visualization.
 
 
+|{kib-repo}blob/{branch}/src/plugins/vis_type_pie/README.md[visTypePie]
+|Contains the pie chart implementation using the elastic-charts library. The goal is to eventually deprecate the old implementation and keep only this. Until then, the library used is defined by the Legacy charts library advanced setting.
+
+
 |{kib-repo}blob/{branch}/src/plugins/vis_type_table/README.md[visTypeTable]
 |Contains the data table visualization, that allows presenting data in a simple table format.
 

docs/settings/fleet-settings.asciidoc

@@ -39,8 +39,8 @@ See the {fleet-guide}/index.html[{fleet}] docs for more information.
 |===
 | `xpack.fleet.agents.fleet_server.hosts`
   | Hostnames used by {agent} for accessing {fleet-server}.
-| `xpack.fleet.agents.elasticsearch.host`
-  | The hostname used by {agent} for accessing {es}.
+| `xpack.fleet.agents.elasticsearch.hosts`
+  | Hostnames used by {agent} for accessing {es}.
 |===
 
 [NOTE]

docs/setup/install/brew.asciidoc

@@ -14,15 +14,13 @@ brew tap elastic/tap
 -------------------------
 
 Once you've tapped the Elastic Homebrew repo, you can use `brew install` to
-install the default distribution of {kib}:
+install the **latest version** of {kib}:
 
 [source,sh]
 -------------------------
 brew install elastic/tap/kibana-full
 -------------------------
 
-This installs the most recently released distribution of {kib}.
-
 [[brew-layout]]
 ==== Directory layout for Homebrew installs
 

package.json

@@ -100,7 +100,7 @@
     "@elastic/apm-rum": "^5.6.1",
     "@elastic/apm-rum-react": "^1.2.5",
     "@elastic/charts": "29.2.0",
-    "@elastic/datemath": "link:bazel-bin/packages/elastic-datemath/npm_module",
+    "@elastic/datemath": "link:bazel-bin/packages/elastic-datemath",
     "@elastic/elasticsearch": "npm:@elastic/elasticsearch-canary@^8.0.0-canary.4",
     "@elastic/ems-client": "7.13.0",
     "@elastic/eui": "33.0.0",
@@ -111,7 +111,7 @@
     "@elastic/numeral": "^2.5.1",
     "@elastic/react-search-ui": "^1.5.1",
     "@elastic/request-crypto": "1.1.4",
-    "@elastic/safer-lodash-set": "link:bazel-bin/packages/elastic-safer-lodash-set/npm_module",
+    "@elastic/safer-lodash-set": "link:bazel-bin/packages/elastic-safer-lodash-set",
     "@elastic/search-ui-app-search-connector": "^1.5.0",
     "@elastic/ui-ace": "0.2.3",
     "@hapi/accept": "^5.0.2",
@@ -124,39 +124,39 @@
     "@hapi/inert": "^6.0.3",
     "@hapi/podium": "^4.1.1",
     "@hapi/wreck": "^17.1.0",
-    "@kbn/ace": "link:bazel-bin/packages/kbn-ace/npm_module",
-    "@kbn/analytics": "link:bazel-bin/packages/kbn-analytics/npm_module",
-    "@kbn/apm-config-loader": "link:bazel-bin/packages/kbn-apm-config-loader/npm_module",
-    "@kbn/apm-utils": "link:bazel-bin/packages/kbn-apm-utils/npm_module",
-    "@kbn/config": "link:bazel-bin/packages/kbn-config/npm_module",
-    "@kbn/config-schema": "link:bazel-bin/packages/kbn-config-schema/npm_module",
-    "@kbn/crypto": "link:bazel-bin/packages/kbn-crypto/npm_module",
-    "@kbn/i18n": "link:bazel-bin/packages/kbn-i18n/npm_module",
+    "@kbn/ace": "link:bazel-bin/packages/kbn-ace",
+    "@kbn/analytics": "link:bazel-bin/packages/kbn-analytics",
+    "@kbn/apm-config-loader": "link:bazel-bin/packages/kbn-apm-config-loader",
+    "@kbn/apm-utils": "link:bazel-bin/packages/kbn-apm-utils",
+    "@kbn/config": "link:bazel-bin/packages/kbn-config",
+    "@kbn/config-schema": "link:bazel-bin/packages/kbn-config-schema",
+    "@kbn/crypto": "link:bazel-bin/packages/kbn-crypto",
+    "@kbn/mapbox-gl": "link:bazel-bin/packages/kbn-mapbox-gl",
+    "@kbn/i18n": "link:bazel-bin/packages/kbn-i18n",
     "@kbn/interpreter": "link:packages/kbn-interpreter",
-    "@kbn/io-ts-utils": "link:bazel-bin/packages/kbn-io-ts-utils/npm_module",
-    "@kbn/legacy-logging": "link:bazel-bin/packages/kbn-legacy-logging/npm_module",
-    "@kbn/logging": "link:bazel-bin/packages/kbn-logging/npm_module",
-    "@kbn/mapbox-gl": "link:bazel-bin/packages/kbn-mapbox-gl/npm_module",
-    "@kbn/monaco": "link:bazel-bin/packages/kbn-monaco/npm_module",
+    "@kbn/io-ts-utils": "link:bazel-bin/packages/kbn-io-ts-utils",
+    "@kbn/legacy-logging": "link:bazel-bin/packages/kbn-legacy-logging",
+    "@kbn/logging": "link:bazel-bin/packages/kbn-logging",
+    "@kbn/monaco": "link:bazel-bin/packages/kbn-monaco",
     "@kbn/rule-data-utils": "link:packages/kbn-rule-data-utils",
-    "@kbn/securitysolution-es-utils": "link:bazel-bin/packages/kbn-securitysolution-es-utils/npm_module",
-    "@kbn/securitysolution-io-ts-alerting-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-alerting-types/npm_module",
-    "@kbn/securitysolution-io-ts-list-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-list-types/npm_module",
-    "@kbn/securitysolution-io-ts-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-types/npm_module",
-    "@kbn/securitysolution-io-ts-utils": "link:bazel-bin/packages/kbn-securitysolution-io-ts-utils/npm_module",
-    "@kbn/securitysolution-list-api": "link:bazel-bin/packages/kbn-securitysolution-list-api/npm_module",
-    "@kbn/securitysolution-list-constants": "link:bazel-bin/packages/kbn-securitysolution-list-constants/npm_module",
-    "@kbn/securitysolution-list-hooks": "link:bazel-bin/packages/kbn-securitysolution-list-hooks/npm_module",
-    "@kbn/securitysolution-list-utils": "link:bazel-bin/packages/kbn-securitysolution-list-utils/npm_module",
-    "@kbn/securitysolution-utils": "link:bazel-bin/packages/kbn-securitysolution-utils/npm_module",
-    "@kbn/server-http-tools": "link:bazel-bin/packages/kbn-server-http-tools/npm_module",
+    "@kbn/securitysolution-list-constants": "link:bazel-bin/packages/kbn-securitysolution-list-constants",
+    "@kbn/securitysolution-es-utils": "link:bazel-bin/packages/kbn-securitysolution-es-utils",
+    "@kbn/securitysolution-io-ts-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-types",
+    "@kbn/securitysolution-io-ts-alerting-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-alerting-types",
+    "@kbn/securitysolution-io-ts-list-types": "link:bazel-bin/packages/kbn-securitysolution-io-ts-list-types",
+    "@kbn/securitysolution-io-ts-utils": "link:bazel-bin/packages/kbn-securitysolution-io-ts-utils",
+    "@kbn/securitysolution-list-api": "link:bazel-bin/packages/kbn-securitysolution-list-api",
+    "@kbn/securitysolution-list-hooks": "link:bazel-bin/packages/kbn-securitysolution-list-hooks",
+    "@kbn/securitysolution-list-utils": "link:bazel-bin/packages/kbn-securitysolution-list-utils",
+    "@kbn/securitysolution-utils": "link:bazel-bin/packages/kbn-securitysolution-utils",
+    "@kbn/server-http-tools": "link:bazel-bin/packages/kbn-server-http-tools",
     "@kbn/server-route-repository": "link:packages/kbn-server-route-repository",
-    "@kbn/std": "link:bazel-bin/packages/kbn-std/npm_module",
-    "@kbn/tinymath": "link:bazel-bin/packages/kbn-tinymath/npm_module",
+    "@kbn/std": "link:bazel-bin/packages/kbn-std",
+    "@kbn/tinymath": "link:bazel-bin/packages/kbn-tinymath",
     "@kbn/ui-framework": "link:packages/kbn-ui-framework",
     "@kbn/ui-shared-deps": "link:packages/kbn-ui-shared-deps",
-    "@kbn/utility-types": "link:bazel-bin/packages/kbn-utility-types/npm_module",
-    "@kbn/utils": "link:bazel-bin/packages/kbn-utils/npm_module",
+    "@kbn/utility-types": "link:bazel-bin/packages/kbn-utility-types",
+    "@kbn/utils": "link:bazel-bin/packages/kbn-utils",
     "@loaders.gl/core": "^2.3.1",
     "@loaders.gl/json": "^2.3.1",
     "@mapbox/geojson-rewind": "^0.5.0",
@@ -241,7 +241,6 @@
     "get-port": "^5.0.0",
     "getopts": "^2.2.5",
     "getos": "^3.1.0",
-    "git-url-parse": "11.1.2",
     "github-markdown-css": "^2.10.0",
     "glob": "^7.1.2",
     "glob-all": "^3.2.1",
@@ -294,7 +293,7 @@
     "memoize-one": "^5.0.0",
     "mime": "^2.4.4",
     "mime-types": "^2.1.27",
-    "mini-css-extract-plugin": "0.8.0",
+    "mini-css-extract-plugin": "1.1.0",
     "minimatch": "^3.0.4",
     "moment": "^2.24.0",
     "moment-duration-format": "^2.3.2",
@@ -447,28 +446,28 @@
     "@cypress/webpack-preprocessor": "^5.6.0",
     "@elastic/apm-rum": "^5.6.1",
     "@elastic/apm-rum-react": "^1.2.5",
-    "@elastic/eslint-config-kibana": "link:bazel-bin/packages/elastic-eslint-config-kibana/npm_module",
+    "@elastic/eslint-config-kibana": "link:bazel-bin/packages/elastic-eslint-config-kibana",
     "@elastic/eslint-plugin-eui": "0.0.2",
     "@elastic/github-checks-reporter": "0.0.20b3",
     "@elastic/makelogs": "^6.0.0",
     "@istanbuljs/schema": "^0.1.2",
     "@jest/reporters": "^26.6.2",
-    "@kbn/babel-code-parser": "link:bazel-bin/packages/kbn-babel-code-parser/npm_module",
-    "@kbn/babel-preset": "link:bazel-bin/packages/kbn-babel-preset/npm_module",
+    "@kbn/babel-code-parser": "link:bazel-bin/packages/kbn-babel-code-parser",
+    "@kbn/babel-preset": "link:bazel-bin/packages/kbn-babel-preset",
     "@kbn/cli-dev-mode": "link:packages/kbn-cli-dev-mode",
-    "@kbn/dev-utils": "link:bazel-bin/packages/kbn-dev-utils/npm_module",
-    "@kbn/docs-utils": "link:bazel-bin/packages/kbn-docs-utils/npm_module",
-    "@kbn/es": "link:bazel-bin/packages/kbn-es/npm_module",
+    "@kbn/dev-utils": "link:bazel-bin/packages/kbn-dev-utils",
+    "@kbn/docs-utils": "link:bazel-bin/packages/kbn-docs-utils",
+    "@kbn/es": "link:bazel-bin/packages/kbn-es",
     "@kbn/es-archiver": "link:packages/kbn-es-archiver",
-    "@kbn/eslint-import-resolver-kibana": "link:bazel-bin/packages/kbn-eslint-import-resolver-kibana/npm_module",
-    "@kbn/eslint-plugin-eslint": "link:bazel-bin/packages/kbn-eslint-plugin-eslint/npm_module",
-    "@kbn/expect": "link:bazel-bin/packages/kbn-expect/npm_module",
+    "@kbn/eslint-import-resolver-kibana": "link:bazel-bin/packages/kbn-eslint-import-resolver-kibana",
+    "@kbn/eslint-plugin-eslint": "link:bazel-bin/packages/kbn-eslint-plugin-eslint",
+    "@kbn/expect": "link:bazel-bin/packages/kbn-expect",
     "@kbn/optimizer": "link:packages/kbn-optimizer",
-    "@kbn/plugin-generator": "link:bazel-bin/packages/kbn-plugin-generator/npm_module",
+    "@kbn/plugin-generator": "link:bazel-bin/packages/kbn-plugin-generator",
     "@kbn/plugin-helpers": "link:packages/kbn-plugin-helpers",
     "@kbn/pm": "link:packages/kbn-pm",
     "@kbn/storybook": "link:packages/kbn-storybook",
-    "@kbn/telemetry-tools": "link:bazel-bin/packages/kbn-telemetry-tools/npm_module",
+    "@kbn/telemetry-tools": "link:bazel-bin/packages/kbn-telemetry-tools",
     "@kbn/test": "link:packages/kbn-test",
     "@kbn/test-subj-selector": "link:packages/kbn-test-subj-selector",
     "@loaders.gl/polyfills": "^2.3.5",
@@ -533,7 +532,6 @@
     "@types/geojson": "7946.0.7",
     "@types/getopts": "^2.0.1",
     "@types/getos": "^3.0.0",
-    "@types/git-url-parse": "^9.0.0",
     "@types/glob": "^7.1.2",
     "@types/gulp": "^4.0.6",
     "@types/gulp-zip": "^4.0.1",

packages/kbn-babel-code-parser/BUILD.bazel

@@ -34,10 +34,10 @@ DEPS = [
 
 babel(
   name = "target",
-  data = [
+  data = DEPS + [
       ":srcs",
       ".babelrc",
-  ] + DEPS,
+  ],
   output_dir = True,
   # the following arg paths includes $(execpath) as babel runs on the sandbox root
   args = [

packages/kbn-es/BUILD.bazel

@@ -47,10 +47,10 @@ DEPS = [
 
 babel(
   name = "target",
-  data = [
+  data = DEPS + [
       ":srcs",
       ".babelrc",
-  ] + DEPS,
+  ],
   output_dir = True,
   # the following arg paths includes $(execpath) as babel runs on the sandbox root
   args = [

packages/kbn-expect/BUILD.bazel

@@ -5,7 +5,7 @@ PKG_REQUIRE_NAME = "@kbn/expect"
 
 SOURCE_FILES = glob([
   "expect.js",
-  "expect.js.d.ts",
+  "expect.d.ts",
 ])
 
 SRCS = SOURCE_FILES

packages/kbn-expect/package.json

@@ -1,6 +1,7 @@
 {
   "name": "@kbn/expect",
   "main": "./expect.js",
+  "typings": "./expect.d.ts",
   "version": "1.0.0",
   "license": "MIT",
   "private": true,

packages/kbn-expect/tsconfig.json

@@ -4,6 +4,6 @@
     "incremental": false,
   },
   "include": [
-    "expect.js.d.ts"
+    "expect.d.ts"
   ]
 }

packages/kbn-monaco/BUILD.bazel

@@ -48,7 +48,7 @@ webpack(
   name = "target_web",
   data = DEPS + [
     ":src",
-    ":webpack.config.js",
+    "webpack.config.js",
   ],
   output_dir = True,
   args = [
@@ -87,7 +87,7 @@ ts_project(
 js_library(
   name = PKG_BASE_NAME,
   srcs = NPM_MODULE_EXTRA_FILES,
-  deps = DEPS + [":target_web", ":tsc"],
+  deps = DEPS + [":tsc", ":target_web"],
   package_name = PKG_REQUIRE_NAME,
   visibility = ["//visibility:public"],
 )

packages/kbn-monaco/webpack.config.js

@@ -22,7 +22,6 @@ const createLangWorkerConfig = (lang) => {
       filename: `${lang}.editor.worker.js`,
     },
     resolve: {
-      modules: ['node_modules'],
       extensions: ['.js', '.ts', '.tsx'],
     },
     stats: 'errors-only',

packages/kbn-optimizer/limits.yml

@@ -87,6 +87,7 @@ pageLoadAssetSize:
   visDefaultEditor: 50178
   visTypeMarkdown: 30896
   visTypeMetric: 42790
+  visTypePie: 34051
   visTypeTable: 94934
   visTypeTagcloud: 37575
   visTypeTimelion: 68883

packages/kbn-pm/dist/index.js

@@ -23045,7 +23045,7 @@ class Project {
 
   ensureValidProjectDependency(project) {
     const relativePathToProject = normalizePath(path__WEBPACK_IMPORTED_MODULE_1___default.a.relative(this.path, project.path));
-    const relativePathToProjectIfBazelPkg = normalizePath(path__WEBPACK_IMPORTED_MODULE_1___default.a.relative(this.path, `${__dirname}/../../../bazel-bin/packages/${path__WEBPACK_IMPORTED_MODULE_1___default.a.basename(project.path)}/npm_module`));
+    const relativePathToProjectIfBazelPkg = normalizePath(path__WEBPACK_IMPORTED_MODULE_1___default.a.relative(this.path, `${__dirname}/../../../bazel-bin/packages/${path__WEBPACK_IMPORTED_MODULE_1___default.a.basename(project.path)}`));
     const versionInPackageJson = this.allDependencies[project.name];
     const expectedVersionInPackageJson = `link:${relativePathToProject}`;
     const expectedVersionInPackageJsonIfBazelPkg = `link:${relativePathToProjectIfBazelPkg}`; // TODO: after introduce bazel to build all the packages and completely remove the support for kbn packages
@@ -23234,7 +23234,7 @@ function transformDependencies(dependencies = {}) {
     }
 
     if (isBazelPackageDependency(depVersion)) {
-      newDeps[name] = depVersion.replace('link:bazel-bin/', 'file:').replace('/npm_module', '');
+      newDeps[name] = depVersion.replace('link:bazel-bin/', 'file:');
       continue;
     }
 

packages/kbn-pm/src/utils/package_json.ts

@@ -61,7 +61,7 @@ export function transformDependencies(dependencies: IPackageDependencies = {}) {
     }
 
     if (isBazelPackageDependency(depVersion)) {
-      newDeps[name] = depVersion.replace('link:bazel-bin/', 'file:').replace('/npm_module', '');
+      newDeps[name] = depVersion.replace('link:bazel-bin/', 'file:');
       continue;
     }
 

packages/kbn-pm/src/utils/project.ts

@@ -94,7 +94,7 @@ export class Project {
     const relativePathToProjectIfBazelPkg = normalizePath(
       Path.relative(
         this.path,
-        `${__dirname}/../../../bazel-bin/packages/${Path.basename(project.path)}/npm_module`
+        `${__dirname}/../../../bazel-bin/packages/${Path.basename(project.path)}`
       )
     );
 

packages/kbn-securitysolution-io-ts-list-types/BUILD.bazel

@@ -27,9 +27,10 @@ NPM_MODULE_EXTRA_FILES = [
 ]
 
 SRC_DEPS = [
+  "//packages/elastic-datemath",
   "//packages/kbn-securitysolution-io-ts-types",
   "//packages/kbn-securitysolution-io-ts-utils",
-  "//packages/elastic-datemath",
+  "//packages/kbn-securitysolution-list-constants",
   "@npm//fp-ts",
   "@npm//io-ts",
   "@npm//lodash",

packages/kbn-ui-shared-deps/entry.js

@@ -44,7 +44,8 @@ export const Theme = require('./theme.ts');
 export const Lodash = require('lodash');
 export const LodashFp = require('lodash/fp');
 
-export const Fflate = require('fflate/esm/browser');
+import { unzlibSync, strFromU8 } from 'fflate';
+export const Fflate = { unzlibSync, strFromU8 };
 
 // runtime deps which don't need to be copied across all bundles
 export const TsLib = require('tslib');