Removed file related unnecessary exports.

elastic · May 11, 2023 · 53135ec · 53135ec
1 parent 6a0ff8c
commit 53135ec
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 12 deletions.
diff --git a/x-pack/plugins/cases/common/api/helpers.ts b/x-pack/plugins/cases/common/api/helpers.ts
@@ -10,7 +10,6 @@ import {
   CASE_METRICS_DETAILS_URL,
   CASE_COMMENTS_URL,
   CASE_USER_ACTIONS_URL,
-  CASE_COMMENT_DETAILS_URL,
   CASE_PUSH_URL,
   CASE_CONFIGURE_DETAILS_URL,
   CASE_ALERTS_URL,
@@ -36,10 +35,6 @@ export const getCaseCommentsUrl = (id: string): string => {
   return CASE_COMMENTS_URL.replace('{case_id}', id);
 };
 
-export const getCaseCommentDetailsUrl = (caseId: string, commentId: string): string => {
-  return CASE_COMMENT_DETAILS_URL.replace('{case_id}', caseId).replace('{comment_id}', commentId);
-};
-
 export const getCaseFindAttachmentsUrl = (caseId: string): string => {
   return CASE_FIND_ATTACHMENTS_URL.replace('{case_id}', caseId);
 };

diff --git a/x-pack/plugins/cases/common/constants/mime_types.ts b/x-pack/plugins/cases/common/constants/mime_types.ts
@@ -8,7 +8,7 @@
 /**
  * These were retrieved from https://www.iana.org/assignments/media-types/media-types.xhtml#image
  */
-export const imageMimeTypes = [
+const imageMimeTypes = [
   'image/aces',
   'image/apng',
   'image/avci',

diff --git a/x-pack/plugins/cases/public/components/files/utils.test.tsx b/x-pack/plugins/cases/public/components/files/utils.test.tsx
@@ -8,13 +8,15 @@ import type { JsonValue } from '@kbn/utility-types';
 
 import {
   compressionMimeTypes,
-  imageMimeTypes,
+  IMAGE_MIME_TYPES,
   pdfMimeTypes,
   textMimeTypes,
 } from '../../../common/constants/mime_types';
 import { basicFileMock } from '../../containers/mock';
 import { isImage, isValidFileExternalReferenceMetadata, parseMimeType } from './utils';
 
+const imageMimeTypes = Array.from(IMAGE_MIME_TYPES);
+
 describe('isImage', () => {
   it.each(imageMimeTypes)('should return true for image mime type: %s', (mimeType) => {
     expect(isImage({ mimeType })).toBeTruthy();

diff --git a/x-pack/plugins/cases/public/components/files/utils.tsx b/x-pack/plugins/cases/public/components/files/utils.tsx
@@ -12,7 +12,7 @@ import type {
 
 import {
   compressionMimeTypes,
-  imageMimeTypes,
+  IMAGE_MIME_TYPES,
   textMimeTypes,
   pdfMimeTypes,
 } from '../../../common/constants/mime_types';
@@ -26,7 +26,7 @@ export const parseMimeType = (mimeType: string | undefined) => {
     return i18n.UNKNOWN_MIME_TYPE;
   }
 
-  if (imageMimeTypes.includes(mimeType)) {
+  if (IMAGE_MIME_TYPES.has(mimeType)) {
     return i18n.IMAGE_MIME_TYPE;
   }
 

diff --git a/x-pack/plugins/cases/public/containers/use_delete_file_attachment.tsx b/x-pack/plugins/cases/public/containers/use_delete_file_attachment.tsx
@@ -39,5 +39,3 @@ export const useDeleteFileAttachment = () => {
     }
   );
 };
-
-export type UseDeleteFileAttachment = ReturnType<typeof useDeleteFileAttachment>;
diff --git a/x-pack/plugins/cases/public/containers/use_get_case_file_stats.tsx b/x-pack/plugins/cases/public/containers/use_get_case_file_stats.tsx
@@ -25,7 +25,7 @@ const getTotalFromFileList = (data: { files: FileJSON[]; total: number }): { tot
   total: data.total,
 });
 
-export interface GetCaseFileStatsParams {
+interface GetCaseFileStatsParams {
   caseId: string;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -39,5 +39,3 @@ export const useDeleteFileAttachment = () => { @@
         }
       );
     };
-    export type UseDeleteFileAttachment = ReturnType<typeof useDeleteFileAttachment>;