apply review feedback

elastic · Aug 14, 2020 · 59a2640 · 59a2640
1 parent 0041e0c
commit 59a2640
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/.ci/Jenkinsfile_security_cypress b/.ci/Jenkinsfile_security_cypress
@@ -4,14 +4,18 @@ library 'kibana-pipeline-library'
 kibanaLibrary.load()
 
 kibanaPipeline(timeoutMinutes: 180) {
-  catchError {
-    workers.base(size: 's', ramDisk: false) {
-      kibanaPipeline.bash('test/scripts/jenkins_security_solution_cypress.sh', 'Execute Security Solution Cypress Tests')
+  slackNotifications.onFailure(
+    disabled: !params.NOTIFY_ON_FAILURE,
+    channel: '#security-solution-slack-testing'
+  ) {
+    catchError {
+      workers.base(size: 's', ramDisk: false) {
+        kibanaPipeline.bash('test/scripts/jenkins_security_solution_cypress.sh', 'Execute Security Solution Cypress Tests')
+      }
     }
   }
 
   if (params.NOTIFY_ON_FAILURE) {
-    slackNotifications.onFailure(channel: '#security-solution-slack-testing')
     kibanaPipeline.sendMail(to: 'gloria.delatorre@elastic.co')
   }
 }