Fix more Spaces API integration tests

elastic · Oct 13, 2021 · 5e0b244 · 5e0b244
1 parent 97f949f
commit 5e0b244
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 33 deletions.
diff --git a/x-pack/test/spaces_api_integration/common/suites/resolve_copy_to_space_conflicts.ts b/x-pack/test/spaces_api_integration/common/suites/resolve_copy_to_space_conflicts.ts
@@ -250,35 +250,7 @@ export function resolveCopyToSpaceConflictsSuite(
  {
  statusCode: 403,
  error: 'Forbidden',
- message: 'Unable to bulk_get index-pattern',
- },
- ],
- },
- } as CopyResponse);
-
- // Query ES to ensure that nothing was copied
- const [dashboard, visualization] = await getObjectsAtSpace(destination);
- expect(dashboard.attributes.title).to.eql(
- `This is the ${destination} test space CTS dashboard`
- );
- expect(visualization.attributes.title).to.eql(`CTS vis 3 from ${destination} space`);
- };
-
- const createExpectReadonlyAtSpaceWithReferencesResult =
- (spaceId: string = DEFAULT_SPACE_ID) =>
- async (resp: TestResponse) => {
- const destination = getDestinationSpace(spaceId);
-
- const result = resp.body as CopyResponse;
- expect(result).to.eql({
- [destination]: {
- success: false,
- successCount: 0,
- errors: [
- {
- statusCode: 403,
- error: 'Forbidden',
- message: 'Unable to bulk_create visualization',
+ message: 'Unable to bulk_create index-pattern,visualization',
  },
  ],
  },
@@ -611,7 +583,6 @@ export function resolveCopyToSpaceConflictsSuite(
  createExpectNonOverriddenResponseWithReferences,
  createExpectNonOverriddenResponseWithoutReferences,
  createExpectUnauthorizedAtSpaceWithReferencesResult,
- createExpectReadonlyAtSpaceWithReferencesResult,
  createExpectUnauthorizedAtSpaceWithoutReferencesResult,
  createMultiNamespaceTestCases,
  originSpaces: ['default', 'space_1'],

diff --git a/...k/test/spaces_api_integration/security_and_spaces/apis/resolve_copy_to_space_conflicts.ts b/...k/test/spaces_api_integration/security_and_spaces/apis/resolve_copy_to_space_conflicts.ts
@@ -24,7 +24,6 @@ export default function resolveCopyToSpaceConflictsTestSuite({ getService }: Ftr
  createExpectOverriddenResponseWithoutReferences,
  expectRouteForbiddenResponse,
  createExpectUnauthorizedAtSpaceWithReferencesResult,
- createExpectReadonlyAtSpaceWithReferencesResult,
  createExpectUnauthorizedAtSpaceWithoutReferencesResult,
  createMultiNamespaceTestCases,
  NON_EXISTENT_SPACE_ID,
@@ -122,11 +121,11 @@ export default function resolveCopyToSpaceConflictsTestSuite({ getService }: Ftr
  tests: {
  withReferencesNotOverwriting: {
  statusCode: 200,
- response: createExpectReadonlyAtSpaceWithReferencesResult(spaceId),
+ response: createExpectUnauthorizedAtSpaceWithReferencesResult(spaceId),
  },
  withReferencesOverwriting: {
  statusCode: 200,
- response: createExpectReadonlyAtSpaceWithReferencesResult(spaceId),
+ response: createExpectUnauthorizedAtSpaceWithReferencesResult(spaceId),
  },
  withoutReferencesOverwriting: {
  statusCode: 200,