remove legacy kibana plugin (#76064) (#76605)

* remove legacy kibana plugin

* as ES as a dependency to security instead of kibana

* remove 'kibana' plugin presence check in so mixin

* moved the `kibana` config section to the server

src/legacy/server/config/schema.js

@@ -232,6 +232,15 @@ export default () =>
  locale: Joi.string().default('en'),
  }).default(),
 
+ // temporarily moved here from the (now deleted) kibana legacy plugin
+ kibana: Joi.object({
+ enabled: Joi.boolean().default(true),
+ index: Joi.string().default('.kibana'),
+ autocompleteTerminateAfter: Joi.number().integer().min(1).default(100000),
+ // TODO Also allow units here like in elasticsearch config once this is moved to the new platform
+ autocompleteTimeout: Joi.number().integer().min(1).default(1000),
+ }).default(),
+
  savedObjects: Joi.object({
  maxImportPayloadBytes: Joi.number().default(10485760),
  maxImportExportSize: Joi.number().default(10000),

src/legacy/server/saved_objects/saved_objects_mixin.js

@@ -39,14 +39,6 @@ export function savedObjectsMixin(kbnServer, server) {
 
  server.decorate('server', 'kibanaMigrator', migrator);
 
- const warn = (message) => server.log(['warning', 'saved-objects'], message);
- // we use kibana.index which is technically defined in the kibana plugin, so if
- // we don't have the plugin (mainly tests) we can't initialize the saved objects
- if (!kbnServer.pluginSpecs.some((p) => p.getId() === 'kibana')) {
- warn('Saved Objects uninitialized because the Kibana plugin is disabled.');
- return;
- }
-
  const serializer = kbnServer.newPlatform.start.core.savedObjects.createSerializer();
 
  const createRepository = (callCluster, includedHiddenTypes = []) => {

src/legacy/server/saved_objects/saved_objects_mixin.test.js

@@ -161,21 +161,6 @@ describe('Saved Objects Mixin', () => {
  };
  });
 
- describe('no kibana plugin', () => {
- it('should not try to create anything', () => {
- mockKbnServer.pluginSpecs.some = () => false;
- savedObjectsMixin(mockKbnServer, mockServer);
- expect(mockServer.log).toHaveBeenCalledWith(expect.any(Array), expect.any(String));
- expect(mockServer.decorate).toHaveBeenCalledWith(
- 'server',
- 'kibanaMigrator',
- expect.any(Object)
- );
- expect(mockServer.decorate).toHaveBeenCalledTimes(1);
- expect(mockServer.route).not.toHaveBeenCalled();
- });
- });
-
  describe('Saved object service', () => {
  let service;
 

x-pack/legacy/plugins/security/index.ts

@@ -11,7 +11,7 @@ export const security = (kibana: Record<string, any>) =>
  new kibana.Plugin({
  id: 'security',
  publicDir: resolve(__dirname, 'public'),
- require: ['kibana'],
+ require: ['elasticsearch'],
  configPrefix: 'xpack.security',
  config: (Joi: Root) =>
  Joi.object({ enabled: Joi.boolean().default(true) })

x-pack/legacy/plugins/spaces/index.ts

@@ -16,7 +16,7 @@ export const spaces = (kibana: Record<string, any>) =>
  id: 'spaces',
  configPrefix: 'xpack.spaces',
  publicDir: resolve(__dirname, 'public'),
- require: ['kibana', 'elasticsearch', 'xpack_main'],
+ require: ['elasticsearch', 'xpack_main'],
  config(Joi: any) {
  return Joi.object({
  enabled: Joi.boolean().default(true),