label updates

elastic · Nov 12, 2019 · 5eb2009 · 5eb2009
1 parent f39274d
commit 5eb2009
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 7 deletions.
diff --git a/x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/axis_config/simple_template.tsx b/x-pack/legacy/plugins/canvas/canvas_plugin_src/uis/arguments/axis_config/simple_template.tsx
@@ -20,7 +20,7 @@ export const SimpleTemplate: FunctionComponent<Props> = ({ onValueChange, argVal
       checked={Boolean(argValue)}
       onChange={() => onValueChange(!Boolean(argValue))}
       showLabel={false}
-      label="" // TODO: Add label for a11y
+      label=""
     />
   );
 };

diff --git a/...ls_step/components/advanced_section/components/dedicated_index/dedicated_index_switch.tsx b/...ls_step/components/advanced_section/components/dedicated_index/dedicated_index_switch.tsx
@@ -5,6 +5,7 @@
  */
 
 import React, { FC, useState, useContext, useEffect } from 'react';
+import { i18n } from '@kbn/i18n';
 import { EuiSwitch } from '@elastic/eui';
 import { JobCreatorContext } from '../../../../../job_creator_context';
 import { Description } from './description';
@@ -30,7 +31,12 @@ export const DedicatedIndexSwitch: FC = () => {
         onChange={toggleModelPlot}
         data-test-subj="mlJobWizardSwitchUseDedicatedIndex"
         showLabel={false}
-        label="" // TODO: Add label for a11y
+        label={i18n.translate(
+          'xpack.ml.newJob.wizard.jobDetailsStep.advancedSection.useDedicatedIndex.title',
+          {
+            defaultMessage: 'Use dedicated index',
+          }
+        )}
       />
     </Description>
   );

diff --git a/.../job_details_step/components/advanced_section/components/model_plot/model_plot_switch.tsx b/.../job_details_step/components/advanced_section/components/model_plot/model_plot_switch.tsx
@@ -5,6 +5,7 @@
  */
 
 import React, { FC, useState, useContext, useEffect } from 'react';
+import { i18n } from '@kbn/i18n';
 import { EuiSwitch } from '@elastic/eui';
 import { JobCreatorContext } from '../../../../../job_creator_context';
 import { Description } from './description';
@@ -30,7 +31,12 @@ export const ModelPlotSwitch: FC = () => {
         onChange={toggleModelPlot}
         data-test-subj="mlJobWizardSwitchModelPlot"
         showLabel={false}
-        label="" // TODO: Add label for a11y
+        label={i18n.translate(
+          'xpack.ml.newJob.wizard.jobDetailsStep.advancedSection.enableModelPlot.title',
+          {
+            defaultMessage: 'Enable model plot',
+          }
+        )}
       />
     </Description>
   );

diff --git a/...w_job_new/pages/components/pick_fields_step/components/sparse_data/sparse_data_switch.tsx b/...w_job_new/pages/components/pick_fields_step/components/sparse_data/sparse_data_switch.tsx
@@ -5,6 +5,7 @@
  */
 
 import React, { FC, useState, useContext, useEffect } from 'react';
+import { i18n } from '@kbn/i18n';
 import { EuiSwitch } from '@elastic/eui';
 import { JobCreatorContext } from '../../../job_creator_context';
 import { Description } from './description';
@@ -44,7 +45,9 @@ export const SparseDataSwitch: FC = () => {
         onChange={toggleSparseData}
         data-test-subj="mlJobWizardSwitchSparseData"
         showLabel={false}
-        label="" // TODO: Add label for a11y
+        label={i18n.translate('xpack.ml.newJob.wizard.pickFieldsStep.sparseData.title', {
+          defaultMessage: 'Sparse data',
+        })}
       />
     </Description>
   );

diff --git a/x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/job_settings_form.tsx b/x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/job_settings_form.tsx
@@ -248,7 +248,9 @@ export const JobSettingsForm: FC<JobSettingsFormProps> = ({
                   });
                 }}
                 showLabel={false}
-                label="" // TODO: Add label for a11y
+                label={i18n.translate('xpack.ml.newJob.recognize.useDedicatedIndexLabel', {
+                  defaultMessage: 'Use dedicated index',
+                })}
               />
             </EuiFormRow>
           </EuiDescribedFormGroup>

diff --git a/x-pack/legacy/plugins/siem/public/components/ml_popover/jobs_table/job_switch.tsx b/x-pack/legacy/plugins/siem/public/components/ml_popover/jobs_table/job_switch.tsx
@@ -60,7 +60,7 @@ export const JobSwitch = React.memo<JobSwitchProps>(
                 onJobStateChange(job, job.latestTimestampMs || 0, e.target.checked);
               }}
               showLabel={false}
-              label="" // TODO: Add label for a11y
+              label=""
             />
           )}
         </EuiFlexItem>

diff --git a/...gacy/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx b/...gacy/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx
@@ -102,7 +102,7 @@ export class FeatureTable extends Component<Props, {}> {
             id={record.feature.id}
             checked={checked}
             onChange={this.onChange(record.feature.id) as any}
-            label={checked ? `${record.feature.name} visible` : `${record.feature.name} disabled`}
+            label={`${record.feature.name} visible`}
             showLabel={false}
           />
         );