Fix error removing Environment value in APM rules (#156212)

Fixes #153085 Fixes the error shown when removing selected Environment value in the following APM rules: - Latency threshold - Error count threshold - Failed transaction rate threshold
elastic · May 1, 2023 · 61dad95 · 61dad95
1 parent 7a7936e
commit 61dad95
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/x-pack/plugins/apm/public/components/alerting/rule_types/error_count_rule_type/index.tsx b/x-pack/plugins/apm/public/components/alerting/rule_types/error_count_rule_type/index.tsx
@@ -125,7 +125,12 @@ export function ErrorCountRuleType(props: Props) {
     />,
     <EnvironmentField
       currentValue={params.environment}
-      onChange={(value) => setRuleParams('environment', value)}
+      onChange={(value) =>
+        setRuleParams(
+          'environment',
+          value !== '' ? value : ENVIRONMENT_ALL.value
+        )
+      }
       serviceName={params.serviceName}
     />,
     <ErrorGroupingKeyField

diff --git a/...lugins/apm/public/components/alerting/rule_types/transaction_duration_rule_type/index.tsx b/...lugins/apm/public/components/alerting/rule_types/transaction_duration_rule_type/index.tsx
@@ -183,7 +183,12 @@ export function TransactionDurationRuleType(props: Props) {
     />,
     <EnvironmentField
       currentValue={params.environment}
-      onChange={(value) => setRuleParams('environment', value)}
+      onChange={(value) =>
+        setRuleParams(
+          'environment',
+          value !== '' ? value : ENVIRONMENT_ALL.value
+        )
+      }
       serviceName={params.serviceName}
     />,
     <TransactionNameField

diff --git a/...gins/apm/public/components/alerting/rule_types/transaction_error_rate_rule_type/index.tsx b/...gins/apm/public/components/alerting/rule_types/transaction_error_rate_rule_type/index.tsx
@@ -137,7 +137,12 @@ export function TransactionErrorRateRuleType(props: Props) {
     />,
     <EnvironmentField
       currentValue={params.environment}
-      onChange={(value) => setRuleParams('environment', value)}
+      onChange={(value) =>
+        setRuleParams(
+          'environment',
+          value !== '' ? value : ENVIRONMENT_ALL.value
+        )
+      }
       serviceName={params.serviceName}
     />,
     <TransactionNameField