[ML] Fix commonAnnotationUpdateRequestBody

elastic · Jul 30, 2020 · 63414c1 · 63414c1
1 parent 46e1641
commit 63414c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/x-pack/test/api_integration/apis/ml/annotations/create_annotations.ts b/x-pack/test/api_integration/apis/ml/annotations/create_annotations.ts
@@ -54,7 +54,7 @@ export default ({ getService }: FtrProviderContext) => {
       expect(fetchedAnnotation?.create_username).to.eql(USER.ML_POWERUSER);
     });
 
-    it('should successfully create annotation for user without required permission', async () => {
+    it('should successfully create annotation for user with ML read permissions', async () => {
       const { body } = await supertest
         .put('/api/ml/annotations/index')
         .auth(USER.ML_VIEWER, ml.securityCommon.getPasswordForUser(USER.ML_VIEWER))

diff --git a/x-pack/test/api_integration/apis/ml/annotations/update_annotations.ts b/x-pack/test/api_integration/apis/ml/annotations/update_annotations.ts
@@ -86,11 +86,6 @@ export default ({ getService }: FtrProviderContext) => {
       const annotationUpdateRequestBody = {
         ...commonAnnotationUpdateRequestBody,
         job_id: originalAnnotation._source.job_id,
-        type: ANNOTATION_TYPE.ANNOTATION,
-        event: 'model_change',
-        detector_index: 2,
-        partition_field_name: 'airline',
-        partition_field_value: 'ANA',
         _id: originalAnnotation._id,
       };
 
@@ -120,15 +115,8 @@ export default ({ getService }: FtrProviderContext) => {
       const originalAnnotation = annotationsForJob[0];
 
       const annotationUpdateRequestBody = {
-        timestamp: Date.now(),
-        end_timestamp: Date.now(),
-        annotation: 'Updated annotation',
+        ...commonAnnotationUpdateRequestBody,
         job_id: originalAnnotation._source.job_id,
-        type: ANNOTATION_TYPE.ANNOTATION,
-        event: 'model_change',
-        detector_index: 2,
-        partition_field_name: 'airline',
-        partition_field_value: 'ANA',
         _id: originalAnnotation._id,
       };