Update Vega link and pass via DocLinksService

elastic · Mar 22, 2021 · 6cbb0c7 · 6cbb0c7
1 parent 5c7edfe
commit 6cbb0c7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/src/core/public/doc_links/doc_links_service.ts b/src/core/public/doc_links/doc_links_service.ts
@@ -190,7 +190,7 @@ export class DocLinksService {
  lens: `${ELASTIC_WEBSITE_URL}what-is/kibana-lens`,
  lensPanels: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/dashboard.html#create-panels-with-lens`,
  maps: `${ELASTIC_WEBSITE_URL}maps`,
- vega: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/vega-graph.html`,
+ vega: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/vega.html`,
  },
  observability: {
  guide: `${ELASTIC_WEBSITE_URL}guide/en/observability/${DOC_LINK_VERSION}/index.html`,

diff --git a/src/plugins/vis_type_vega/public/components/vega_help_menu.tsx b/src/plugins/vis_type_vega/public/components/vega_help_menu.tsx
@@ -11,6 +11,8 @@ import { EuiButtonIcon, EuiContextMenuPanel, EuiContextMenuItem, EuiPopover } fr
 import { FormattedMessage } from '@kbn/i18n/react';
 import { i18n } from '@kbn/i18n';
 
+import { getDocLinks } from '../services';
+
 function VegaHelpMenu() {
  const [isPopoverOpen, setIsPopoverOpen] = useState(false);
  const onButtonClick = useCallback(() => setIsPopoverOpen(!isPopoverOpen), [isPopoverOpen]);
@@ -30,8 +32,7 @@ function VegaHelpMenu() {
  const items = [
  <EuiContextMenuItem
  key="vegaHelp"
- // TODO: Replace this to use the DocLinksService
- href="https://www.elastic.co/guide/en/kibana/master/vega-graph.html"
+ href={getDocLinks().links.visualize.vega}
  target="_blank"
  onClick={closePopover}
  >

diff --git a/src/plugins/vis_type_vega/public/plugin.ts b/src/plugins/vis_type_vega/public/plugin.ts
@@ -19,6 +19,7 @@ import {
  setUISettings,
  setInjectedMetadata,
  setMapServiceSettings,
+ setDocLinks,
 } from './services';
 
 import { createVegaFn } from './vega_fn';
@@ -96,5 +97,6 @@ export class VegaPlugin implements Plugin<void, void> {
  setNotifications(core.notifications);
  setData(data);
  setInjectedMetadata(core.injectedMetadata);
+ setDocLinks(core.docLinks);
  }
 }
diff --git a/src/plugins/vis_type_vega/public/services.ts b/src/plugins/vis_type_vega/public/services.ts
@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import { CoreStart, NotificationsStart, IUiSettingsClient } from 'src/core/public';
+import { CoreStart, NotificationsStart, IUiSettingsClient, DocLinksStart } from 'src/core/public';
 
 import { DataPublicPluginStart } from '../../data/public';
 import { createGetterSetter } from '../../kibana_utils/public';
@@ -35,3 +35,5 @@ export const [getInjectedVars, setInjectedVars] = createGetterSetter<{
 }>('InjectedVars');
 
 export const getEnableExternalUrls = () => getInjectedVars().enableExternalUrls;
+
+export const [getDocLinks, setDocLinks] = createGetterSetter<DocLinksStart>('docLinks');