Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
TinaHeiligers authored Aug 16, 2021
1 parent 0196166 commit 6def7f8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion src/core/server/saved_objects/service/lib/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export class SavedObjectsErrorHelpers {
}

public static createGenericNotFoundEsUnavailableError(
// type and id not availablefor all operations (e.g. mget)
// type and id not available in all operations (e.g. mget)
type: string | null = null,
id: string | null = null
) {
Expand Down
1 change: 0 additions & 1 deletion src/core/server/saved_objects/service/lib/repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,6 @@ export class SavedObjectsRepository {
}
);
if (statusCode === 404) {
// first need to ensure the 404 is a valid Elasticsearch response
if (!isSupportedEsServer(headers)) {
throw SavedObjectsErrorHelpers.createGenericNotFoundEsUnavailableError();
}
Expand Down

0 comments on commit 6def7f8

Please sign in to comment.