no new testing-library side effects

elastic · Mar 6, 2020 · 7227407 · 7227407
1 parent fc947ac
commit 7227407
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/x-pack/plugins/drilldowns/public/components/flyout_frame/flyout_frame.test.tsx b/x-pack/plugins/drilldowns/public/components/flyout_frame/flyout_frame.test.tsx
@@ -6,9 +6,11 @@
 
 import React from 'react';
 import { render } from 'react-dom';
-import { render as renderTestingLibrary, fireEvent } from '@testing-library/react';
+import { render as renderTestingLibrary, fireEvent, cleanup } from '@testing-library/react/pure';
 import { FlyoutFrame } from '.';
 
+afterEach(cleanup);
+
 describe('<FlyoutFrame>', () => {
   test('renders without crashing', () => {
     const div = document.createElement('div');

diff --git a/...plugins/drilldowns/public/components/form_drilldown_wizard/form_drilldown_wizard.test.tsx b/...plugins/drilldowns/public/components/form_drilldown_wizard/form_drilldown_wizard.test.tsx
@@ -7,9 +7,11 @@
 import React from 'react';
 import { render } from 'react-dom';
 import { FormDrilldownWizard } from './form_drilldown_wizard';
-import { render as renderTestingLibrary, fireEvent } from '@testing-library/react';
+import { render as renderTestingLibrary, fireEvent, cleanup } from '@testing-library/react/pure';
 import { txtNameOfDrilldown } from './i18n';
 
+afterEach(cleanup);
+
 describe('<FormDrilldownWizard>', () => {
   test('renders without crashing', () => {
     const div = document.createElement('div');

diff --git a/...ugins/drilldowns/public/components/list_manage_drilldowns/list_manage_drilldowns.test.tsx b/...ugins/drilldowns/public/components/list_manage_drilldowns/list_manage_drilldowns.test.tsx
@@ -5,7 +5,7 @@
  */
 
 import React from 'react';
-import { cleanup, fireEvent, render } from '@testing-library/react';
+import { cleanup, fireEvent, render } from '@testing-library/react/pure';
 import '@testing-library/jest-dom/extend-expect'; // TODO: this should be global
 import { drilldowns } from './test_data';
 import { ListManageDrilldowns, TEST_SUBJ_DRILLDOWN_ITEM } from './list_manage_drilldowns';