Remove breakdownField

elastic · Jul 9, 2024 · 72c6f7c · 72c6f7c
1 parent 7ebcf02
commit 72c6f7c
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/src/plugins/discover/public/embeddable/initialize_search_embeddable_api.tsx b/src/plugins/discover/public/embeddable/initialize_search_embeddable_api.tsx
@@ -86,7 +86,6 @@ export const initializeSearchEmbeddableApi = async (
   const headerRowHeight$ = new BehaviorSubject<number | undefined>(initialState.headerRowHeight);
   const sort$ = new BehaviorSubject<SortOrder[] | undefined>(initialState.sort);
   const sampleSize$ = new BehaviorSubject<number | undefined>(initialState.sampleSize);
-  const breakdownField$ = new BehaviorSubject<string | undefined>(initialState.breakdownField);
   const savedSearchViewMode$ = new BehaviorSubject<VIEW_MODE | undefined>(initialState.viewMode);
 
   /** This is the state that has to be fetched */
@@ -103,7 +102,6 @@ export const initializeSearchEmbeddableApi = async (
    * treated as the source of truth
    */
   const stateManager: SearchEmbeddableStateManager = {
-    breakdownField: breakdownField$,
     columns: columns$,
     columnsMeta: columnsMeta$,
     headerRowHeight: headerRowHeight$,
@@ -162,7 +160,6 @@ export const initializeSearchEmbeddableApi = async (
           return; // the view mode can't currently be changed from dashboard, so the setter is not necessary
         },
       ],
-      breakdownField: [breakdownField$, (value) => breakdownField$.next(value)],
       sort: [sort$, (value) => sort$.next(value), (a, b) => deepEqual(a, b)],
       columns: [columns$, (value) => columns$.next(value), (a, b) => deepEqual(a, b)],
       sampleSize: [

diff --git a/src/plugins/discover/public/embeddable/types.ts b/src/plugins/discover/public/embeddable/types.ts
@@ -31,14 +31,7 @@ import { EDITABLE_SAVED_SEARCH_KEYS } from './constants';
 
 export type SearchEmbeddableState = Pick<
   SerializableSavedSearch,
-  | 'rowHeight'
-  | 'rowsPerPage'
-  | 'headerRowHeight'
-  | 'columns'
-  | 'sort'
-  | 'sampleSize'
-  | 'breakdownField'
-  | 'viewMode'
+  'rowHeight' | 'rowsPerPage' | 'headerRowHeight' | 'columns' | 'sort' | 'sampleSize' | 'viewMode'
 > & {
   rows: DataTableRecord[];
   columnsMeta: DataTableColumnsMeta | undefined;

diff --git a/src/plugins/discover/public/embeddable/utils/get_discover_locator_params.test.ts b/src/plugins/discover/public/embeddable/utils/get_discover_locator_params.test.ts
@@ -39,7 +39,6 @@ describe('getDiscoverLocatorParams', () => {
       sort: savedSearchMock.sort,
       viewMode: savedSearchMock.viewMode,
       hideAggregatedPreview: savedSearchMock.hideAggregatedPreview,
-      breakdownField: savedSearchMock.breakdownField,
     });
   });
 });
diff --git a/src/plugins/discover/public/embeddable/utils/get_discover_locator_params.ts b/src/plugins/discover/public/embeddable/utils/get_discover_locator_params.ts
@@ -31,7 +31,6 @@ export const getDiscoverLocatorParams = (
         sort: savedSearch?.sort,
         viewMode: savedSearch?.viewMode,
         hideAggregatedPreview: savedSearch?.hideAggregatedPreview,
-        breakdownField: savedSearch?.breakdownField,
       };
 
   return locatorParams;