Skip to content

Commit

Permalink
correct some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tsullivan committed Apr 23, 2020
1 parent 33c2a6b commit 734c5d8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion x-pack/test/functional/apps/dashboard/reporting/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ Every now and then visual changes will be made that will require the snapshots t
node scripts/es_archiver load reporting/ecommerce --config=x-pack/test/reporting/configs/chromium_functional.js
node scripts/es_archiver load reporting/ecommerce_kibana --config=x-pack/test/reporting/configs/chromium_functional.js
```
2. Generate a report of the archived E-commerce dashboard
2. Generate a report of the archived E-commerce dashboard in the Kibana UI.
3. Download the report and save it in the `reports/baseline` folder.
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/visualize/reporting.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export default function({ getService, getPageObjects }) {
});

it('downloaded PDF has OK status', async function() {
// Generating and then comparing reports can take longer than the default 60s timeout because the comparePngs
// function is taking about 15 seconds per comparison in jenkins.
// Generating and then comparing reports can take longer than the default 60s timeout
this.timeout(180000);

await PageObjects.common.navigateToApp('dashboard');
Expand Down

0 comments on commit 734c5d8

Please sign in to comment.