Fix empty properties

elastic · Aug 2, 2022 · 811e843 · 811e843
1 parent 7e6084c
commit 811e843
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 34 deletions.
diff --git a/...gins/fleet/server/services/epm/elasticsearch/template/__snapshots__/template.test.ts.snap b/...gins/fleet/server/services/epm/elasticsearch/template/__snapshots__/template.test.ts.snap
diff --git a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts
@@ -158,7 +158,11 @@ function _generateMappings(
     addDynamicMapping: any;
     groupFieldName?: string;
   }
-): IndexTemplateMappings {
+): {
+  properties: IndexTemplateMappings['properties'];
+  hasNonDynamicTemplateMappings: boolean;
+} {
+  let hasNonDynamicTemplateMappings = false;
   const props: Properties = {};
   // TODO: this can happen when the fields property in fields.yml is present but empty
   // Maybe validation should be moved to fields/field.ts
@@ -213,24 +217,29 @@ function _generateMappings(
 
         switch (type) {
           case 'group':
+            const mappings = _generateMappings(field.fields!, {
+              ...ctx,
+              groupFieldName: ctx.groupFieldName
+                ? `${ctx.groupFieldName}.${field.name}`
+                : field.name,
+            });
+            if (!mappings.hasNonDynamicTemplateMappings) {
+              return;
+            }
+
             fieldProps = {
-              ..._generateMappings(field.fields!, {
-                ...ctx,
-                groupFieldName: ctx.groupFieldName
-                  ? `${ctx.groupFieldName}.${field.name}`
-                  : field.name,
-              }),
+              properties: mappings.properties,
               ...generateDynamicAndEnabled(field),
             };
             break;
           case 'group-nested':
             fieldProps = {
-              ..._generateMappings(field.fields!, {
+              properties: _generateMappings(field.fields!, {
                 ...ctx,
                 groupFieldName: ctx.groupFieldName
                   ? `${ctx.groupFieldName}.${field.name}`
                   : field.name,
-              }),
+              }).properties,
               ...generateNestedProps(field),
               type: 'nested',
             };
@@ -309,11 +318,12 @@ function _generateMappings(
         }
 
         props[field.name] = fieldProps;
+        hasNonDynamicTemplateMappings = true;
       }
     });
   }
 
-  return { properties: props };
+  return { properties: props, hasNonDynamicTemplateMappings };
 }
 
 function generateDynamicAndEnabled(field: Field) {

diff --git a/x-pack/plugins/fleet/server/services/epm/fields/tests/cockroachdb_dynamic_templates.yml b/x-pack/plugins/fleet/server/services/epm/fields/tests/cockroachdb_dynamic_templates.yml
@@ -2,7 +2,7 @@
   type: group
   release: beta
   fields:
-    - name: labels.*
+    - name: labels
       type: object
       object_type: keyword
       description: >