Migrate saved_object_save_as_checkbox directive to timelion

elastic · Jan 28, 2020 · 82e8590 · 82e8590
1 parent fc10fb6
commit 82e8590
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 13 deletions.
diff --git a/src/legacy/core_plugins/timelion/public/app.js b/src/legacy/core_plugins/timelion/public/app.js
@@ -38,7 +38,7 @@ import 'ui/directives/input_focus';
 import './directives/saved_object_finder';
 import 'ui/directives/listen';
 import 'ui/kbn_top_nav';
-import 'ui/saved_objects/ui/saved_object_save_as_checkbox';
+import './directives/saved_object_save_as_checkbox';
 import '../../data/public/legacy';
 import './services/saved_sheet_register';
 

diff --git a/...cts/ui/saved_object_save_as_checkbox.html → ...ctives/saved_object_save_as_checkbox.html b/...cts/ui/saved_object_save_as_checkbox.html → ...ctives/saved_object_save_as_checkbox.html
diff --git a/...jects/ui/saved_object_save_as_checkbox.js → ...rectives/saved_object_save_as_checkbox.js b/...jects/ui/saved_object_save_as_checkbox.js → ...rectives/saved_object_save_as_checkbox.js
@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { uiModules } from '../../modules';
+import { uiModules } from 'ui/modules';
 import saveObjectSaveAsCheckboxTemplate from './saved_object_save_as_checkbox.html';
 
 uiModules.get('kibana').directive('savedObjectSaveAsCheckBox', function() {

diff --git a/src/legacy/ui/public/saved_objects/saved_object.ts b/src/legacy/ui/public/saved_objects/saved_object.ts
@@ -27,7 +27,6 @@
  * This class seems to interface with ES primarily through the es Angular
  * service and the saved object api.
  */
-import { npStart } from 'ui/new_platform';
 import { SavedObject, SavedObjectConfig, SavedObjectKibanaServices } from './types';
 import { buildSavedObject } from './helpers/build_saved_object';
 
@@ -51,13 +50,3 @@ export function createSavedObjectClass(services: SavedObjectKibanaServices) {
 
  return SavedObjectClass as new (config: SavedObjectConfig) => SavedObject;
 }
-// the old angular way, should be removed once no longer used
-export function SavedObjectProvider() {
- const services = {
- savedObjectsClient: npStart.core.savedObjects.client,
- indexPatterns: npStart.plugins.data.indexPatterns,
- chrome: npStart.core.chrome,
- overlays: npStart.core.overlays,
- };
- return createSavedObjectClass(services);
-}