show user lacks of CRUD privileges message when necessary

elastic · Oct 19, 2022 · 83b355e · 83b355e
1 parent 8d21efb
commit 83b355e
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 18 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/utils/privileges/index.ts b/x-pack/plugins/security_solution/public/common/utils/privileges/index.ts
@@ -36,14 +36,17 @@ export const getToolTipContent = (
     | boolean
     | Readonly<{
         [x: string]: boolean;
-      }>
+      }>,
+  canUserCRUD: boolean | null
 ): string | undefined => {
   if (rule == null) {
     return undefined;
   } else if (isMlRule(rule.type) && !hasMlPermissions) {
     return detectionI18n.ML_RULES_DISABLED_MESSAGE;
   } else if (!canEditRuleWithActions(rule, hasReadActionsPrivileges)) {
-    return i18n.EDIT_RULE_SETTINGS_TOOLTIP;
+    return i18n.LACK_OF_KIBANA_PRIVILEGES;
+  } else if (canUserCRUD !== null && !canUserCRUD) {
+    return i18n.LACK_OF_RULE_EDITING_PRIVILEGES;
   } else {
     return undefined;
   }

diff --git a/...tion/public/detections/pages/detection_engine/rules/all/bulk_actions/use_bulk_actions.tsx b/...tion/public/detections/pages/detection_engine/rules/all/bulk_actions/use_bulk_actions.tsx
@@ -332,7 +332,7 @@ export const useBulkActions = ({
               disabled:
                 missingActionPrivileges || containsLoading || (!containsDisabled && !isAllSelected),
               onClick: handleEnableAction,
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
               icon: undefined,
             },
@@ -342,7 +342,7 @@ export const useBulkActions = ({
               'data-test-subj': 'duplicateRuleBulk',
               disabled: isEditDisabled,
               onClick: handleDuplicateAction,
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
               icon: undefined,
             },
@@ -366,7 +366,7 @@ export const useBulkActions = ({
               'data-test-subj': 'addRuleActionsBulk',
               disabled: !hasActionsPrivileges || isEditDisabled,
               onClick: handleBulkEdit(BulkActionEditType.add_rule_actions),
-              toolTipContent: !hasActionsPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: !hasActionsPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
               icon: undefined,
             },
@@ -376,7 +376,7 @@ export const useBulkActions = ({
               'data-test-subj': 'setScheduleBulk',
               disabled: isEditDisabled,
               onClick: handleBulkEdit(BulkActionEditType.set_schedule),
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
               icon: undefined,
             },
@@ -386,7 +386,7 @@ export const useBulkActions = ({
               'data-test-subj': 'applyTimelineTemplateBulk',
               disabled: isEditDisabled,
               onClick: handleBulkEdit(BulkActionEditType.set_timeline),
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
               icon: undefined,
             },
@@ -405,7 +405,7 @@ export const useBulkActions = ({
               disabled:
                 missingActionPrivileges || containsLoading || (!containsEnabled && !isAllSelected),
               onClick: handleDisableActions,
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
               icon: undefined,
             },
@@ -439,7 +439,7 @@ export const useBulkActions = ({
               'data-test-subj': 'addTagsBulkEditRule',
               onClick: handleBulkEdit(BulkActionEditType.add_tags),
               disabled: isEditDisabled,
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
             },
             {
@@ -448,7 +448,7 @@ export const useBulkActions = ({
               'data-test-subj': 'deleteTagsBulkEditRule',
               onClick: handleBulkEdit(BulkActionEditType.delete_tags),
               disabled: isEditDisabled,
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
             },
           ],
@@ -463,7 +463,7 @@ export const useBulkActions = ({
               'data-test-subj': 'addIndexPatternsBulkEditRule',
               onClick: handleBulkEdit(BulkActionEditType.add_index_patterns),
               disabled: isEditDisabled,
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
             },
             {
@@ -472,7 +472,7 @@ export const useBulkActions = ({
               'data-test-subj': 'deleteIndexPatternsBulkEditRule',
               onClick: handleBulkEdit(BulkActionEditType.delete_index_patterns),
               disabled: isEditDisabled,
-              toolTipContent: missingActionPrivileges ? i18n.EDIT_RULE_SETTINGS_TOOLTIP : undefined,
+              toolTipContent: missingActionPrivileges ? i18n.LACK_OF_KIBANA_PRIVILEGES : undefined,
               toolTipPosition: 'right',
             },
           ],

diff --git a/...urity_solution/public/detections/pages/detection_engine/rules/all/rules_table_actions.tsx b/...urity_solution/public/detections/pages/detection_engine/rules/all/rules_table_actions.tsx
@@ -43,7 +43,7 @@ export const getRulesTableActions = ({
     'data-test-subj': 'editRuleAction',
     description: i18n.EDIT_RULE_SETTINGS,
     name: !actionsPrivileges ? (
-      <EuiToolTip position="left" content={i18n.EDIT_RULE_SETTINGS_TOOLTIP}>
+      <EuiToolTip position="left" content={i18n.LACK_OF_KIBANA_PRIVILEGES}>
         <>{i18n.EDIT_RULE_SETTINGS}</>
       </EuiToolTip>
     ) : (
@@ -59,7 +59,7 @@ export const getRulesTableActions = ({
     description: i18n.DUPLICATE_RULE,
     icon: 'copy',
     name: !actionsPrivileges ? (
-      <EuiToolTip position="left" content={i18n.EDIT_RULE_SETTINGS_TOOLTIP}>
+      <EuiToolTip position="left" content={i18n.LACK_OF_KIBANA_PRIVILEGES}>
         <>{i18n.DUPLICATE_RULE}</>
       </EuiToolTip>
     ) : (

diff --git a/...lugins/security_solution/public/detections/pages/detection_engine/rules/details/index.tsx b/...lugins/security_solution/public/detections/pages/detection_engine/rules/details/index.tsx
@@ -689,7 +689,12 @@ const RuleDetailsPageComponent: React.FC<DetectionEngineComponentProps> = ({
                   <EuiFlexItem grow={false}>
                     <EuiToolTip
                       position="top"
-                      content={getToolTipContent(rule, hasMlPermissions, hasActionsPrivileges)}
+                      content={getToolTipContent(
+                        rule,
+                        hasMlPermissions,
+                        hasActionsPrivileges,
+                        canUserCRUD
+                      )}
                     >
                       <EuiFlexGroup>
                         <RuleSwitch
@@ -721,7 +726,8 @@ const RuleDetailsPageComponent: React.FC<DetectionEngineComponentProps> = ({
                           disabledReason={getToolTipContent(
                             rule,
                             hasMlPermissions,
-                            hasActionsPrivileges
+                            hasActionsPrivileges,
+                            canUserCRUD
                           )}
                         />
                       </EuiFlexItem>

diff --git a/.../plugins/security_solution/public/detections/pages/detection_engine/rules/translations.ts b/.../plugins/security_solution/public/detections/pages/detection_engine/rules/translations.ts
@@ -484,13 +484,20 @@ export const EDIT_RULE_SETTINGS = i18n.translate(
   }
 );
 
-export const EDIT_RULE_SETTINGS_TOOLTIP = i18n.translate(
-  'xpack.securitySolution.detectionEngine.rules.allRules.actions.editRuleSettingsToolTip',
+export const LACK_OF_KIBANA_PRIVILEGES = i18n.translate(
+  'xpack.securitySolution.detectionEngine.rules.allRules.actions.lackOfKibanaPrivileges',
   {
     defaultMessage: 'You do not have Kibana Actions privileges',
   }
 );
 
+export const LACK_OF_RULE_EDITING_PRIVILEGES = i18n.translate(
+  'xpack.securitySolution.detectionEngine.rules.allRules.actions.lackOfRuleEditingPrivileges',
+  {
+    defaultMessage: 'You do not have rule editing privileges',
+  }
+);
+
 export const DUPLICATE_RULE = i18n.translate(
   'xpack.securitySolution.detectionEngine.rules.allRules.actions.duplicateRuleDescription',
   {