Skip to content

Commit

Permalink
[8.14] [Search] Fix index name not cleaning in between different indi…
Browse files Browse the repository at this point in the history
…ces (#181837) (#181967)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Search] Fix index name not cleaning in between different indices
(#181837)](#181837)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2024-04-29T11:29:23Z","message":"[Search]
Fix index name not cleaning in between different indices (#181837)\n\n##
Summary\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/76067c45-7f69-4b3e-939c-d6746a2963a6\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"4d55e52756437113c76ddce65ed581e49b70d11d","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.15.0"],"title":"[Search]
Fix index name not cleaning in between different
indices","number":181837,"url":"https://github.com/elastic/kibana/pull/181837","mergeCommit":{"message":"[Search]
Fix index name not cleaning in between different indices (#181837)\n\n##
Summary\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/76067c45-7f69-4b3e-939c-d6746a2963a6\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"4d55e52756437113c76ddce65ed581e49b70d11d"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181837","number":181837,"mergeCommit":{"message":"[Search]
Fix index name not cleaning in between different indices (#181837)\n\n##
Summary\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/76067c45-7f69-4b3e-939c-d6746a2963a6\r\n\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"4d55e52756437113c76ddce65ed581e49b70d11d"}}]}]
BACKPORT-->

Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
  • Loading branch information
kibanamachine and efegurkan authored Apr 29, 2024
1 parent 32ac916 commit 8568438
Showing 1 changed file with 6 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import React, { useState } from 'react';
import React, { useEffect, useState } from 'react';

import { useActions, useValues } from 'kea';

Expand Down Expand Up @@ -39,6 +39,9 @@ export const DeleteIndexModal: React.FC = () => {
} = useValues(IndicesLogic);

const [inputIndexName, setInputIndexName] = useState('');
useEffect(() => {
setInputIndexName('');
}, [isDeleteModalVisible, indexName]);

return isDeleteModalVisible ? (
<EuiConfirmModal
Expand Down Expand Up @@ -138,6 +141,8 @@ export const DeleteIndexModal: React.FC = () => {
)}
>
<EuiFieldText
data-test-subj="entSearchContent-indices-deleteModal-input"
data-telemetry-id="entSearchContent-indices-deleteModal-input"
onChange={(e) => setInputIndexName(e.target.value)}
value={inputIndexName}
/>
Expand Down

0 comments on commit 8568438

Please sign in to comment.