Skip to content

Commit

Permalink
Don't show toast warning in filter agg (#19255) (#19290)
Browse files Browse the repository at this point in the history
  • Loading branch information
timroes authored May 22, 2018
1 parent 5316542 commit 8bd8d4c
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions src/ui/public/agg_types/buckets/filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import { createFilterFilters } from './create_filter/filters';
import { decorateQuery } from '../../courier/data_source/_decorate_query';
import filtersTemplate from '../controls/filters.html';

import { toastNotifications } from 'ui/notify';

export const filtersBucketAgg = new BucketAggType({
name: 'filters',
title: 'Filters',
Expand All @@ -25,10 +23,17 @@ export const filtersBucketAgg = new BucketAggType({

const outFilters = _.transform(inFilters, function (filters, filter) {
const input = _.cloneDeep(filter.input);
if (!input) return toastNotifications.add('malformed filter agg params, missing "input" query');

if (!input) {
console.log('malformed filter agg params, missing "input" query'); // eslint-disable-line no-console
return;
}

const query = input.query = luceneStringToDsl(input.query);
if (!query) return toastNotifications.add('malformed filter agg params, missing "query" on input');
if (!query) {
console.log('malformed filter agg params, missing "query" on input'); // eslint-disable-line no-console
return;
}

decorateQuery(query);

Expand Down

0 comments on commit 8bd8d4c

Please sign in to comment.