🔥 Remove unused props

elastic · Jul 14, 2020 · 8f6047e · 8f6047e
1 parent 60b02e3
commit 8f6047e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/plugins/vis_type_table/public/__snapshots__/table_vis_fn.test.ts.snap b/src/plugins/vis_type_table/public/__snapshots__/table_vis_fn.test.ts.snap
diff --git a/src/plugins/vis_type_table/public/table_vis_fn.ts b/src/plugins/vis_type_table/public/table_vis_fn.ts
@@ -58,14 +58,13 @@ export const createTableVisFn = (): ExpressionFunctionDefinition<
     },
   },
   fn(input, args) {
-    const { title, ...visConfig } = args.visConfig && JSON.parse(args.visConfig);
+    const visConfig = args.visConfig && JSON.parse(args.visConfig);
     const convertedData = tableVisResponseHandler(input, visConfig.dimensions);
 
     return {
       type: 'render',
       as: 'visualization',
       value: {
-        title,
         visData: convertedData,
         visType: 'table',
         visConfig,

diff --git a/src/plugins/visualizations/public/components/visualization_chart.tsx b/src/plugins/visualizations/public/components/visualization_chart.tsx
@@ -62,8 +62,8 @@ class VisualizationChart extends React.Component<VisualizationChartProps> {
           // has been initialized
           throw new Error('Visualization implementation was not initialized on first render.');
         }
-        // need to pass the title here again to refresh in case of save in-place or renaming
-        return this.visualization.render(visData, { ...visParams, title: vis.title });
+
+        return this.visualization.render(visData, visParams);
       })
     );