[Response Ops] [Connectors] Move connectors to own plugin (#139867)

* Initial commit of stack connectors plugin

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Fixing up xmatters. Moving library functions around

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* Fixing up webhook

* Fixing up teams and slack

* Fixing up index, email, pagerduty, server log

* Fixing i18n

* wip

* Moving well know email route to stack connectors plugin

* Fixing types

* Fixing unit tests

* Adding index.ts

* Cleanup

* Updating READMEs

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* Moving to domain specific folders and updating codeowners

* Fixing codeowners

* Fixing types

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

.eslintrc.js

@@ -1313,7 +1313,7 @@ module.exports = {
     {
       // typescript for front and back end
       files: [
-        'x-pack/plugins/{alerting,stack_alerts,actions,task_manager,event_log}/**/*.{ts,tsx}',
+        'x-pack/plugins/{alerting,stack_alerts,stack_connectors,actions,task_manager,event_log}/**/*.{ts,tsx}',
       ],
       rules: {
         '@typescript-eslint/no-explicit-any': 'error',

.github/CODEOWNERS

@@ -326,6 +326,9 @@ x-pack/examples/files_example @elastic/kibana-app-services
 /x-pack/plugins/actions/ @elastic/response-ops
 /x-pack/plugins/event_log/ @elastic/response-ops
 /x-pack/plugins/task_manager/ @elastic/response-ops
+/x-pack/plugins/stack_connectors/ @elastic/response-ops
+/x-pack/plugins/stack_connectors/server/connector_types/stack/ @elastic/response-ops-execution
+/x-pack/plugins/stack_connectors/server/connector_types/cases/ @elastic/response-ops-cases
 /x-pack/test/alerting_api_integration/ @elastic/response-ops
 /x-pack/test/plugin_api_integration/test_suites/task_manager/ @elastic/response-ops
 /x-pack/plugins/triggers_actions_ui/ @elastic/response-ops

docs/developer/plugin-list.asciidoc

@@ -645,6 +645,10 @@ the alertTypes by the Stack in the alerting plugin, register associated HTTP
 routes, etc.
 
 
+|{kib-repo}blob/{branch}/x-pack/plugins/stack_connectors/README.md[stackConnectors]
+|The stack_connectors plugin provides connector types shipped with Kibana, built on top of the framework provided in the actions plugin.
+
+
 |{kib-repo}blob/{branch}/x-pack/plugins/synthetics/README.md[synthetics]
 |The purpose of this plugin is to provide users of Heartbeat more visibility of what's happening
 in their infrastructure.

tsconfig.base.json

@@ -419,6 +419,8 @@
       "@kbn/spaces-plugin/*": ["x-pack/plugins/spaces/*"],
       "@kbn/stack-alerts-plugin": ["x-pack/plugins/stack_alerts"],
       "@kbn/stack-alerts-plugin/*": ["x-pack/plugins/stack_alerts/*"],
+      "@kbn/stack-connectors-plugin": ["x-pack/plugins/stack_connectors"],
+      "@kbn/stack-connectors-plugin/*": ["x-pack/plugins/stack_connectors/*"],
       "@kbn/synthetics-plugin": ["x-pack/plugins/synthetics"],
       "@kbn/synthetics-plugin/*": ["x-pack/plugins/synthetics/*"],
       "@kbn/task-manager-plugin": ["x-pack/plugins/task_manager"],

x-pack/.i18nrc.json

@@ -5,6 +5,7 @@
     "xpack.alerting": "plugins/alerting",
     "xpack.eventLog": "plugins/event_log",
     "xpack.stackAlerts": "plugins/stack_alerts",
+    "xpack.stackConnectors": "plugins/stack_connectors",
     "xpack.apm": "plugins/apm",
     "xpack.canvas": "plugins/canvas",
     "xpack.cases": "plugins/cases",

x-pack/plugins/actions/common/index.ts

@@ -13,16 +13,8 @@ export * from './alert_history_schema';
 export * from './rewrite_request_case';
 export * from './mustache_template';
 export * from './validate_email_addresses';
-export * from './servicenow_config';
 export * from './connector_feature_config';
 
 export const BASE_ACTION_API_PATH = '/api/actions';
 export const INTERNAL_BASE_ACTION_API_PATH = '/internal/actions';
 export const ACTIONS_FEATURE_ID = 'actions';
-
-// supported values for `service` in addition to nodemailer's list of well-known services
-export enum AdditionalEmailServices {
-  ELASTIC_CLOUD = 'elastic_cloud',
-  EXCHANGE = 'exchange_server',
-  OTHER = 'other',
-}

x-pack/plugins/actions/common/types.ts

@@ -7,6 +7,12 @@
 
 import { LicenseType } from '@kbn/licensing-plugin/common/types';
 
+export {
+  AlertingConnectorFeatureId,
+  CasesConnectorFeatureId,
+  UptimeConnectorFeatureId,
+  SecurityConnectorFeatureId,
+} from './connector_feature_config';
 export interface ActionType {
   id: string;
   name: string;

x-pack/plugins/actions/server/actions_client.test.ts

@@ -36,13 +36,13 @@ import {
 } from './authorization/get_authorization_mode_by_source';
 import { actionsAuthorizationMock } from './authorization/actions_authorization.mock';
 import { trackLegacyRBACExemption } from './lib/track_legacy_rbac_exemption';
-import { ConnectorTokenClient } from './builtin_action_types/lib/connector_token_client';
+import { ConnectorTokenClient } from './lib/connector_token_client';
 import { encryptedSavedObjectsMock } from '@kbn/encrypted-saved-objects-plugin/server/mocks';
 import { Logger } from '@kbn/core/server';
-import { connectorTokenClientMock } from './builtin_action_types/lib/connector_token_client.mock';
+import { connectorTokenClientMock } from './lib/connector_token_client.mock';
 import { inMemoryMetricsMock } from './monitoring/in_memory_metrics.mock';
-import { getOAuthJwtAccessToken } from './builtin_action_types/lib/get_oauth_jwt_access_token';
-import { getOAuthClientCredentialsAccessToken } from './builtin_action_types/lib/get_oauth_client_credentials_access_token';
+import { getOAuthJwtAccessToken } from './lib/get_oauth_jwt_access_token';
+import { getOAuthClientCredentialsAccessToken } from './lib/get_oauth_client_credentials_access_token';
 import { OAuthParams } from './routes/get_oauth_access_token';
 
 jest.mock('@kbn/core-saved-objects-utils-server', () => {
@@ -74,10 +74,10 @@ jest.mock('./authorization/get_authorization_mode_by_source', () => {
   };
 });
 
-jest.mock('./builtin_action_types/lib/get_oauth_jwt_access_token', () => ({
+jest.mock('./lib/get_oauth_jwt_access_token', () => ({
   getOAuthJwtAccessToken: jest.fn(),
 }));
-jest.mock('./builtin_action_types/lib/get_oauth_client_credentials_access_token', () => ({
+jest.mock('./lib/get_oauth_client_credentials_access_token', () => ({
   getOAuthClientCredentialsAccessToken: jest.fn(),
 }));
 

x-pack/plugins/actions/server/actions_client.ts

@@ -55,7 +55,7 @@ import {
 } from './authorization/get_authorization_mode_by_source';
 import { connectorAuditEvent, ConnectorAuditAction } from './lib/audit_events';
 import { trackLegacyRBACExemption } from './lib/track_legacy_rbac_exemption';
-import { isConnectorDeprecated } from './lib/is_conector_deprecated';
+import { isConnectorDeprecated } from './lib/is_connector_deprecated';
 import { ActionsConfigurationUtilities } from './actions_config';
 import {
   OAuthClientCredentialsParams,
@@ -66,12 +66,12 @@ import {
   getOAuthJwtAccessToken,
   GetOAuthJwtConfig,
   GetOAuthJwtSecrets,
-} from './builtin_action_types/lib/get_oauth_jwt_access_token';
+} from './lib/get_oauth_jwt_access_token';
 import {
   getOAuthClientCredentialsAccessToken,
   GetOAuthClientCredentialsConfig,
   GetOAuthClientCredentialsSecrets,
-} from './builtin_action_types/lib/get_oauth_client_credentials_access_token';
+} from './lib/get_oauth_client_credentials_access_token';
 
 // We are assuming there won't be many actions. This is why we will load
 // all the actions in advance and assume the total count to not go over 10000.

x-pack/plugins/actions/server/actions_config.ts

@@ -15,7 +15,7 @@ import { ActionsConfig, AllowedHosts, EnabledActionTypes, CustomHostSettings } f
 import { getCanonicalCustomHostUrl } from './lib/custom_host_settings';
 import { ActionTypeDisabledError } from './lib';
 import { ProxySettings, ResponseSettings, SSLSettings } from './types';
-import { getSSLSettingsFromConfig } from './builtin_action_types/lib/get_node_ssl_options';
+import { getSSLSettingsFromConfig } from './lib/get_node_ssl_options';
 import {
   ValidateEmailAddressesOptions,
   validateEmailAddresses,

x-pack/plugins/actions/server/index.ts

@@ -25,31 +25,6 @@ export type {
   FindActionResult,
 } from './types';
 
-export type {
-  CasesWebhookActionTypeId,
-  CasesWebhookActionParams,
-  EmailActionTypeId,
-  EmailActionParams,
-  IndexActionTypeId,
-  IndexActionParams,
-  PagerDutyActionTypeId,
-  PagerDutyActionParams,
-  ServerLogActionTypeId,
-  ServerLogActionParams,
-  SlackActionTypeId,
-  SlackActionParams,
-  WebhookActionTypeId,
-  WebhookActionParams,
-  ServiceNowITSMActionTypeId,
-  ServiceNowSIRActionTypeId,
-  ServiceNowActionParams,
-  JiraActionTypeId,
-  JiraActionParams,
-  ResilientActionTypeId,
-  ResilientActionParams,
-  TeamsActionTypeId,
-  TeamsActionParams,
-} from './builtin_action_types';
 export type { PluginSetupContract, PluginStartContract } from './plugin';
 
 export { asSavedObjectExecutionSource, asHttpRequestExecutionSource } from './lib';

x-pack/plugins/actions/server/lib/action_executor.ts

@@ -227,6 +227,7 @@ export class ActionExecutor {
             secrets: validatedSecrets,
             isEphemeral,
             taskInfo,
+            configurationUtilities,
           });
         } catch (err) {
           if (err.reason === ActionExecutionErrorReason.Validation) {

x-pack/plugins/actions/server/lib/axios_utils.test.ts

@@ -20,7 +20,7 @@ import {
 } from './axios_utils';
 import { loggingSystemMock } from '@kbn/core/server/mocks';
 import { actionsConfigMock } from '../actions_config.mock';
-import { getCustomAgents } from '../builtin_action_types/lib/get_custom_agents';
+import { getCustomAgents } from './get_custom_agents';
 
 const TestUrl = 'https://elastic.co/foo/bar/baz';
 

x-pack/plugins/actions/server/lib/axios_utils.ts

@@ -8,7 +8,7 @@
 import { isObjectLike, isEmpty } from 'lodash';
 import { AxiosInstance, Method, AxiosResponse, AxiosRequestConfig } from 'axios';
 import { Logger } from '@kbn/core/server';
-import { getCustomAgents } from '../builtin_action_types/lib/get_custom_agents';
+import { getCustomAgents } from './get_custom_agents';
 import { ActionsConfigurationUtilities } from '../actions_config';
 
 export const request = async <T = unknown>({

x-pack/plugins/actions/server/builtin_action_types/lib/connector_token_client.test.ts → x-pack/plugins/actions/server/lib/connector_token_client.test.ts

@@ -10,7 +10,7 @@ import { loggingSystemMock, savedObjectsClientMock } from '@kbn/core/server/mock
 import { encryptedSavedObjectsMock } from '@kbn/encrypted-saved-objects-plugin/server/mocks';
 import { ConnectorTokenClient } from './connector_token_client';
 import { Logger } from '@kbn/core/server';
-import { ConnectorToken } from '../../types';
+import { ConnectorToken } from '../types';
 
 const logger = loggingSystemMock.create().get() as jest.Mocked<Logger>;
 jest.mock('@kbn/core-saved-objects-utils-server', () => {

x-pack/plugins/actions/server/builtin_action_types/lib/connector_token_client.ts → x-pack/plugins/actions/server/lib/connector_token_client.ts

@@ -8,8 +8,8 @@
 import { omitBy, isUndefined } from 'lodash';
 import { EncryptedSavedObjectsClient } from '@kbn/encrypted-saved-objects-plugin/server';
 import { Logger, SavedObjectsClientContract, SavedObjectsUtils } from '@kbn/core/server';
-import { ConnectorToken } from '../../types';
-import { CONNECTOR_TOKEN_SAVED_OBJECT_TYPE } from '../../constants/saved_objects';
+import { ConnectorToken } from '../types';
+import { CONNECTOR_TOKEN_SAVED_OBJECT_TYPE } from '../constants/saved_objects';
 
 export const MAX_TOKENS_RETURNED = 1;
 

x-pack/plugins/actions/server/lib/ensure_sufficient_license.ts

@@ -7,11 +7,11 @@
 
 import { LICENSE_TYPE } from '@kbn/licensing-plugin/common/types';
 import { ActionType } from '../types';
-import { ServerLogActionTypeId, IndexActionTypeId } from '../builtin_action_types';
 import { ActionTypeConfig, ActionTypeSecrets, ActionTypeParams } from '../types';
 
 const CASE_ACTION_TYPE_ID = '.case';
-
+const ServerLogActionTypeId = '.server-log';
+const IndexActionTypeId = '.index';
 const ACTIONS_SCOPED_WITHIN_STACK = new Set([
   ServerLogActionTypeId,
   IndexActionTypeId,

x-pack/plugins/actions/server/builtin_action_types/lib/get_custom_agents.test.ts → x-pack/plugins/actions/server/lib/get_custom_agents.test.ts

@@ -11,7 +11,7 @@ import { HttpsProxyAgent } from 'https-proxy-agent';
 import { Logger } from '@kbn/core/server';
 import { getCustomAgents } from './get_custom_agents';
 import { loggingSystemMock } from '@kbn/core/server/mocks';
-import { actionsConfigMock } from '../../actions_config.mock';
+import { actionsConfigMock } from '../actions_config.mock';
 const logger = loggingSystemMock.create().get() as jest.Mocked<Logger>;
 
 const targetHost = 'elastic.co';