popover padding size unified

elastic · Aug 19, 2021 · 9356c70 · 9356c70
1 parent cb0ce59
commit 9356c70
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 27 deletions.
diff --git a/x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx b/x-pack/plugins/observability/public/pages/alerts/alerts_table_t_grid.tsx
@@ -33,7 +33,7 @@ import {
  EuiDataGridColumn,
  EuiFlexGroup,
  EuiFlexItem,
- EuiContextMenu,
+ EuiContextMenuPanel,
  EuiPopover,
 } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
@@ -219,26 +219,21 @@ function ObservabilityActions({
  onUpdateFailure: onAlertStatusUpdated,
  });
 
- const actionsPanels = useMemo(() => {
+ const actionsMenuItems = useMemo(() => {
  return [
- {
- id: 0,
- content: [
- timelines.getAddToExistingCaseButton({
- event,
- casePermissions,
- appId: observabilityFeatureId,
- onClose: afterCaseSelection,
- }),
- timelines.getAddToNewCaseButton({
- event,
- casePermissions,
- appId: observabilityFeatureId,
- onClose: afterCaseSelection,
- }),
- ...(alertPermissions.crud ? statusActionItems : []),
- ],
- },
+ timelines.getAddToExistingCaseButton({
+ event,
+ casePermissions,
+ appId: observabilityFeatureId,
+ onClose: afterCaseSelection,
+ }),
+ timelines.getAddToNewCaseButton({
+ event,
+ casePermissions,
+ appId: observabilityFeatureId,
+ onClose: afterCaseSelection,
+ }),
+ ...(alertPermissions.crud ? statusActionItems : []),
  ];
  }, [afterCaseSelection, casePermissions, timelines, event, statusActionItems, alertPermissions]);
 
@@ -279,7 +274,7 @@ function ObservabilityActions({
  panelPaddingSize="none"
  anchorPosition="downLeft"
  >
- <EuiContextMenu panels={actionsPanels} initialPanelId={0} />
+ <EuiContextMenuPanel size="s" items={actionsMenuItems} />
  </EuiPopover>
  </EuiFlexItem>
  </EuiFlexGroup>

diff --git a/...lugins/timelines/public/components/actions/timeline/cases/add_to_existing_case_button.tsx b/...lugins/timelines/public/components/actions/timeline/cases/add_to_existing_case_button.tsx
@@ -33,7 +33,6 @@ const AddToCaseActionComponent: React.FC<AddToCaseActionProps> = ({
  <EuiContextMenuItem
  aria-label={ariaLabel}
  data-test-subj="attach-alert-to-case-button"
- size="s"
  onClick={addExistingCaseClick}
  disabled={isDisabled}
  >

diff --git a/x-pack/plugins/timelines/public/components/actions/timeline/cases/add_to_new_case_button.tsx b/x-pack/plugins/timelines/public/components/actions/timeline/cases/add_to_new_case_button.tsx
@@ -34,7 +34,6 @@ const AddToCaseActionComponent: React.FC<AddToCaseActionProps> = ({
  <EuiContextMenuItem
  aria-label={ariaLabel}
  data-test-subj="attach-alert-to-case-button"
- size="s"
  onClick={addNewCaseClick}
  disabled={isDisabled}
  >

diff --git a/x-pack/plugins/timelines/public/components/t_grid/toolbar/bulk_actions/index.tsx b/x-pack/plugins/timelines/public/components/t_grid/toolbar/bulk_actions/index.tsx
@@ -96,7 +96,7 @@ const BulkActionsComponent: React.FC<BulkActionsProps> = ({
  <EuiPopover
  isOpen={isActionsPopoverOpen}
  anchorPosition="upCenter"
- panelPaddingSize="s"
+ panelPaddingSize="none"
  button={
  <EuiButtonEmpty
  aria-label="selectedShowBulkActions"

diff --git a/x-pack/plugins/timelines/public/hooks/use_status_bulk_action_items.tsx b/x-pack/plugins/timelines/public/hooks/use_status_bulk_action_items.tsx
@@ -127,7 +127,6 @@ export const useStatusBulkActionItems = ({
  key="open"
  data-test-subj="open-alert-status"
  onClick={() => onClickUpdate(FILTER_OPEN)}
- size="s"
  >
  {i18n.BULK_ACTION_OPEN_SELECTED}
  </EuiContextMenuItem>
@@ -139,7 +138,6 @@ export const useStatusBulkActionItems = ({
  key="acknowledge"
  data-test-subj="acknowledged-alert-status"
  onClick={() => onClickUpdate(FILTER_ACKNOWLEDGED)}
- size="s"
  >
  {i18n.BULK_ACTION_ACKNOWLEDGED_SELECTED}
  </EuiContextMenuItem>
@@ -151,7 +149,6 @@ export const useStatusBulkActionItems = ({
  key="close"
  data-test-subj="close-alert-status"
  onClick={() => onClickUpdate(FILTER_CLOSED)}
- size="s"
  >
  {i18n.BULK_ACTION_CLOSE_SELECTED}
  </EuiContextMenuItem>