Removed loading state for endpoint

elastic · Oct 19, 2020 · 9376d54 · 9376d54
1 parent adba239
commit 9376d54
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 39 deletions.
diff --git a/...erprise_search/public/applications/app_search/components/credentials/credentials.test.tsx b/...erprise_search/public/applications/app_search/components/credentials/credentials.test.tsx
@@ -52,7 +52,7 @@ describe('Credentials', () => {
     setMockValues({ dataLoading: true });
     const wrapper = shallow(<Credentials />);
     expect(wrapper.find('[data-test-subj="CreateAPIKeyButton"]')).toHaveLength(0);
-    expect(wrapper.find(EuiLoadingContent)).toHaveLength(2);
+    expect(wrapper.find(EuiLoadingContent)).toHaveLength(1);
   });
 
   it('renders the API endpoint and a button to copy it', () => {

diff --git a/...s/enterprise_search/public/applications/app_search/components/credentials/credentials.tsx b/...s/enterprise_search/public/applications/app_search/components/credentials/credentials.tsx
@@ -64,44 +64,35 @@ export const Credentials: React.FC = () => {
       </EuiPageHeader>
       <EuiPageContentBody>
         <EuiPanel className="eui-textCenter">
-          {!!dataLoading ? (
-            <EuiLoadingContent lines={3} />
-          ) : (
-            <>
-              <EuiTitle size="s">
-                <h2>
-                  {i18n.translate('xpack.enterpriseSearch.appSearch.credentials.apiEndpoint', {
-                    defaultMessage: 'Endpoint',
-                  })}
-                </h2>
-              </EuiTitle>
-              <EuiCopy
-                textToCopy={externalUrl.enterpriseSearchUrl}
-                afterMessage={i18n.translate(
-                  'xpack.enterpriseSearch.appSearch.credentials.copied',
-                  {
-                    defaultMessage: 'Copied',
-                  }
-                )}
-              >
-                {(copy) => (
-                  <>
-                    <EuiButtonIcon
-                      onClick={copy}
-                      iconType="copyClipboard"
-                      aria-label={i18n.translate(
-                        'xpack.enterpriseSearch.appSearch.credentials.copyApiEndpoint',
-                        {
-                          defaultMessage: 'Copy API Endpoint to clipboard.',
-                        }
-                      )}
-                    />
-                    {externalUrl.enterpriseSearchUrl}
-                  </>
-                )}
-              </EuiCopy>
-            </>
-          )}
+          <EuiTitle size="s">
+            <h2>
+              {i18n.translate('xpack.enterpriseSearch.appSearch.credentials.apiEndpoint', {
+                defaultMessage: 'Endpoint',
+              })}
+            </h2>
+          </EuiTitle>
+          <EuiCopy
+            textToCopy={externalUrl.enterpriseSearchUrl}
+            afterMessage={i18n.translate('xpack.enterpriseSearch.appSearch.credentials.copied', {
+              defaultMessage: 'Copied',
+            })}
+          >
+            {(copy) => (
+              <>
+                <EuiButtonIcon
+                  onClick={copy}
+                  iconType="copyClipboard"
+                  aria-label={i18n.translate(
+                    'xpack.enterpriseSearch.appSearch.credentials.copyApiEndpoint',
+                    {
+                      defaultMessage: 'Copy API Endpoint to clipboard.',
+                    }
+                  )}
+                />
+                {externalUrl.enterpriseSearchUrl}
+              </>
+            )}
+          </EuiCopy>
         </EuiPanel>
         <EuiSpacer size="xxl" />
         <EuiPageContentHeader responsive={false}>