security solution and lists to TS incremental builds (#100447)

* lists to ts incremental builds * security_solution to ts incremental * import ResizeObserver explicitly as it is not declared in dom types
elastic · May 24, 2021 · 95e8eed · 95e8eed
1 parent 496999f
commit 95e8eed
Show file tree

Hide file tree

Showing 20 changed files with 149 additions and 58 deletions.
diff --git a/src/core/server/http/http_server.mocks.ts b/src/core/server/http/http_server.mocks.ts
@@ -27,7 +27,10 @@ import { OnPreResponseToolkit } from './lifecycle/on_pre_response';
 import { OnPostAuthToolkit } from './lifecycle/on_post_auth';
 import { OnPreRoutingToolkit } from './lifecycle/on_pre_routing';
 
-interface RequestFixtureOptions<P = any, Q = any, B = any> {
+/**
+ * @internal
+ */
+export interface RequestFixtureOptions<P = any, Q = any, B = any> {
   auth?: { isAuthenticated: boolean };
   headers?: Record<string, string>;
   params?: Record<string, any>;

diff --git a/tsconfig.json b/tsconfig.json
@@ -13,15 +13,9 @@
     "src/legacy/**/*",
     "src/optimize/**/*",
 
-    "x-pack/mocks.ts",
-    "x-pack/typings/**/*",
     "x-pack/tasks/**/*",
-    "x-pack/plugins/lists/**/*",
-    "x-pack/plugins/security_solution/**/*"
-  ],
-  "exclude": [
-    "x-pack/plugins/security_solution/cypress/**/*"
   ],
+  "exclude": [],
   "references": [
     { "path": "./src/core/tsconfig.json" },
     { "path": "./src/plugins/telemetry_management_section/tsconfig.json" },
@@ -108,6 +102,7 @@
     { "path": "./x-pack/plugins/license_api_guard/tsconfig.json" },
     { "path": "./x-pack/plugins/license_management/tsconfig.json" },
     { "path": "./x-pack/plugins/licensing/tsconfig.json" },
+    { "path": "./x-pack/plugins/lists/tsconfig.json" },
     { "path": "./x-pack/plugins/logstash/tsconfig.json" },
     { "path": "./x-pack/plugins/maps/tsconfig.json" },
     { "path": "./x-pack/plugins/metrics_entities/tsconfig.json" },
@@ -119,6 +114,7 @@
     { "path": "./x-pack/plugins/saved_objects_tagging/tsconfig.json" },
     { "path": "./x-pack/plugins/searchprofiler/tsconfig.json" },
     { "path": "./x-pack/plugins/security/tsconfig.json" },
+    { "path": "./x-pack/plugins/security_solution/tsconfig.json" },
     { "path": "./x-pack/plugins/snapshot_restore/tsconfig.json" },
     { "path": "./x-pack/plugins/spaces/tsconfig.json" },
     { "path": "./x-pack/plugins/stack_alerts/tsconfig.json" },

diff --git a/tsconfig.refs.json b/tsconfig.refs.json
@@ -85,6 +85,7 @@
     { "path": "./x-pack/plugins/lens/tsconfig.json" },
     { "path": "./x-pack/plugins/license_management/tsconfig.json" },
     { "path": "./x-pack/plugins/licensing/tsconfig.json" },
+    { "path": "./x-pack/plugins/lists/tsconfig.json" },
     { "path": "./x-pack/plugins/logstash/tsconfig.json" },
     { "path": "./x-pack/plugins/maps/tsconfig.json" },
     { "path": "./x-pack/plugins/metrics_entities/tsconfig.json" },
@@ -97,6 +98,7 @@
     { "path": "./x-pack/plugins/saved_objects_tagging/tsconfig.json" },
     { "path": "./x-pack/plugins/searchprofiler/tsconfig.json" },
     { "path": "./x-pack/plugins/security/tsconfig.json" },
+    { "path": "./x-pack/plugins/security_solution/tsconfig.json" },
     { "path": "./x-pack/plugins/snapshot_restore/tsconfig.json" },
     { "path": "./x-pack/plugins/spaces/tsconfig.json" },
     { "path": "./x-pack/plugins/stack_alerts/tsconfig.json" },

diff --git a/x-pack/plugins/lists/tsconfig.json b/x-pack/plugins/lists/tsconfig.json
@@ -0,0 +1,23 @@
+
+{
+    "extends": "../../../tsconfig.base.json",
+    "compilerOptions": {
+      "composite": true,
+      "outDir": "./target/types",
+      "emitDeclarationOnly": true,
+      "declaration": true,
+      "declarationMap": true
+    },
+    "include": [
+      "common/**/*",
+      "public/**/*",
+      "server/**/*",
+      // have to declare *.json explicitly due to https://github.com/microsoft/TypeScript/issues/25636
+      "server/**/*.json",
+    ],
+    "references": [
+      { "path": "../../../src/core/tsconfig.json" },
+      { "path": "../spaces/tsconfig.json" },
+      { "path": "../security/tsconfig.json"},
+    ]
+  }
diff --git a/x-pack/plugins/security_solution/common/detection_engine/schemas/request/rule_schemas.ts b/x-pack/plugins/security_solution/common/detection_engine/schemas/request/rule_schemas.ts
@@ -70,7 +70,7 @@ import {
   last_failure_message,
 } from '../common/schemas';
 
-const createSchema = <
+export const createSchema = <
   Required extends t.Props,
   Optional extends t.Props,
   Defaultable extends t.Props
@@ -118,7 +118,7 @@ const responseSchema = <
   ]);
 };
 
-const buildAPISchemas = <R extends t.Props, O extends t.Props, D extends t.Props>(
+export const buildAPISchemas = <R extends t.Props, O extends t.Props, D extends t.Props>(
   params: APIParams<R, O, D>
 ) => {
   return {
@@ -216,6 +216,7 @@ const {
   patch: eqlPatchParams,
   response: eqlResponseParams,
 } = buildAPISchemas(eqlRuleParams);
+export { eqlCreateParams };
 
 const threatMatchRuleParams = {
   required: {
@@ -244,6 +245,7 @@ const {
   patch: threatMatchPatchParams,
   response: threatMatchResponseParams,
 } = buildAPISchemas(threatMatchRuleParams);
+export { threatMatchCreateParams };
 
 const queryRuleParams = {
   required: {
@@ -265,6 +267,8 @@ const {
   response: queryResponseParams,
 } = buildAPISchemas(queryRuleParams);
 
+export { queryCreateParams };
+
 const savedQueryRuleParams = {
   required: {
     type: t.literal('saved_query'),
@@ -287,6 +291,8 @@ const {
   response: savedQueryResponseParams,
 } = buildAPISchemas(savedQueryRuleParams);
 
+export { savedQueryCreateParams };
+
 const thresholdRuleParams = {
   required: {
     type: t.literal('threshold'),
@@ -308,6 +314,8 @@ const {
   response: thresholdResponseParams,
 } = buildAPISchemas(thresholdRuleParams);
 
+export { thresholdCreateParams };
+
 const machineLearningRuleParams = {
   required: {
     type: t.literal('machine_learning'),
@@ -323,6 +331,8 @@ const {
   response: machineLearningResponseParams,
 } = buildAPISchemas(machineLearningRuleParams);
 
+export { machineLearningCreateParams };
+
 const createTypeSpecific = t.union([
   eqlCreateParams,
   threatMatchCreateParams,

diff --git a/x-pack/plugins/security_solution/common/endpoint/types/index.ts b/x-pack/plugins/security_solution/common/endpoint/types/index.ts
@@ -59,9 +59,9 @@ export type Immutable<T> = T extends undefined | null | boolean | string | numbe
   : ImmutableObject<T>;
 
 export type ImmutableArray<T> = ReadonlyArray<Immutable<T>>;
-type ImmutableMap<K, V> = ReadonlyMap<Immutable<K>, Immutable<V>>;
-type ImmutableSet<T> = ReadonlySet<Immutable<T>>;
-type ImmutableObject<T> = { readonly [K in keyof T]: Immutable<T[K]> };
+export type ImmutableMap<K, V> = ReadonlyMap<Immutable<K>, Immutable<V>>;
+export type ImmutableSet<T> = ReadonlySet<Immutable<T>>;
+export type ImmutableObject<T> = { readonly [K in keyof T]: Immutable<T[K]> };
 
 /**
  * Utility type that will return back a union of the given [T]ype and an Immutable version of it

diff --git a/...ns/security_solution/public/common/components/ml/permissions/ml_capabilities_provider.tsx b/...ns/security_solution/public/common/components/ml/permissions/ml_capabilities_provider.tsx
@@ -14,7 +14,7 @@ import { useHttp } from '../../../lib/kibana';
 import { useGetMlCapabilities } from '../hooks/use_get_ml_capabilities';
 import * as i18n from './translations';
 
-interface MlCapabilitiesProvider extends MlCapabilitiesResponse {
+export interface MlCapabilitiesProvider extends MlCapabilitiesResponse {
   capabilitiesFetched: boolean;
 }
 

diff --git a/x-pack/plugins/security_solution/public/common/components/page/manage_query.tsx b/x-pack/plugins/security_solution/public/common/components/page/manage_query.tsx
@@ -12,7 +12,7 @@ import React from 'react';
 import { inputsModel } from '../../store';
 import { GlobalTimeArgs } from '../../containers/use_global_time';
 
-interface OwnProps extends Pick<GlobalTimeArgs, 'deleteQuery' | 'setQuery'> {
+export interface OwnProps extends Pick<GlobalTimeArgs, 'deleteQuery' | 'setQuery'> {
   headerChildren?: React.ReactNode;
   id: string;
   legendPosition?: Position;
@@ -21,7 +21,9 @@ interface OwnProps extends Pick<GlobalTimeArgs, 'deleteQuery' | 'setQuery'> {
   inspect?: inputsModel.InspectQuery;
 }
 
-export function manageQuery<T>(WrappedComponent: React.ComponentClass<T> | React.ComponentType<T>) {
+export function manageQuery<T>(
+  WrappedComponent: React.ComponentClass<T> | React.ComponentType<T>
+): React.ComponentClass<OwnProps & T> {
   class ManageQuery extends React.PureComponent<OwnProps & T> {
     static displayName: string;
     public componentDidUpdate(prevProps: OwnProps) {

diff --git a/x-pack/plugins/security_solution/public/common/components/super_date_picker/index.tsx b/x-pack/plugins/security_solution/public/common/components/super_date_picker/index.tsx
@@ -47,13 +47,13 @@ interface Range {
   display: string;
 }
 
-interface UpdateReduxTime extends OnTimeChangeProps {
+export interface UpdateReduxTime extends OnTimeChangeProps {
   id: InputsModelId;
   kql?: inputsModel.GlobalKqlQuery | undefined;
   timelineId?: string;
 }
 
-interface ReturnUpdateReduxTime {
+export interface ReturnUpdateReduxTime {
   kqlHaveBeenUpdated: boolean;
 }
 

diff --git a/x-pack/plugins/security_solution/public/common/components/top_n/index.tsx b/x-pack/plugins/security_solution/public/common/components/top_n/index.tsx
@@ -73,7 +73,7 @@ const connector = connect(makeMapStateToProps);
 //    this component is rendered in the context of the active timeline. This
 //    behavior enables the 'All events' view by appending the alerts index
 //    to the index pattern.
-interface OwnProps {
+export interface OwnProps {
   browserFields: BrowserFields;
   field: string;
   indexPattern: IIndexPattern;
@@ -172,4 +172,6 @@ const StatefulTopNComponent: React.FC<Props> = ({
 
 StatefulTopNComponent.displayName = 'StatefulTopNComponent';
 
-export const StatefulTopN = connector(React.memo(StatefulTopNComponent));
+export const StatefulTopN: React.FunctionComponent<OwnProps> = connector(
+  React.memo(StatefulTopNComponent)
+);
diff --git a/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/action.ts b/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/action.ts
@@ -18,120 +18,121 @@ import { GetPackagesResponse } from '../../../../../../fleet/common';
 import { EndpointState } from '../types';
 import { IIndexPattern } from '../../../../../../../../src/plugins/data/public';
 
-interface ServerReturnedEndpointList {
+export interface ServerReturnedEndpointList {
   type: 'serverReturnedEndpointList';
   payload: HostResultList;
 }
 
-interface ServerFailedToReturnEndpointList {
+export interface ServerFailedToReturnEndpointList {
   type: 'serverFailedToReturnEndpointList';
   payload: ServerApiError;
 }
 
-interface ServerReturnedEndpointDetails {
+export interface ServerReturnedEndpointDetails {
   type: 'serverReturnedEndpointDetails';
   payload: HostInfo;
 }
 
-interface ServerFailedToReturnEndpointDetails {
+export interface ServerFailedToReturnEndpointDetails {
   type: 'serverFailedToReturnEndpointDetails';
   payload: ServerApiError;
 }
 
-interface ServerReturnedEndpointPolicyResponse {
+export interface ServerReturnedEndpointPolicyResponse {
   type: 'serverReturnedEndpointPolicyResponse';
   payload: GetHostPolicyResponse;
 }
 
-interface ServerFailedToReturnEndpointPolicyResponse {
+export interface ServerFailedToReturnEndpointPolicyResponse {
   type: 'serverFailedToReturnEndpointPolicyResponse';
   payload: ServerApiError;
 }
 
-interface ServerReturnedPoliciesForOnboarding {
+export interface ServerReturnedPoliciesForOnboarding {
   type: 'serverReturnedPoliciesForOnboarding';
   payload: {
     policyItems: GetPolicyListResponse['items'];
   };
 }
 
-interface ServerFailedToReturnPoliciesForOnboarding {
+export interface ServerFailedToReturnPoliciesForOnboarding {
   type: 'serverFailedToReturnPoliciesForOnboarding';
   payload: ServerApiError;
 }
 
-interface UserSelectedEndpointPolicy {
+export interface UserSelectedEndpointPolicy {
   type: 'userSelectedEndpointPolicy';
   payload: {
     selectedPolicyId: string;
   };
 }
 
-interface ServerCancelledEndpointListLoading {
+export interface ServerCancelledEndpointListLoading {
   type: 'serverCancelledEndpointListLoading';
 }
 
-interface ServerCancelledPolicyItemsLoading {
+export interface ServerCancelledPolicyItemsLoading {
   type: 'serverCancelledPolicyItemsLoading';
 }
 
-interface ServerReturnedEndpointPackageInfo {
+export interface ServerReturnedEndpointPackageInfo {
   type: 'serverReturnedEndpointPackageInfo';
   payload: GetPackagesResponse['response'][0];
 }
 
-interface ServerReturnedEndpointNonExistingPolicies {
+export interface ServerReturnedEndpointNonExistingPolicies {
   type: 'serverReturnedEndpointNonExistingPolicies';
   payload: EndpointState['nonExistingPolicies'];
 }
 
-interface ServerReturnedEndpointAgentPolicies {
+export interface ServerReturnedEndpointAgentPolicies {
   type: 'serverReturnedEndpointAgentPolicies';
   payload: EndpointState['agentPolicies'];
 }
 
-interface ServerReturnedEndpointExistValue {
+export interface ServerReturnedEndpointExistValue {
   type: 'serverReturnedEndpointExistValue';
   payload: boolean;
 }
 
-interface ServerReturnedMetadataPatterns {
+export interface ServerReturnedMetadataPatterns {
   type: 'serverReturnedMetadataPatterns';
   payload: IIndexPattern[];
 }
 
-interface ServerFailedToReturnMetadataPatterns {
+export interface ServerFailedToReturnMetadataPatterns {
   type: 'serverFailedToReturnMetadataPatterns';
   payload: ServerApiError;
 }
-interface UserUpdatedEndpointListRefreshOptions {
+
+export interface UserUpdatedEndpointListRefreshOptions {
   type: 'userUpdatedEndpointListRefreshOptions';
   payload: {
     isAutoRefreshEnabled?: boolean;
     autoRefreshInterval?: number;
   };
 }
 
-interface AppRequestedEndpointList {
+export interface AppRequestedEndpointList {
   type: 'appRequestedEndpointList';
 }
 
-interface ServerReturnedAgenstWithEndpointsTotal {
+export interface ServerReturnedAgenstWithEndpointsTotal {
   type: 'serverReturnedAgenstWithEndpointsTotal';
   payload: number;
 }
 
-interface ServerFailedToReturnAgenstWithEndpointsTotal {
+export interface ServerFailedToReturnAgenstWithEndpointsTotal {
   type: 'serverFailedToReturnAgenstWithEndpointsTotal';
   payload: ServerApiError;
 }
 
-interface ServerReturnedEndpointsTotal {
+export interface ServerReturnedEndpointsTotal {
   type: 'serverReturnedEndpointsTotal';
   payload: number;
 }
 
-interface ServerFailedToReturnEndpointsTotal {
+export interface ServerFailedToReturnEndpointsTotal {
   type: 'serverFailedToReturnEndpointsTotal';
   payload: ServerApiError;
 }