disable update button if mml not valid

elastic · Jul 6, 2020 · 9ac1b43 · 9ac1b43
1 parent ffedb7c
commit 9ac1b43
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/..._analytics/pages/analytics_management/components/analytics_list/edit_analytics_flyout.tsx b/..._analytics/pages/analytics_management/components/analytics_list/edit_analytics_flyout.tsx
@@ -58,8 +58,10 @@ export const EditAnalyticsFlyout: FC<EditAnalyticsJobFlyoutProps> = ({ closeFlyo
   const { id: jobId, config } = item;
   const { state } = item.stats;
 
+  // Disable if all fields are empty or mml is not valid
   const updateButtonDisabled =
-    allowLazyStart === '' && description === '' && modelMemoryLimit === '';
+    (allowLazyStart === '' && description === '' && modelMemoryLimit === '') ||
+    mmlValidationError !== undefined;
 
   useEffect(() => {
     if (mmLValidator === undefined) {
@@ -176,7 +178,9 @@ export const EditAnalyticsFlyout: FC<EditAnalyticsJobFlyoutProps> = ({ closeFlyo
                 ]}
                 value={allowLazyStart}
                 hasNoInitialSelection={true}
-                onChange={(e: any) => setAllowLazyStart(e.target.value)}
+                onChange={(e: React.ChangeEvent<HTMLSelectElement>) =>
+                  setAllowLazyStart(e.target.value)
+                }
               />
             </EuiFormRow>
             <EuiFormRow