[ML] Data frame analytics: ensure results view loads correctly for jo…

…b created in dev tools (#107024) * check analyzed_fields exists * update DataFrameAnalyticsConfig type to make analyzed_fields optional * updating accessing analyzed_fields for type update
elastic · Jul 30, 2021 · 9dcecae · 9dcecae
1 parent faed2f6
commit 9dcecae
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/x-pack/plugins/ml/common/types/data_frame_analytics.ts b/x-pack/plugins/ml/common/types/data_frame_analytics.ts
@@ -80,9 +80,9 @@ export interface DataFrameAnalyticsConfig {
     runtime_mappings?: RuntimeMappings;
   };
   analysis: AnalysisConfig;
-  analyzed_fields: {
-    includes: string[];
-    excludes: string[];
+  analyzed_fields?: {
+    includes?: string[];
+    excludes?: string[];
   };
   model_memory_limit: string;
   max_num_threads?: number;

diff --git a/...es/analytics_exploration/components/exploration_page_wrapper/exploration_page_wrapper.tsx b/...es/analytics_exploration/components/exploration_page_wrapper/exploration_page_wrapper.tsx
@@ -116,8 +116,8 @@ export const ExplorationPageWrapper: FC<Props> = ({
   const resultsField = jobConfig?.dest.results_field ?? '';
   const scatterplotFieldOptions = useScatterplotFieldOptions(
     indexPattern,
-    jobConfig?.analyzed_fields.includes,
-    jobConfig?.analyzed_fields.excludes,
+    jobConfig?.analyzed_fields?.includes,
+    jobConfig?.analyzed_fields?.excludes,
     resultsField
   );
 

diff --git a/...lytics/pages/analytics_exploration/components/outlier_exploration/outlier_exploration.tsx b/...lytics/pages/analytics_exploration/components/outlier_exploration/outlier_exploration.tsx
@@ -92,8 +92,8 @@ export const OutlierExploration: FC<ExplorationProps> = React.memo(({ jobId }) =
 
   const scatterplotFieldOptions = useScatterplotFieldOptions(
     indexPattern,
-    jobConfig?.analyzed_fields.includes,
-    jobConfig?.analyzed_fields.excludes,
+    jobConfig?.analyzed_fields?.includes,
+    jobConfig?.analyzed_fields?.excludes,
     resultsField
   );
 

diff --git a/x-pack/plugins/ml/server/models/data_frame_analytics/validation.ts b/x-pack/plugins/ml/server/models/data_frame_analytics/validation.ts
@@ -448,7 +448,7 @@ export async function validateAnalyticsJob(
 ) {
   const messages = await getValidationCheckMessages(
     client.asCurrentUser,
-    job.analyzed_fields.includes,
+    job?.analyzed_fields?.includes || [],
     job.analysis,
     job.source
   );