Skip to content

Commit

Permalink
[QA] Code coverage: fix flaky tests (#69272)
Browse files Browse the repository at this point in the history
* skip test

* [page_objects/common_page] update closing toast
  • Loading branch information
dmlemeshko authored Jun 16, 2020
1 parent d5785a0 commit 9f7620b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions test/functional/apps/dashboard/dashboard_filter_bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ export default function ({ getService, getPageObjects }) {
});

describe('saved search filtering', function () {
// https://github.com/elastic/kibana/issues/47286#issuecomment-644687577
this.tags('skipCoverage');
before(async () => {
await filterBar.ensureFieldEditorModalIsClosed();
await PageObjects.dashboard.gotoDashboardLandingPage();
Expand Down
2 changes: 1 addition & 1 deletion test/functional/page_objects/common_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
async closeToastIfExists() {
const toastShown = await find.existsByCssSelector('.euiToast');
if (toastShown) {
await this.closeToast();
await find.clickByCssSelector('.euiToast__closeButton');
}
}

Expand Down

0 comments on commit 9f7620b

Please sign in to comment.