Fix error thrown when Kibana is sent a SIGHUP to reload logging config (

#89218)

* Fix error thrown when Kibana is sent a SIGHUP to reload logging config

* Adding a simple unit test to catch a future regression

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

packages/kbn-legacy-logging/src/setup_logging.test.ts

@@ -0,0 +1,35 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * and the Server Side Public License, v 1; you may not use this file except in
+ * compliance with, at your election, the Elastic License or the Server Side
+ * Public License, v 1.
+ */
+
+import { Server } from '@hapi/hapi';
+import { reconfigureLogging, setupLogging } from './setup_logging';
+import { LegacyLoggingConfig } from './schema';
+
+describe('reconfigureLogging', () => {
+ test(`doesn't throw an error`, () => {
+ const server = new Server();
+ const config: LegacyLoggingConfig = {
+ silent: false,
+ quiet: false,
+ verbose: true,
+ events: {},
+ dest: '/tmp/foo',
+ filter: {},
+ json: true,
+ rotate: {
+ enabled: false,
+ everyBytes: 0,
+ keepFiles: 0,
+ pollingInterval: 0,
+ usePolling: false,
+ },
+ };
+ setupLogging(server, config, 10);
+ reconfigureLogging(server, { ...config, dest: '/tmp/bar' }, 0);
+ });
+});

packages/kbn-legacy-logging/src/setup_logging.ts

@@ -37,5 +37,5 @@ export function reconfigureLogging(
  opsInterval: number
 ) {
  const loggingOptions = getLoggingConfiguration(config, opsInterval);
- (server.plugins as any)['@elastic/good'].reconfigure(loggingOptions);
+ (server.plugins as any).good.reconfigure(loggingOptions);
 }