pr comments

elastic · Dec 14, 2023 · a8121c6 · a8121c6
1 parent 144d40a
commit a8121c6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/...st/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_detection.cy.ts b/...st/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_detection.cy.ts
@@ -29,18 +29,20 @@ describe('Ransomware Detection Alerts', { tags: ['@ess', '@serverless'] }, () =>
     cy.task('esArchiverUnload', 'ransomware_detection');
   });
 
-  describe('Ransomware display on Alerts Page', () => {
+  describe('Ransomware in Alerts Page', () => {
     beforeEach(() => {
       login();
       visitWithTimeRange(ALERTS_URL);
       waitForAlertsToPopulate();
     });
 
-    it('should show Ransomware Alerts in alerts table', () => {
+    it('should show ransomware alerts on alerts page', () => {
+      cy.log('should show ransomware alerts in alerts table');
+
       cy.get(ALERT_RULE_NAME).should('have.text', 'Ransomware Detection Alert');
-    });
 
-    it('should show Ransomware Prevention Alert in the trend chart', () => {
+      cy.log('should show ransomware prevention alert in the trend chart');
+
       selectAlertsHistogram();
       cy.get(ALERTS_HISTOGRAM_SERIES).should('have.text', 'Ransomware Detection Alert');
     });
@@ -54,7 +56,7 @@ describe('Ransomware Detection Alerts', { tags: ['@ess', '@serverless'] }, () =>
       createTimeline();
     });
 
-    it('Renders ransomware entries in timelines table', () => {
+    it('should show ransomware entries in timelines table', () => {
       cy.get(TIMELINE_QUERY).type('event.code: "ransomware"{enter}');
 
       // Wait for grid to load, it should have an analyzer icon

diff --git a/...t/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_prevention.cy.ts b/...t/security_solution_cypress/cypress/e2e/investigations/alerts/ransomware_prevention.cy.ts
@@ -29,17 +29,19 @@ describe('Ransomware Prevention Alerts', { tags: ['@ess', '@serverless'] }, () =
     cy.task('esArchiverUnload', 'ransomware_prevention');
   });
 
-  describe('Ransomware display on Alerts Page', () => {
+  describe('Ransomware in Alerts Page', () => {
     beforeEach(() => {
       login();
       visitWithTimeRange(ALERTS_URL);
     });
 
-    it('should show Ransomware Alerts in alerts table', () => {
+    it('should show ransomware alerts on alerts page', () => {
+      cy.log('should show ransomware alerts in alert table');
+
       cy.get(ALERT_RULE_NAME).should('have.text', 'Ransomware Prevention Alert');
-    });
 
-    it('should show Ransomware Prevention Alert in the trend chart', () => {
+      cy.log('should show ransomware prevention alert in the trend chart');
+
       selectAlertsHistogram();
       cy.get(ALERTS_HISTOGRAM_SERIES).should('have.text', 'Ransomware Prevention Alert');
     });
@@ -48,13 +50,13 @@ describe('Ransomware Prevention Alerts', { tags: ['@ess', '@serverless'] }, () =
   describe('Ransomware in Timelines', function () {
     beforeEach(() => {
       deleteTimelines();
+      login();
       createTimeline({ ...getTimeline(), query: 'event.code: "ransomware"' }).then((response) => {
         cy.wrap(response.body.data.persistTimeline.timeline.savedObjectId).as('timelineId');
       });
     });
 
-    it('Renders ransomware entries in timelines table', function () {
-      login();
+    it('should render ransomware entries in timelines table', function () {
       const timeline = this.timelineId;
       visitTimeline(timeline);
       // Wait for grid to load, it should have an analyzer icon

diff --git a/x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts b/x-pack/test/security_solution_cypress/cypress/tasks/alerts.ts
@@ -273,7 +273,7 @@ export const selectCountTable = () => {
 };
 
 export const selectAlertsHistogram = () => {
-  cy.get(SELECT_HISTOGRAM).click({ force: true });
+  cy.get(SELECT_HISTOGRAM).click();
 };
 
 export const goToAcknowledgedAlerts = () => {