[Global Search Bar] Updated placeholder text to be more directive

And fixed search bar’s width on smaller screens
elastic · Mar 16, 2022 · a8ee0ce · a8ee0ce
1 parent 89c103d
commit a8ee0ce
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 5 deletions.
diff --git a/x-pack/plugins/global_search_bar/public/components/search_bar.scss b/x-pack/plugins/global_search_bar/public/components/search_bar.scss
@@ -16,7 +16,6 @@
 
 //TODO add these overrides to EUI so that search behaves the same globally (eui/issues/4363)
 .kbnSearchBar {
-  width: 400px;
   max-width: 100%;
   will-change: width;
 }
@@ -27,6 +26,12 @@
   }
 }
 
+@include euiBreakpoint('m', 'l', 'xl') {
+  .kbnSearchBar {
+    width: 400px;
+  }
+}
+
 @include euiBreakpoint('l', 'xl') {
   .kbnSearchBar:focus {
     animation: kbnAnimateSearchBar $euiAnimSpeedFast forwards;

diff --git a/x-pack/plugins/global_search_bar/public/components/search_bar.tsx b/x-pack/plugins/global_search_bar/public/components/search_bar.tsx
@@ -262,7 +262,7 @@ export const SearchBar: FC<SearchBarProps> = ({
 
   const emptyMessage = <PopoverPlaceholder darkMode={darkMode} basePath={basePathUrl} />;
   const placeholderText = i18n.translate('xpack.globalSearchBar.searchBar.placeholder', {
-    defaultMessage: 'Search Elastic',
+    defaultMessage: 'Find any page in Kibana',
   });
 
   useEvent('keydown', onKeyDown);
@@ -287,6 +287,7 @@ export const SearchBar: FC<SearchBarProps> = ({
           trackUiMetric(METRIC_TYPE.COUNT, 'search_focus');
           setInitialLoad(true);
         },
+        fullWidth: true,
       }}
       emptyMessage={emptyMessage}
       noMatchesMessage={emptyMessage}

diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json
@@ -10464,7 +10464,6 @@
     "xpack.globalSearchBar.searchBar.noResultsImageAlt": "Illustration d'un trou noir",
     "xpack.globalSearchBar.searchBar.optionTagListAriaLabel": "Balises",
     "xpack.globalSearchBar.searchbar.overflowTagsAriaLabel": "{n} {n, plural, one {balise} other {balises}} de plus : {tags}",
-    "xpack.globalSearchBar.searchBar.placeholder": "Rechercher dans Elastic",
     "xpack.globalSearchBar.searchBar.shortcutDescription.macCommandDescription": "Commande + /",
     "xpack.globalSearchBar.searchBar.shortcutDescription.shortcutDetail": "{shortcutDescription} {commandDescription}",
     "xpack.globalSearchBar.searchBar.shortcutDescription.shortcutInstructionDescription": "Raccourci",

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -12496,7 +12496,6 @@
     "xpack.globalSearchBar.searchBar.noResultsImageAlt": "ブラックホールの図",
     "xpack.globalSearchBar.searchBar.optionTagListAriaLabel": "タグ",
     "xpack.globalSearchBar.searchbar.overflowTagsAriaLabel": "{n} その他の {n, plural, other  {個のタグ}}：{tags}",
-    "xpack.globalSearchBar.searchBar.placeholder": "Elastic を検索",
     "xpack.globalSearchBar.searchBar.shortcutDescription.macCommandDescription": "コマンド+ /",
     "xpack.globalSearchBar.searchBar.shortcutDescription.shortcutDetail": "{shortcutDescription} {commandDescription}",
     "xpack.globalSearchBar.searchBar.shortcutDescription.shortcutInstructionDescription": "ショートカット",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -12519,7 +12519,6 @@
     "xpack.globalSearchBar.searchBar.noResultsImageAlt": "黑洞的图示",
     "xpack.globalSearchBar.searchBar.optionTagListAriaLabel": "标签",
     "xpack.globalSearchBar.searchbar.overflowTagsAriaLabel": "另外 {n} 个{n, plural, other {标签}}：{tags}",
-    "xpack.globalSearchBar.searchBar.placeholder": "搜索 Elastic",
     "xpack.globalSearchBar.searchBar.shortcutDescription.macCommandDescription": "Command + /",
     "xpack.globalSearchBar.searchBar.shortcutDescription.shortcutDetail": "{shortcutDescription} {commandDescription}",
     "xpack.globalSearchBar.searchBar.shortcutDescription.shortcutInstructionDescription": "快捷方式",