fix(monitoring): add data-test-subj props to tables

elastic · Dec 23, 2024 · b36ab64 · b36ab64
1 parent a218b4b
commit b36ab64
Show file tree

Hide file tree

Showing 14 changed files with 14 additions and 2 deletions.
diff --git a/x-pack/plugins/monitoring/public/application/pages/logstash/node_pipelines.tsx b/x-pack/plugins/monitoring/public/application/pages/logstash/node_pipelines.tsx
@@ -99,6 +99,7 @@ export const LogStashNodePipelinesPage: React.FC<ComponentProps> = ({ clusters }
       {data.pipelines && (
         <div data-test-subj="logstashPipelinesListing">
           <PipelineListing
+            data-test-subj="monitoringLogstashPipelinesTable"
             onBrush={onBrush}
             zoomInfo={zoomInfo}
             stats={data.nodeSummary}

diff --git a/x-pack/plugins/monitoring/public/application/pages/logstash/pipelines.tsx b/x-pack/plugins/monitoring/public/application/pages/logstash/pipelines.tsx
@@ -87,6 +87,7 @@ export const LogStashPipelinesPage: React.FC<ComponentProps> = ({ clusters }) =>
     const upgradeMessage = pageData ? makeUpgradeMessage(clusterStatus.versions) : null;
     return (
       <PipelineListing
+        data-test-subj="monitoringLogstashPipelinesTable"
         onBrush={(xaxis: any) => onBrush({ xaxis })}
         stats={clusterStatus}
         data={pipelines}

diff --git a/x-pack/plugins/monitoring/public/components/apm/instances/instances.tsx b/x-pack/plugins/monitoring/public/components/apm/instances/instances.tsx
@@ -185,6 +185,7 @@ export function ApmServerInstances({ apms, setupMode, alerts }: Props) {
         <EuiPanel>
           {setupModeCallout}
           <EuiMonitoringTable
+            data-test-subj="apmInstancesTable"
             rows={data.apms}
             columns={getColumns(setupMode, data.cgroup)}
             sorting={sorting}

diff --git a/x-pack/plugins/monitoring/public/components/beats/listing/listing.js b/x-pack/plugins/monitoring/public/components/beats/listing/listing.js
@@ -159,6 +159,7 @@ export class Listing extends PureComponent {
           <EuiPanel>
             {setupModeCallOut}
             <EuiMonitoringTable
+              data-test-subj="beatsTable"
               rows={data}
               setupMode={setupMode}
               productName={BEATS_SYSTEM_ID}

diff --git a/x-pack/plugins/monitoring/public/components/cluster/listing/listing.js b/x-pack/plugins/monitoring/public/components/cluster/listing/listing.js
@@ -434,6 +434,7 @@ export const Listing = ({ angular, clusters, sorting, pagination, onTableChange
             <StandaloneClusterCallout changeCluster={_changeCluster} storage={storage} />
           ) : null}
           <EuiMonitoringTable
+            data-test-subj="clusterTable"
             rows={clusters}
             columns={getColumns(
               showLicenseExpiration,

diff --git a/x-pack/plugins/monitoring/public/components/elasticsearch/indices/indices.js b/x-pack/plugins/monitoring/public/components/elasticsearch/indices/indices.js
@@ -190,6 +190,7 @@ export const ElasticsearchIndices = ({
           />
           <EuiSpacer size="m" />
           <EuiMonitoringTable
+            data-test-subj="elasticsearchIndicesTable"
             rows={indices}
             columns={getColumns(alerts)}
             sorting={sorting}

diff --git a/x-pack/plugins/monitoring/public/components/elasticsearch/ml_jobs/ml_jobs.tsx b/x-pack/plugins/monitoring/public/components/elasticsearch/ml_jobs/ml_jobs.tsx
@@ -53,6 +53,7 @@ export const ElasticsearchMLJobs = ({
         <EuiSpacer size="m" />
         <EuiPanel>
           <EuiMonitoringTable
+            data-test-subj="mlJobsTable"
             rows={jobs}
             columns={columns}
             sorting={{

diff --git a/x-pack/plugins/monitoring/public/components/elasticsearch/nodes/nodes.js b/x-pack/plugins/monitoring/public/components/elasticsearch/nodes/nodes.js
@@ -515,6 +515,7 @@ export function ElasticsearchNodes({ clusterStatus, showCgroupMetricsElasticsear
         {setupModeCallout}
         <EuiPanel>
           <EuiMonitoringSSPTable
+            data-test-subj="elasticsearchNodesTable"
             rows={nodes}
             columns={columns}
             sorting={sorting}

diff --git a/x-pack/plugins/monitoring/public/components/elasticsearch/shard_activity/shard_activity.js b/x-pack/plugins/monitoring/public/components/elasticsearch/shard_activity/shard_activity.js
@@ -139,6 +139,7 @@ export const ShardActivity = (props) => {
       />
       <EuiSpacer />
       <EuiMonitoringTable
+        data-test-subj="esShardActivityTable"
         rows={rows}
         columns={columns}
         message={getNoDataMessage()}

diff --git a/x-pack/plugins/monitoring/public/components/kibana/instances/instances.tsx b/x-pack/plugins/monitoring/public/components/kibana/instances/instances.tsx
@@ -324,6 +324,7 @@ export const KibanaInstances: React.FC<Props> = (props: Props) => {
         {setupModeCallOut}
         <EuiPanel>
           <EuiMonitoringTable
+            data-test-subj="kibanaInstancesTable"
             rows={dataFlattened}
             columns={getColumns(setupMode, alerts, dateFormat, staleStatusThresholdSeconds)}
             sorting={sorting}

diff --git a/x-pack/plugins/monitoring/public/components/logstash/listing/listing.js b/x-pack/plugins/monitoring/public/components/logstash/listing/listing.js
@@ -200,6 +200,7 @@ export class Listing extends PureComponent {
           {setupModeCallOut}
           <EuiPanel>
             <EuiMonitoringTable
+              data-test-subj="logstashNodesTable"
               rows={flattenedData}
               setupMode={setupMode}
               productName={LOGSTASH_SYSTEM_ID}

diff --git a/x-pack/plugins/monitoring/public/components/logstash/pipeline_listing/pipeline_listing.js b/x-pack/plugins/monitoring/public/components/logstash/pipeline_listing/pipeline_listing.js
@@ -159,6 +159,7 @@ export class PipelineListing extends Component {
           <EuiSpacer size="m" />
           <EuiPanel>
             <EuiMonitoringSSPTable
+              data-test-subj={this.props['data-test-subj'] || 'logstashNodesTable'}
               rows={data}
               columns={columns}
               sorting={sortingOptions}

diff --git a/x-pack/plugins/monitoring/public/components/table/eui_table.tsx b/x-pack/plugins/monitoring/public/components/table/eui_table.tsx
@@ -67,7 +67,7 @@ export const EuiMonitoringTable: FunctionComponent<Record<any, any>> = ({
   }
 
   return (
-    <div data-test-subj={`${props.className}Container`}>
+    <div data-test-subj={`${props['data-test-subj']}Container`}>
       <EuiInMemoryTable
         data-test-subj={
           items.length && hasItems === true ? 'monitoringTableHasData' : 'monitoringTableNoData'

diff --git a/x-pack/plugins/monitoring/public/components/table/eui_table_ssp.js b/x-pack/plugins/monitoring/public/components/table/eui_table_ssp.js
@@ -100,7 +100,7 @@ export function EuiMonitoringSSPTable({
   };
 
   return (
-    <div data-test-subj={`${props.className}Container`}>
+    <div data-test-subj={`${props['data-test-subj']}Container`}>
       <EuiSearchBar {...search} onChange={onQueryChange} />
       <EuiSpacer size="l" />
       <EuiBasicTable