[APM] Treat error.exception.stacktrace.line as optional (#55733)

elastic · Jan 24, 2020 · b39076e · b39076e
1 parent 6beb2b2
commit b39076e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/FrameHeading.tsx b/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/FrameHeading.tsx
@@ -34,7 +34,7 @@ const FrameHeading: React.FC<Props> = ({ stackframe, isLibraryFrame }) => {
  const FileDetail = isLibraryFrame
  ? LibraryFrameFileDetail
  : AppFrameFileDetail;
- const lineNumber = stackframe.line.number;
+ const lineNumber = stackframe.line?.number ?? 0;
 
  const name =
  'filename' in stackframe ? stackframe.filename : stackframe.classname;
@@ -46,7 +46,7 @@ const FrameHeading: React.FC<Props> = ({ stackframe, isLibraryFrame }) => {
  {lineNumber > 0 && (
  <Fragment>
  {' at '}
- <FileDetail>line {stackframe.line.number}</FileDetail>
+ <FileDetail>line {lineNumber}</FileDetail>
  </Fragment>
  )}
  </FileDetails>

diff --git a/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/Stackframe.tsx b/x-pack/legacy/plugins/apm/public/components/shared/Stacktrace/Stackframe.tsx
@@ -77,5 +77,5 @@ export function Stackframe({
 function hasLineContext(
  stackframe: IStackframe
 ): stackframe is IStackframeWithLineContext {
- return stackframe.line.hasOwnProperty('context');
+ return stackframe.line?.hasOwnProperty('context') || false;
 }
diff --git a/x-pack/legacy/plugins/apm/typings/es_schemas/raw/fields/Stackframe.ts b/x-pack/legacy/plugins/apm/typings/es_schemas/raw/fields/Stackframe.ts
@@ -15,7 +15,7 @@ type IStackframeBase = {
  vars?: {
  [key: string]: unknown;
  };
- line: {
+ line?: {
  number: number;
  };
 } & ({ classname: string } | { filename: string });