cleanup

elastic · Oct 14, 2020 · b434688 · b434688
1 parent 70b539e
commit b434688
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/...security_solution/common/search_strategy/security_solution/hosts/authentications/index.ts b/...security_solution/common/search_strategy/security_solution/hosts/authentications/index.ts
@@ -47,7 +47,6 @@ export interface AuthenticationItem {
 export interface LastSourceHost {
   timestamp?: Maybe<string>;
   source?: Maybe<SourceEcs>;
-  'source.ip'?: string;
   host?: Maybe<HostEcs>;
 }
 

diff --git a/x-pack/plugins/security_solution/public/hosts/components/authentications_table/index.tsx b/x-pack/plugins/security_solution/public/hosts/components/authentications_table/index.tsx
@@ -256,10 +256,7 @@ const getAuthenticationColumns = (): AuthTableColumns => [
     hideForMobile: false,
     render: ({ node }) =>
       getRowItemDraggables({
-        rowItems:
-          node.lastSuccess?.source?.ip ||
-          (node.lastSuccess?.['source.ip'] && [node.lastSuccess?.['source.ip']]) ||
-          null,
+        rowItems: node.lastSuccess?.source?.ip || null,
         attrName: 'source.ip',
         idPrefix: `authentications-table-${node._id}-lastSuccessSource`,
         render: (item) => <NetworkDetailsLink ip={item} />,
@@ -294,10 +291,7 @@ const getAuthenticationColumns = (): AuthTableColumns => [
     hideForMobile: false,
     render: ({ node }) =>
       getRowItemDraggables({
-        rowItems:
-          node.lastFailure?.source?.ip ||
-          (node.lastFailure?.['source.ip'] && [node.lastFailure?.['source.ip']]) ||
-          null,
+        rowItems: node.lastFailure?.source?.ip || null,
         attrName: 'source.ip',
         idPrefix: `authentications-table-${node._id}-lastFailureSource`,
         render: (item) => <NetworkDetailsLink ip={item} />,

diff --git a/x-pack/plugins/security_solution/public/hosts/components/authentications_table/mock.ts b/x-pack/plugins/security_solution/public/hosts/components/authentications_table/mock.ts
@@ -51,7 +51,9 @@ export const mockData: { Authentications: HostAuthenticationsStrategyResponse }
           },
           lastFailure: {
             timestamp: '2019-01-23T22:35:32.222Z',
-            'source.ip': '8.8.8.8',
+            source: {
+              ip: ['8.8.8.8'],
+            },
             host: {
               id: ['host-id-1'],
               name: ['host-2'],
@@ -70,7 +72,9 @@ export const mockData: { Authentications: HostAuthenticationsStrategyResponse }
           user: { name: ['Braden Hassanabad'] },
           lastSuccess: {
             timestamp: '2019-01-23T22:35:32.222Z',
-            'source.ip': '127.0.0.1',
+            source: {
+              ip: ['127.0.0.1'],
+            },
             host: {
               id: ['host-id-1'],
               name: ['host-1'],