add explicit contract for monitoring setup

elastic · Feb 1, 2021 · b6074c7 · b6074c7
1 parent 1dcfcd9
commit b6074c7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/x-pack/plugins/monitoring/server/index.ts b/x-pack/plugins/monitoring/server/index.ts
@@ -12,6 +12,8 @@ import { deprecations } from './deprecations';
 
 export { KibanaSettingsCollector } from './kibana_monitoring/collectors';
 export { MonitoringConfig } from './config';
+export { MonitoringPluginSetup, IBulkUploader } from './types';
+
 export const plugin = (initContext: PluginInitializerContext) => new MonitoringPlugin(initContext);
 export const config: PluginConfigDescriptor<TypeOf<typeof configSchema>> = {
   schema: configSchema,

diff --git a/x-pack/plugins/monitoring/server/plugin.ts b/x-pack/plugins/monitoring/server/plugin.ts
@@ -40,6 +40,7 @@ import { AlertsFactory } from './alerts';
 import {
   MonitoringCore,
   MonitoringLicenseService,
+  MonitoringPluginSetup,
   LegacyShimDependencies,
   IBulkUploader,
   PluginsSetup,
@@ -63,7 +64,8 @@ const wrapError = (error: any): CustomHttpResponseOptions<ResponseError> => {
   };
 };
 
-export class MonitoringPlugin implements Plugin<any, void, PluginsSetup, PluginsStart> {
+export class MonitoringPlugin
+  implements Plugin<MonitoringPluginSetup, void, PluginsSetup, PluginsStart> {
   private readonly initializerContext: PluginInitializerContext;
   private readonly log: Logger;
   private readonly getLogger: (...scopes: string[]) => Logger;

diff --git a/x-pack/plugins/monitoring/server/types.ts b/x-pack/plugins/monitoring/server/types.ts
@@ -92,6 +92,10 @@ export interface IBulkUploader {
   stop: () => void;
 }
 
+export interface MonitoringPluginSetup {
+  getKibanaStats: IBulkUploader['getKibanaStats'];
+}
+
 export interface LegacyRequest {
   logger: Logger;
   getLogger: (...scopes: string[]) => Logger;