remove isConfigurable from the actionfactory

x-pack/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/containers/action_factory_picker/action_factory_picker.tsx

@@ -6,6 +6,7 @@
  */
 
 import React from 'react';
+import { EuiLoadingSpinner } from '@elastic/eui';
 import { ActionFactoryPicker as ActionFactoryPickerUi } from '../../../../components/action_factory_picker';
 import { useDrilldownManager } from '../context';
 import { ActionFactoryView } from '../action_factory_view';
@@ -14,17 +15,19 @@ export const ActionFactoryPicker: React.FC = ({}) => {
   const drilldowns = useDrilldownManager();
   const factory = drilldowns.useActionFactory();
   const context = React.useMemo(() => drilldowns.getActionFactoryContext(), [drilldowns]);
-  const applicableFactories = drilldowns.deps.actionFactories.filter((actionFactory) =>
-    actionFactory.isConfigurable(context)
-  );
+  const compatibleFactories = drilldowns.useCompatibleActionFactories(context);
 
   if (!!factory) {
     return <ActionFactoryView factory={factory} context={context} />;
   }
 
+  if (!compatibleFactories) {
+    return <EuiLoadingSpinner size="m" />;
+  }
+
   return (
     <ActionFactoryPickerUi
-      actionFactories={applicableFactories}
+      actionFactories={compatibleFactories}
       context={context}
       onSelect={(actionFactory) => {
         drilldowns.setActionFactory(actionFactory);

x-pack/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/state/drilldown_manager_state.ts

@@ -6,9 +6,10 @@
  */
 
 import useObservable from 'react-use/lib/useObservable';
-import { BehaviorSubject } from 'rxjs';
+import { BehaviorSubject, Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
 import type { SerializableRecord } from '@kbn/utility-types';
+import { useMemo } from 'react';
 import {
   PublicDrilldownManagerProps,
   DrilldownManagerDependencies,
@@ -255,6 +256,24 @@ export class DrilldownManagerState {
     return context;
   }
 
+  public getCompatibleActionFactories(
+    context: BaseActionFactoryContext
+  ): Observable<ActionFactory[] | undefined> {
+    const compatibleActionFactories$ = new BehaviorSubject<undefined | ActionFactory[]>(undefined);
+    Promise.allSettled(
+      this.deps.actionFactories.map((factory) => factory.isCompatible(context))
+    ).then((factoryCompatibility) => {
+      compatibleActionFactories$.next(
+        this.deps.actionFactories.filter((_factory, i) => {
+          const result = factoryCompatibility[i];
+          // treat failed isCompatible checks as non-compatible
+          return result.status === 'fulfilled' && result.value;
+        })
+      );
+    });
+    return compatibleActionFactories$.asObservable();
+  }
+
   /**
    * Get state object of the drilldown which is currently being created.
    */
@@ -478,4 +497,9 @@ export class DrilldownManagerState {
   public readonly useActionFactory = () =>
     useObservable(this.actionFactory$, this.actionFactory$.getValue());
   public readonly useEvents = () => useObservable(this.events$, this.events$.getValue());
+  public readonly useCompatibleActionFactories = (context: BaseActionFactoryContext) =>
+    useObservable(
+      useMemo(() => this.getCompatibleActionFactories(context), [context]),
+      undefined
+    );
 }

x-pack/plugins/ui_actions_enhanced/public/dynamic_actions/action_factory.ts

@@ -55,7 +55,6 @@ export class ActionFactory<
   public readonly createConfig: (context: FactoryContext) => Config;
   public readonly isConfigValid: (config: Config, context: FactoryContext) => boolean;
   public readonly migrations: MigrateFunctionsObject | GetMigrationFunctionObjectFn;
-  public readonly isConfigurable: (context: FactoryContext) => boolean;
 
   constructor(
     protected readonly def: ActionFactoryDefinition<Config, ExecutionContext, FactoryContext>,
@@ -78,7 +77,6 @@ export class ActionFactory<
     this.ReactCollectConfig = uiToReactComponent(this.CollectConfig);
     this.createConfig = this.def.createConfig;
     this.isConfigValid = this.def.isConfigValid;
-    this.isConfigurable = this.def.isConfigurable || (() => true);
     this.migrations = this.def.migrations || {};
   }
 

x-pack/plugins/ui_actions_enhanced/public/dynamic_actions/action_factory_definition.ts

@@ -63,11 +63,5 @@ export interface ActionFactoryDefinition<
     serializedAction: Omit<SerializedAction<Config>, 'factoryId'>
   ): ActionDefinition<ExecutionContext>;
 
-  /**
-   * Compatibility check during drilldown creation.
-   * Could be used to filter out a drilldown if it's not compatible with the current context.
-   */
-  isConfigurable?(context: FactoryContext): boolean;
-
   supportedTriggers(): string[];
 }

x-pack/plugins/ui_actions_enhanced/public/services/ui_actions_service_enhancements.ts

@@ -136,8 +136,7 @@ export class UiActionsServiceEnhancements
       extract,
       inject,
       getIconType: () => euiIcon,
-      isCompatible: async () => true,
-      isConfigurable: (context) => !isConfigurable || isConfigurable(context),
+      isCompatible: async (context) => !isConfigurable || isConfigurable(context),
       create: (serializedAction) => ({
         id: '',
         type: factoryId,