[NP Cleanup] Remove ui/public/inspector (#55677) (#56271)

* Use src/plugins/inspector instead of ui/inspector

* Remove unused ui/inspector

* Use `inspector` plugin directly to register view

* Fix path

* Use inspector from NP

* Revert view registration to a separate file

src/legacy/core_plugins/kibana/public/discover/kibana_services.ts

@@ -62,8 +62,6 @@ export { getRequestInspectorStats, getResponseInspectorStats } from '../../../da
 export { intervalOptions } from 'ui/agg_types/buckets/_interval_options';
 // @ts-ignore
 export { migrateLegacyQuery } from 'ui/utils/migrate_legacy_query';
-// @ts-ignore
-export { RequestAdapter } from 'ui/inspector/adapters';
 export { SavedObjectSaveModal } from 'ui/saved_objects/components/saved_object_save_modal';
 export { showSaveModal } from 'ui/saved_objects/show_saved_object_save_modal';
 export { stateMonitorFactory } from 'ui/state_management/state_monitor_factory';
@@ -92,7 +90,6 @@ export {
   SortDirection,
 } from '../../../../../plugins/data/public';
 export { ElasticSearchHit } from './np_ready/doc_views/doc_views_types';
-export { Adapters } from 'ui/inspector/types';
 export { registerTimefilterWithGlobalStateFactory } from 'ui/timefilter/setup_router';
 export { FieldName } from 'ui/directives/field_name/field_name';
 export { getFormat } from 'ui/visualize/loader/pipeline_helpers/utilities';

src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js

@@ -25,6 +25,7 @@ import dateMath from '@elastic/datemath';
 import { i18n } from '@kbn/i18n';
 import '../components/field_chooser/field_chooser';
 
+import { RequestAdapter } from '../../../../../../../plugins/inspector/public';
 // doc table
 import './doc_table';
 import { getSort } from './doc_table/lib/get_sort';
@@ -46,7 +47,6 @@ import {
   hasSearchStategyForIndexPattern,
   intervalOptions,
   migrateLegacyQuery,
-  RequestAdapter,
   showSaveModal,
   unhashUrl,
   stateMonitorFactory,

src/legacy/core_plugins/kibana/public/discover/np_ready/embeddable/search_embeddable.ts

@@ -21,6 +21,7 @@ import * as Rx from 'rxjs';
 import { Subscription } from 'rxjs';
 import { i18n } from '@kbn/i18n';
 import { TExecuteTriggerActions } from 'src/plugins/ui_actions/public';
+import { RequestAdapter, Adapters } from '../../../../../../../plugins/inspector/public';
 import {
   esFilters,
   TimeRange,
@@ -43,13 +44,11 @@ import { ISearchEmbeddable, SearchInput, SearchOutput } from './types';
 import { SortOrder } from '../angular/doc_table/components/table_header/helpers';
 import { getSortForSearchSource } from '../angular/doc_table/lib/get_sort_for_search_source';
 import {
-  Adapters,
   angular,
   getRequestInspectorStats,
   getResponseInspectorStats,
   getServices,
   IndexPattern,
-  RequestAdapter,
   ISearchSource,
 } from '../../kibana_services';
 import { SEARCH_EMBEDDABLE_TYPE } from './constants';

src/legacy/ui/public/agg_types/agg_type.ts

@@ -24,7 +24,7 @@ import { initParams } from './agg_params';
 
 import { AggConfig } from '../vis';
 import { AggConfigs } from './agg_configs';
-import { Adapters } from '../inspector';
+import { Adapters } from '../../../../plugins/inspector/public';
 import { BaseParamType } from './param_types/base';
 import { AggParamType } from '../agg_types/param_types/agg';
 import { KBN_FIELD_TYPES, fieldFormats, ISearchSource } from '../../../../plugins/data/public';

x-pack/legacy/plugins/lens/public/editor_frame_plugin/embeddable/embeddable.test.tsx

@@ -9,7 +9,7 @@ import { ExpressionRendererProps } from 'src/plugins/expressions/public';
 import { Query, TimeRange, esFilters } from 'src/plugins/data/public';
 import { Document } from '../../persistence';
 
-jest.mock('../../../../../../../src/legacy/ui/public/inspector', () => ({
+jest.mock('../../../../../../../src/plugins/inspector/public/', () => ({
   isAvailable: false,
   open: false,
 }));

x-pack/legacy/plugins/maps/public/angular/map_controller.js

@@ -43,9 +43,8 @@ import {
   getLayerListRaw,
 } from '../selectors/map_selectors';
 import { getInspectorAdapters } from '../reducers/non_serializable_instances';
-import { Inspector } from 'ui/inspector';
 import { docTitle } from 'ui/doc_title';
-import { indexPatternService } from '../kibana_services';
+import { indexPatternService, getInspector } from '../kibana_services';
 import { SavedObjectSaveModal } from 'ui/saved_objects/components/saved_object_save_modal';
 import { showSaveModal } from 'ui/saved_objects/show_saved_object_save_modal';
 import { toastNotifications } from 'ui/notify';
@@ -510,7 +509,7 @@ app.controller(
         testId: 'openInspectorButton',
         run() {
           const inspectorAdapters = getInspectorAdapters(store.getState());
-          Inspector.open(inspectorAdapters, {});
+          getInspector().open(inspectorAdapters, {});
         },
       },
       ...(capabilities.get().maps.save

x-pack/legacy/plugins/maps/public/inspector/views/register_views.js → x-pack/legacy/plugins/maps/public/inspector/views/register_views.ts

@@ -4,8 +4,9 @@
  * you may not use this file except in compliance with the Elastic License.
  */
 
-import { MapView } from './map_view';
+import { npSetup } from 'ui/new_platform';
 
-import { viewRegistry } from 'ui/inspector';
+// @ts-ignore
+import { MapView } from './map_view';
 
-viewRegistry.register(MapView);
+npSetup.plugins.inspector.registerView(MapView);

x-pack/legacy/plugins/maps/public/kibana_services.js

@@ -21,6 +21,12 @@ export const getLicenseId = () => {
   return licenseId;
 };
 
+let inspector;
+export const setInspector = newInspector => (inspector = newInspector);
+export const getInspector = () => {
+  return inspector;
+};
+
 export async function fetchSearchSourceAndRecordWithInspector({
   searchSource,
   requestId,

x-pack/legacy/plugins/maps/public/plugin.ts

@@ -10,7 +10,7 @@ import { wrapInI18nContext } from 'ui/i18n';
 // @ts-ignore
 import { MapListing } from './components/map_listing';
 // @ts-ignore
-import { setLicenseId } from './kibana_services';
+import { setLicenseId, setInspector } from './kibana_services';
 
 /**
  * These are the interfaces with your public contracts. You should export these
@@ -39,5 +39,7 @@ export class MapsPlugin implements Plugin<MapsPluginSetup, MapsPluginStart> {
     }
   }
 
-  public start(core: CoreStart, plugins: any) {}
+  public start(core: CoreStart, plugins: any) {
+    setInspector(plugins.np.inspector);
+  }
 }

x-pack/legacy/plugins/maps/public/reducers/non_serializable_instances.js

@@ -5,7 +5,7 @@
  */
 
 import chrome from 'ui/chrome';
-import { RequestAdapter } from 'ui/inspector/adapters';
+import { RequestAdapter } from '../../../../../../src/plugins/inspector/public';
 import { MapAdapter } from '../inspector/adapters/map_adapter';
 
 const REGISTER_CANCEL_CALLBACK = 'REGISTER_CANCEL_CALLBACK';