⚡ Improve getOperationSupportMatrix performance

elastic · Nov 6, 2020 · c2bd377 · c2bd377
1 parent f586105
commit c2bd377
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/operation_support.ts b/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/operation_support.ts
@@ -37,16 +37,17 @@ export const getOperationSupportMatrix = (props: Props): OperationSupportMatrix
 
   filteredOperationsByMetadata.forEach(({ operations }) => {
     operations.forEach((operation) => {
+      // replace spread operator by regular push as it's performance wise faster
       if (operation.type === 'field') {
-        supportedOperationsByField[operation.field] = [
-          ...(supportedOperationsByField[operation.field] ?? []),
-          operation.operationType,
-        ];
-
-        supportedFieldsByOperation[operation.operationType] = [
-          ...(supportedFieldsByOperation[operation.operationType] ?? []),
-          operation.field,
-        ];
+        if (!supportedOperationsByField[operation.field]) {
+          supportedOperationsByField[operation.field] = [];
+        }
+        supportedOperationsByField[operation.field]?.push(operation.operationType);
+
+        if (!supportedFieldsByOperation[operation.operationType]) {
+          supportedFieldsByOperation[operation.operationType] = [];
+        }
+        supportedFieldsByOperation[operation.operationType]?.push(operation.field);
       } else if (operation.type === 'none') {
         supportedOperationsWithoutField.push(operation.operationType);
       }

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/operations.ts b/x-pack/plugins/lens/public/indexpattern_datasource/operations/operations.ts
@@ -146,8 +146,8 @@ export function getAvailableOperationsByMetadata(indexPattern: IndexPattern) {
 
   operationDefinitions.sort(getSortScoreByPriority).forEach((operationDefinition) => {
     if (operationDefinition.input === 'field') {
-      indexPattern.fields.forEach((field) => {
-        addToMap(
+      return indexPattern.fields.forEach((field) => {
+        return addToMap(
           {
             type: 'field',
             operationType: operationDefinition.type,
@@ -156,8 +156,9 @@ export function getAvailableOperationsByMetadata(indexPattern: IndexPattern) {
           operationDefinition.getPossibleOperationForField(field)
         );
       });
-    } else if (operationDefinition.input === 'none') {
-      addToMap(
+    }
+    if (operationDefinition.input === 'none') {
+      return addToMap(
         {
           type: 'none',
           operationType: operationDefinition.type,