[TSVB] Renamed 'positive rate' to 'counter rate' (#80939) (#82102)

* Renamed 'positive rate' label text to 'counter rate' * Removed translations(ja-JP, zh-CN) where the labels were updated Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: DB <batchunag@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
elastic · Oct 30, 2020 · d20b820 · d20b820
1 parent 5e87ce5
commit d20b820
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 11 deletions.
diff --git a/src/plugins/vis_type_timeseries/common/agg_lookup.js b/src/plugins/vis_type_timeseries/common/agg_lookup.js
@@ -98,7 +98,7 @@ export const lookup = {
  }),
  top_hit: i18n.translate('visTypeTimeseries.aggLookup.topHitLabel', { defaultMessage: 'Top Hit' }),
  positive_rate: i18n.translate('visTypeTimeseries.aggLookup.positiveRateLabel', {
- defaultMessage: 'Positive Rate',
+ defaultMessage: 'Counter Rate',
  }),
 };
 

diff --git a/src/plugins/vis_type_timeseries/common/calculate_label.js b/src/plugins/vis_type_timeseries/common/calculate_label.js
@@ -72,7 +72,7 @@ export function calculateLabel(metric, metrics) {
  }
  if (metric.type === 'positive_rate') {
  return i18n.translate('visTypeTimeseries.calculateLabel.positiveRateLabel', {
- defaultMessage: 'Positive Rate of {field}',
+ defaultMessage: 'Counter Rate of {field}',
  values: { field: metric.field },
  });
  }

diff --git a/src/plugins/vis_type_timeseries/public/application/components/aggs/agg_select.test.tsx b/src/plugins/vis_type_timeseries/public/application/components/aggs/agg_select.test.tsx
@@ -63,7 +63,7 @@ describe('TSVB AggSelect', () => {
  "value": "count",
  },
  Object {
- "label": "Positive Rate",
+ "label": "Counter Rate",
  "value": "positive_rate",
  },
  Object {
@@ -131,7 +131,7 @@ describe('TSVB AggSelect', () => {
  "value": "filter_ratio",
  },
  Object {
- "label": "Positive Rate",
+ "label": "Counter Rate",
  "value": "positive_rate",
  },
  Object {

diff --git a/src/plugins/vis_type_timeseries/public/application/components/aggs/agg_select.tsx b/src/plugins/vis_type_timeseries/public/application/components/aggs/agg_select.tsx
@@ -54,7 +54,7 @@ const metricAggs: AggSelectOption[] = [
  },
  {
  label: i18n.translate('visTypeTimeseries.aggSelect.metricsAggs.positiveRateLabel', {
- defaultMessage: 'Positive Rate',
+ defaultMessage: 'Counter Rate',
  }),
  value: 'positive_rate',
  },

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -3806,7 +3806,6 @@
  "visTypeTimeseries.aggLookup.percentileLabel": "パーセンタイル",
  "visTypeTimeseries.aggLookup.percentileRankLabel": "パーセンタイルランク",
  "visTypeTimeseries.aggLookup.positiveOnlyLabel": "プラスのみ",
- "visTypeTimeseries.aggLookup.positiveRateLabel": "正の割合",
  "visTypeTimeseries.aggLookup.serialDifferenceLabel": "連続差",
  "visTypeTimeseries.aggLookup.seriesAggLabel": "数列集約",
  "visTypeTimeseries.aggLookup.staticValueLabel": "不動値",
@@ -3829,7 +3828,6 @@
  "visTypeTimeseries.aggSelect.metricsAggs.minLabel": "最低",
  "visTypeTimeseries.aggSelect.metricsAggs.percentileLabel": "パーセンタイル",
  "visTypeTimeseries.aggSelect.metricsAggs.percentileRankLabel": "パーセンタイルランク",
- "visTypeTimeseries.aggSelect.metricsAggs.positiveRateLabel": "正の割合",
  "visTypeTimeseries.aggSelect.metricsAggs.staticValueLabel": "不動値",
  "visTypeTimeseries.aggSelect.metricsAggs.stdDeviationLabel": "標準偏差",
  "visTypeTimeseries.aggSelect.metricsAggs.sumLabel": "合計",
@@ -3873,7 +3871,6 @@
  "visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetLabel": "{targetLabel} 中 {lookupMetricType}",
  "visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetWithAdditionalLabel": "{targetLabel} ({additionalLabel}) 中 {lookupMetricType}",
  "visTypeTimeseries.calculateLabel.mathLabel": "数学処理",
- "visTypeTimeseries.calculateLabel.positiveRateLabel": "{field}の正の割合",
  "visTypeTimeseries.calculateLabel.seriesAggLabel": "数列集約 ({metricFunction})",
  "visTypeTimeseries.calculateLabel.staticValueLabel": "{metricValue} の不動値",
  "visTypeTimeseries.calculateLabel.unknownLabel": "不明",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -3807,7 +3807,6 @@
  "visTypeTimeseries.aggLookup.percentileLabel": "百分位数",
  "visTypeTimeseries.aggLookup.percentileRankLabel": "百分位数排名",
  "visTypeTimeseries.aggLookup.positiveOnlyLabel": "仅正数",
- "visTypeTimeseries.aggLookup.positiveRateLabel": "正比率",
  "visTypeTimeseries.aggLookup.serialDifferenceLabel": "串行差分",
  "visTypeTimeseries.aggLookup.seriesAggLabel": "序列聚合",
  "visTypeTimeseries.aggLookup.staticValueLabel": "静态值",
@@ -3830,7 +3829,6 @@
  "visTypeTimeseries.aggSelect.metricsAggs.minLabel": "最小值",
  "visTypeTimeseries.aggSelect.metricsAggs.percentileLabel": "百分位数",
  "visTypeTimeseries.aggSelect.metricsAggs.percentileRankLabel": "百分位数排名",
- "visTypeTimeseries.aggSelect.metricsAggs.positiveRateLabel": "正比率",
  "visTypeTimeseries.aggSelect.metricsAggs.staticValueLabel": "静态值",
  "visTypeTimeseries.aggSelect.metricsAggs.stdDeviationLabel": "标准偏差",
  "visTypeTimeseries.aggSelect.metricsAggs.sumLabel": "和",
@@ -3874,7 +3872,6 @@
  "visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetLabel": "{targetLabel} 的 {lookupMetricType}",
  "visTypeTimeseries.calculateLabel.lookupMetricTypeOfTargetWithAdditionalLabel": "{targetLabel} ({additionalLabel}) 的 {lookupMetricType}",
  "visTypeTimeseries.calculateLabel.mathLabel": "数学",
- "visTypeTimeseries.calculateLabel.positiveRateLabel": "{field} 的正比率",
  "visTypeTimeseries.calculateLabel.seriesAggLabel": "序列聚合 ({metricFunction})",
  "visTypeTimeseries.calculateLabel.staticValueLabel": "{metricValue} 的静态值",
  "visTypeTimeseries.calculateLabel.unknownLabel": "未知",