addressing PR comments

elastic · Apr 19, 2021 · d2eb3e2 · d2eb3e2
1 parent f6efc42
commit d2eb3e2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/...lugins/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx b/...lugins/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx
@@ -114,13 +114,13 @@ export function ServiceOverviewErrorsTable({ serviceName }: Props) {
         ).slice(pageIndex * PAGE_SIZE, (pageIndex + 1) * PAGE_SIZE);
 
         return {
+          // Everytime the primary statistics is refetched, updates the requestId making the comparison API to be refetched.
           requestId: uuid(),
           items: currentPageErrorGroups,
           totalItems: response.error_groups.length,
         };
       });
     },
-    // comparisonType is listed as dependency even thought it is not used. This is needed to trigger the comparison api when it is changed.
     // eslint-disable-next-line react-hooks/exhaustive-deps
     [
       environment,
@@ -132,7 +132,9 @@ export function ServiceOverviewErrorsTable({ serviceName }: Props) {
       pageIndex,
       direction,
       field,
+      // not used, but needed to trigger an update when comparisonType is changed either manually by user or when time range is changed
       comparisonType,
+      // not used, but needed to trigger an update when comparison feature is disabled/enabled by user
       comparisonEnabled,
     ]
   );

diff --git a/...apm/public/components/app/service_overview/service_overview_instances_chart_and_table.tsx b/...apm/public/components/app/service_overview/service_overview_instances_chart_and_table.tsx
@@ -135,13 +135,13 @@ export function ServiceOverviewInstancesChartAndTable({
         ).slice(pageIndex * PAGE_SIZE, (pageIndex + 1) * PAGE_SIZE);
 
         return {
+          // Everytime the primary statistics is refetched, updates the requestId making the comparison API to be refetched.
           primaryStatsRequestId: uuid(),
           primaryStatsItems,
           primaryStatsItemCount: response.serviceInstances.length,
         };
       });
     },
-    // comparisonType is listed as dependency even thought it is not used. This is needed to trigger the comparison api when it is changed.
     // eslint-disable-next-line react-hooks/exhaustive-deps
     [
       environment,
@@ -154,7 +154,9 @@ export function ServiceOverviewInstancesChartAndTable({
       pageIndex,
       field,
       direction,
+      // not used, but needed to trigger an update when comparisonType is changed either manually by user or when time range is changed
       comparisonType,
+      // not used, but needed to trigger an update when comparison feature is disabled/enabled by user
       comparisonEnabled,
     ]
   );

diff --git a/.../apm/public/components/app/service_overview/service_overview_transactions_table/index.tsx b/.../apm/public/components/app/service_overview/service_overview_transactions_table/index.tsx
@@ -115,7 +115,6 @@ export function ServiceOverviewTransactionsTable({ serviceName }: Props) {
         };
       });
     },
-    // comparisonType is listed as dependency even thought it is not used. This is needed to trigger the comparison api when it is changed.
     // eslint-disable-next-line react-hooks/exhaustive-deps
     [
       environment,
@@ -128,7 +127,9 @@ export function ServiceOverviewTransactionsTable({ serviceName }: Props) {
       pageIndex,
       direction,
       field,
+      // not used, but needed to trigger an update when comparisonType is changed either manually by user or when time range is changed
       comparisonType,
+      // not used, but needed to trigger an update when comparison feature is disabled/enabled by user
       comparisonEnabled,
     ]
   );